* [PATCH] Coding style fixes on vme_user.c trivial
@ 2019-03-01 14:27 Oryan Perlmutter
2019-03-01 15:18 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Oryan Perlmutter @ 2019-03-01 14:27 UTC (permalink / raw)
To: martyn, manohar.vanga, gregkh, devel, trivial
Cc: Oryan Perlmutter, Christophe JAILLET, linux-kernel
drivers/staging/devices: Coding style fixes found at file vme_user.c.
Signed-off-by: Oryan Perlmutter <oryan.perl1997@gmail.com>
---
drivers/staging/vme/devices/vme_user.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c
index 6a33aaa1a49f..4c7db4f5f15e 100644
--- a/drivers/staging/vme/devices/vme_user.c
+++ b/drivers/staging/vme/devices/vme_user.c
@@ -506,7 +506,7 @@ static int vme_user_match(struct vme_dev *vdev)
int cur_slot = vme_slot_num(vdev);
for (i = 0; i < bus_num; i++)
- if ((cur_bus == bus[i]) && (cur_slot == vdev->num))
+ if (cur_bus == bus[i] && cur_slot == vdev->num)
return 1;
return 0;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Coding style fixes on vme_user.c trivial
2019-03-01 14:27 [PATCH] Coding style fixes on vme_user.c trivial Oryan Perlmutter
@ 2019-03-01 15:18 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2019-03-01 15:18 UTC (permalink / raw)
To: Oryan Perlmutter
Cc: martyn, manohar.vanga, devel, trivial, Christophe JAILLET, linux-kernel
On Fri, Mar 01, 2019 at 04:27:25PM +0200, Oryan Perlmutter wrote:
> drivers/staging/devices: Coding style fixes found at file vme_user.c.
Your subject line, and this changelog text, need a lot of work. Please
look at the other patches that have been accepted for this driver as
examples of how to do this properly.
>
> Signed-off-by: Oryan Perlmutter <oryan.perl1997@gmail.com>
> ---
> drivers/staging/vme/devices/vme_user.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c
> index 6a33aaa1a49f..4c7db4f5f15e 100644
> --- a/drivers/staging/vme/devices/vme_user.c
> +++ b/drivers/staging/vme/devices/vme_user.c
> @@ -506,7 +506,7 @@ static int vme_user_match(struct vme_dev *vdev)
> int cur_slot = vme_slot_num(vdev);
>
> for (i = 0; i < bus_num; i++)
> - if ((cur_bus == bus[i]) && (cur_slot == vdev->num))
> + if (cur_bus == bus[i] && cur_slot == vdev->num)
Personally, I like the original code here, it's more explicit as to what
is going on.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-01 15:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-01 14:27 [PATCH] Coding style fixes on vme_user.c trivial Oryan Perlmutter
2019-03-01 15:18 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).