* [PATCH] fsl/fman: Use vsprintf extension %pM
@ 2019-03-02 0:37 Joe Perches
2019-03-04 5:10 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Joe Perches @ 2019-03-02 0:37 UTC (permalink / raw)
To: Madalin Bucur; +Cc: David S. Miller, netdev, linux-kernel
Make logging of an ethernet address more consistent with
the rest of the kernel.
Miscellanea:
The %02hx use also did not quite match the u8 definition
of addr though that did not actually matter given normal
integer promotion rules.
Signed-off-by: Joe Perches <joe@perches.com>
---
drivers/net/ethernet/freescale/fman/mac.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fman/mac.c b/drivers/net/ethernet/freescale/fman/mac.c
index 71f4205f14e7..3c21486c6c84 100644
--- a/drivers/net/ethernet/freescale/fman/mac.c
+++ b/drivers/net/ethernet/freescale/fman/mac.c
@@ -855,9 +855,7 @@ static int mac_probe(struct platform_device *_of_dev)
if (err < 0)
dev_err(dev, "fman_set_mac_active_pause() = %d\n", err);
- dev_info(dev, "FMan MAC address: %02hx:%02hx:%02hx:%02hx:%02hx:%02hx\n",
- mac_dev->addr[0], mac_dev->addr[1], mac_dev->addr[2],
- mac_dev->addr[3], mac_dev->addr[4], mac_dev->addr[5]);
+ dev_info(dev, "FMan MAC address: %pM\n", mac_dev->addr);
priv->eth_dev = dpaa_eth_add_device(fman_id, mac_dev);
if (IS_ERR(priv->eth_dev)) {
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fsl/fman: Use vsprintf extension %pM
2019-03-02 0:37 [PATCH] fsl/fman: Use vsprintf extension %pM Joe Perches
@ 2019-03-04 5:10 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-03-04 5:10 UTC (permalink / raw)
To: joe; +Cc: madalin.bucur, netdev, linux-kernel
From: Joe Perches <joe@perches.com>
Date: Fri, 01 Mar 2019 16:37:25 -0800
> Make logging of an ethernet address more consistent with
> the rest of the kernel.
>
> Miscellanea:
>
> The %02hx use also did not quite match the u8 definition
> of addr though that did not actually matter given normal
> integer promotion rules.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Applied to net-next, thanks Joe.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-04 5:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-02 0:37 [PATCH] fsl/fman: Use vsprintf extension %pM Joe Perches
2019-03-04 5:10 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).