* [PATCH] regulator: tps65086: Fix tps65086_ldoa1_ranges for selector 0xB
@ 2019-03-04 8:57 Axel Lin
2019-03-04 14:13 ` Andrew F. Davis
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2019-03-04 8:57 UTC (permalink / raw)
To: Mark Brown
Cc: Steven Kipisz, Andrew F . Davis, Liam Girdwood, linux-kernel, Axel Lin
selector 0xB (1011) should be 2.6V rather than 2.7V, fit ix.
Table 5-4. LDOA1 Output Voltage Options
VID Bits VOUT VID Bits VOUT VID Bits VOUT VID Bits VOUT
0000 1.35 0100 1.8 1000 2.3 1100 2.85
0001 1.5 0101 1.9 1001 2.4 1101 3.0
0010 1.6 0110 2.0 1010 2.5 1110 3.3
0011 1.7 0111 2.1 1011 2.6 1111 Not Used
Fixes: d2a2e729a666 ("regulator: tps65086: Add regulator driver for the TPS65086 PMIC")
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
Hi Steven and Andrew,
I don't have this h/w to test. Can you help to verify it?
Thanks,
Axel
drivers/regulator/tps65086-regulator.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/tps65086-regulator.c b/drivers/regulator/tps65086-regulator.c
index 45e96e154690..5a5e9b5bf4be 100644
--- a/drivers/regulator/tps65086-regulator.c
+++ b/drivers/regulator/tps65086-regulator.c
@@ -90,8 +90,8 @@ static const struct regulator_linear_range tps65086_buck345_25mv_ranges[] = {
static const struct regulator_linear_range tps65086_ldoa1_ranges[] = {
REGULATOR_LINEAR_RANGE(1350000, 0x0, 0x0, 0),
REGULATOR_LINEAR_RANGE(1500000, 0x1, 0x7, 100000),
- REGULATOR_LINEAR_RANGE(2300000, 0x8, 0xA, 100000),
- REGULATOR_LINEAR_RANGE(2700000, 0xB, 0xD, 150000),
+ REGULATOR_LINEAR_RANGE(2300000, 0x8, 0xB, 100000),
+ REGULATOR_LINEAR_RANGE(2850000, 0xC, 0xD, 150000),
REGULATOR_LINEAR_RANGE(3300000, 0xE, 0xE, 0),
};
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] regulator: tps65086: Fix tps65086_ldoa1_ranges for selector 0xB
2019-03-04 8:57 [PATCH] regulator: tps65086: Fix tps65086_ldoa1_ranges for selector 0xB Axel Lin
@ 2019-03-04 14:13 ` Andrew F. Davis
0 siblings, 0 replies; 2+ messages in thread
From: Andrew F. Davis @ 2019-03-04 14:13 UTC (permalink / raw)
To: Axel Lin, Mark Brown; +Cc: Liam Girdwood, linux-kernel
On 3/4/19 2:57 AM, Axel Lin wrote:
> selector 0xB (1011) should be 2.6V rather than 2.7V, fit ix.
>
> Table 5-4. LDOA1 Output Voltage Options
> VID Bits VOUT VID Bits VOUT VID Bits VOUT VID Bits VOUT
> 0000 1.35 0100 1.8 1000 2.3 1100 2.85
> 0001 1.5 0101 1.9 1001 2.4 1101 3.0
> 0010 1.6 0110 2.0 1010 2.5 1110 3.3
> 0011 1.7 0111 2.1 1011 2.6 1111 Not Used
>
> Fixes: d2a2e729a666 ("regulator: tps65086: Add regulator driver for the TPS65086 PMIC")
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> Hi Steven and Andrew,
> I don't have this h/w to test. Can you help to verify it?
>
I'll dig one of these out for testing, I'll report back here if
something is wrong, but for now you are correct according to the
datasheet so:
Acked-by: Andrew F. Davis <afd@ti.com>
> Thanks,
> Axel
>
> drivers/regulator/tps65086-regulator.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/regulator/tps65086-regulator.c b/drivers/regulator/tps65086-regulator.c
> index 45e96e154690..5a5e9b5bf4be 100644
> --- a/drivers/regulator/tps65086-regulator.c
> +++ b/drivers/regulator/tps65086-regulator.c
> @@ -90,8 +90,8 @@ static const struct regulator_linear_range tps65086_buck345_25mv_ranges[] = {
> static const struct regulator_linear_range tps65086_ldoa1_ranges[] = {
> REGULATOR_LINEAR_RANGE(1350000, 0x0, 0x0, 0),
> REGULATOR_LINEAR_RANGE(1500000, 0x1, 0x7, 100000),
> - REGULATOR_LINEAR_RANGE(2300000, 0x8, 0xA, 100000),
> - REGULATOR_LINEAR_RANGE(2700000, 0xB, 0xD, 150000),
> + REGULATOR_LINEAR_RANGE(2300000, 0x8, 0xB, 100000),
> + REGULATOR_LINEAR_RANGE(2850000, 0xC, 0xD, 150000),
> REGULATOR_LINEAR_RANGE(3300000, 0xE, 0xE, 0),
> };
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-04 14:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-04 8:57 [PATCH] regulator: tps65086: Fix tps65086_ldoa1_ranges for selector 0xB Axel Lin
2019-03-04 14:13 ` Andrew F. Davis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).