From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Jagan Teki <jagan@amarulasolutions.com>
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Chen-Yu Tsai <wens@csie.org>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-amarula@amarulasolutions.com,
Michael Trimarchi <michael@amarulasolutions.com>,
linux-sunxi@googlegroups.com
Subject: Re: [PATCH v9 2/5] drm/sun4i: sun6i_mipi_dsi: Fix TCON DRQ set bits
Date: Mon, 4 Mar 2019 16:43:20 +0100 [thread overview]
Message-ID: <20190304154320.uledvwz5jhzt22o3@flea> (raw)
In-Reply-To: <20190303173527.31055-3-jagan@amarulasolutions.com>
[-- Attachment #1: Type: text/plain, Size: 1359 bytes --]
On Sun, Mar 03, 2019 at 11:05:24PM +0530, Jagan Teki wrote:
> TCON DRQ for non-burst DSI mode can computed based on horizontal
> front porch value, but the current driver trying to include sync
> timings along with front porch resulting wrong drq.
>
> This patch is trying to update the drq by subtracting hsync_start
> with hdisplay, which is horizontal front porch.
>
> Current code:
> ------------
> mode->hsync_end - mode->hdisplay => horizontal front porch + sync
>
> With this patch:
> ----------------
> mode->hsync_start - mode->hdisplay => horizontal front porch
>
> BSP code form BPI-M64-bsp is computing TCON DRQ set bits
> for non-burts as (from linux-sunxi/
> drivers/video/sunxi/disp2/disp/de/lowlevel_sun50iw1/de_dsi.c)
>
> => panel->lcd_ht - panel->lcd_x - panel->lcd_hbp
> => (timmings->hor_front_porch + panel->lcd_hbp + panel->lcd_x)
^ + sync length +
> - panel->lcd_x - panel->hbp
> => timmings->hor_front_porch
^ + sync
> => mode->hsync_start - mode->hdisplay
s/hsync_start/hsync_end/
Did you encounter any panel where this was fixing something? If so,
which one, and what is the matching timings and / or datasheet?
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2019-03-04 15:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-03 17:35 [PATCH v9 0/5] drm/sun4i: sun6i_mipi_dsi: Fixes/updates Jagan Teki
2019-03-03 17:35 ` [PATCH v9 1/5] drm/sun4i: sun6i_mipi_dsi: Fix hsync_porch overflow Jagan Teki
2019-03-04 15:54 ` Maxime Ripard
2019-03-06 19:02 ` Jagan Teki
2019-03-03 17:35 ` [PATCH v9 2/5] drm/sun4i: sun6i_mipi_dsi: Fix TCON DRQ set bits Jagan Teki
2019-03-04 15:43 ` Maxime Ripard [this message]
[not found] ` <CAMty3ZDWkLWgWhGWBjhXOsmAXzuGKGADAEhzB6gcL+jd7FRazQ@mail.gmail.com>
2019-03-07 15:39 ` Maxime Ripard
2019-03-07 15:54 ` Jagan Teki
2019-03-11 14:09 ` Maxime Ripard
2019-03-11 14:58 ` Jagan Teki
2019-03-19 10:56 ` Maxime Ripard
2019-03-28 11:53 ` Jagan Teki
2019-04-02 14:47 ` Maxime Ripard
2019-03-03 17:35 ` [PATCH v9 3/5] drm/sun4i: sun6i_mipi_dsi: Support vblk timing for 4-lane devices Jagan Teki
2019-03-04 15:49 ` Maxime Ripard
2019-03-07 16:03 ` Jagan Teki
2019-03-11 14:04 ` Maxime Ripard
2019-03-11 14:33 ` Jagan Teki
2019-03-03 17:35 ` [PATCH v9 4/5] drm/sun4i: sun6i_mipi_dsi: Support DSI GENERIC_SHORT_WRITE_2 transfer Jagan Teki
2019-03-03 17:35 ` [PATCH v9 5/5] drm/sun4i: sun6i_mipi_dsi: Simplify dsi setup timings code Jagan Teki
2019-03-04 15:50 ` Maxime Ripard
2019-03-07 11:46 ` Jagan Teki
2019-03-18 18:28 ` [PATCH v9 0/5] drm/sun4i: sun6i_mipi_dsi: Fixes/updates Jagan Teki
2019-03-19 10:58 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190304154320.uledvwz5jhzt22o3@flea \
--to=maxime.ripard@bootlin.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jagan@amarulasolutions.com \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=michael@amarulasolutions.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).