* [PATCH] fbdev: mbx: fix a misspelled variable name @ 2019-03-04 19:52 ` Arnd Bergmann 2019-03-05 11:36 ` Bartlomiej Zolnierkiewicz 0 siblings, 1 reply; 2+ messages in thread From: Arnd Bergmann @ 2019-03-04 19:52 UTC (permalink / raw) To: Bartlomiej Zolnierkiewicz, Greg Kroah-Hartman Cc: Arnd Bergmann, dri-devel, linux-fbdev, linux-kernel A recent cleanup introduced a build failure when a variable was spelled incorrectly: In file included from drivers/video/fbdev/mbx/mbxfb.c:881: drivers/video/fbdev/mbx/mbxdebugfs.c: In function 'mbxfb_debugfs_init': drivers/video/fbdev/mbx/mbxdebugfs.c:217:2: error: 'mbfi' undeclared (first use in this function); did you mean 'mfbi'? mbfi->debugfs_dir = dir; ^~~~ mfbi drivers/video/fbdev/mbx/mbxdebugfs.c:217:2: note: each undeclared identifier is reported only once for each function it appears in drivers/video/fbdev/mbx/mbxdebugfs.c:213:21: error: unused variable 'mfbi' [-Werror=unused-variable] struct mbxfb_info *mfbi = fbi->par; ^~~~ Fixes: 72aed9e31344 ("fbdev: mbx: fix up debugfs file creation") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/video/fbdev/mbx/mbxdebugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/mbx/mbxdebugfs.c b/drivers/video/fbdev/mbx/mbxdebugfs.c index 52cfe0132b25..09af721638fb 100644 --- a/drivers/video/fbdev/mbx/mbxdebugfs.c +++ b/drivers/video/fbdev/mbx/mbxdebugfs.c @@ -214,7 +214,7 @@ static void mbxfb_debugfs_init(struct fb_info *fbi) struct dentry *dir; dir = debugfs_create_dir("mbxfb", NULL); - mbfi->debugfs_dir = dir; + mfbi->debugfs_dir = dir; debugfs_create_file("sysconf", 0444, dir, fbi, &sysconf_fops); debugfs_create_file("clock", 0444, dir, fbi, &clock_fops); -- 2.20.0 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fbdev: mbx: fix a misspelled variable name 2019-03-04 19:52 ` [PATCH] fbdev: mbx: fix a misspelled variable name Arnd Bergmann @ 2019-03-05 11:36 ` Bartlomiej Zolnierkiewicz 0 siblings, 0 replies; 2+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2019-03-05 11:36 UTC (permalink / raw) To: Arnd Bergmann; +Cc: Greg Kroah-Hartman, dri-devel, linux-fbdev, linux-kernel On 03/04/2019 08:52 PM, Arnd Bergmann wrote: > A recent cleanup introduced a build failure when a variable > was spelled incorrectly: > > In file included from drivers/video/fbdev/mbx/mbxfb.c:881: > drivers/video/fbdev/mbx/mbxdebugfs.c: In function 'mbxfb_debugfs_init': > drivers/video/fbdev/mbx/mbxdebugfs.c:217:2: error: 'mbfi' undeclared (first use in this function); did you mean 'mfbi'? > mbfi->debugfs_dir = dir; > ^~~~ > mfbi > drivers/video/fbdev/mbx/mbxdebugfs.c:217:2: note: each undeclared identifier is reported only once for each function it appears in > drivers/video/fbdev/mbx/mbxdebugfs.c:213:21: error: unused variable 'mfbi' [-Werror=unused-variable] > struct mbxfb_info *mfbi = fbi->par; > ^~~~ > > Fixes: 72aed9e31344 ("fbdev: mbx: fix up debugfs file creation") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Patch queued for v5.1, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-05 11:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20190304195258epcas2p40c27a5bdcea32c4f03dfea58abc4cde8@epcas2p4.samsung.com>
2019-03-04 19:52 ` [PATCH] fbdev: mbx: fix a misspelled variable name Arnd Bergmann
2019-03-05 11:36 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).