* [PATCH] time: Make VIRT_CPU_ACCOUNTING_GEN depend on GENERIC_CLOCKEVENTS
@ 2019-03-04 20:01 Arnd Bergmann
2019-03-06 19:45 ` [tip:timers/urgent] " tip-bot for Arnd Bergmann
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2019-03-04 20:01 UTC (permalink / raw)
To: Thomas Gleixner
Cc: Paul E . McKenney, Frederic Weisbecker, Arnd Bergmann, linux-kernel
Moving the CONTEXT_TRACKING Kconfig option into kernel/time/Kconfig
added an implicit dependency on the surrounding GENERIC_CLOCKEVENTS
option, but this is not always enabled when we are able to select
VIRT_CPU_ACCOUNTING_GEN:
WARNING: unmet direct dependencies detected for CONTEXT_TRACKING
Depends on [n]: GENERIC_CLOCKEVENTS [=n]
Selected by [y]:
- VIRT_CPU_ACCOUNTING_GEN [=y] && <choice> && HAVE_CONTEXT_TRACKING [=y] && HAVE_VIRT_CPU_ACCOUNTING_GEN [=y]
Platforms without GENERIC_CLOCKEVENTS are rare enough that we can
probably just ignore that corner case and make it a dependency for
VIRT_CPU_ACCOUNTING_GEN to simplify the configuration.
Fixes: a4cffdad7314 ("time: Move CONTEXT_TRACKING to kernel/time/Kconfig")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
init/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/init/Kconfig b/init/Kconfig
index e0a6a35b8428..13442ca7d1ba 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -398,6 +398,7 @@ config VIRT_CPU_ACCOUNTING_GEN
bool "Full dynticks CPU time accounting"
depends on HAVE_CONTEXT_TRACKING
depends on HAVE_VIRT_CPU_ACCOUNTING_GEN
+ depends on GENERIC_CLOCKEVENTS
select VIRT_CPU_ACCOUNTING
select CONTEXT_TRACKING
help
--
2.20.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip:timers/urgent] time: Make VIRT_CPU_ACCOUNTING_GEN depend on GENERIC_CLOCKEVENTS
2019-03-04 20:01 [PATCH] time: Make VIRT_CPU_ACCOUNTING_GEN depend on GENERIC_CLOCKEVENTS Arnd Bergmann
@ 2019-03-06 19:45 ` tip-bot for Arnd Bergmann
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Arnd Bergmann @ 2019-03-06 19:45 UTC (permalink / raw)
To: linux-tip-commits; +Cc: mingo, fweisbec, hpa, arnd, paulmck, tglx, linux-kernel
Commit-ID: 041a15744a7fb4e9b2759611e44fb8847960564e
Gitweb: https://git.kernel.org/tip/041a15744a7fb4e9b2759611e44fb8847960564e
Author: Arnd Bergmann <arnd@arndb.de>
AuthorDate: Mon, 4 Mar 2019 21:01:31 +0100
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Wed, 6 Mar 2019 20:43:08 +0100
time: Make VIRT_CPU_ACCOUNTING_GEN depend on GENERIC_CLOCKEVENTS
Moving the CONTEXT_TRACKING Kconfig option into kernel/time/Kconfig added
an implicit dependency on the surrounding GENERIC_CLOCKEVENTS option, but
this is not always enabled when it is possible to select
VIRT_CPU_ACCOUNTING_GEN:
WARNING: unmet direct dependencies detected for CONTEXT_TRACKING
Depends on [n]: GENERIC_CLOCKEVENTS [=n]
Selected by [y]:
- VIRT_CPU_ACCOUNTING_GEN [=y] && <choice> && HAVE_CONTEXT_TRACKING [=y] && HAVE_VIRT_CPU_ACCOUNTING_GEN [=y]
Platforms without GENERIC_CLOCKEVENTS are rare enough so that corner case
can be just ignored. Make it a dependency for VIRT_CPU_ACCOUNTING_GEN to
simplify the configuration.
Fixes: a4cffdad7314 ("time: Move CONTEXT_TRACKING to kernel/time/Kconfig")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: "Paul E . McKenney" <paulmck@linux.ibm.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Link: https://lkml.kernel.org/r/20190304200202.1163250-1-arnd@arndb.de
---
init/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/init/Kconfig b/init/Kconfig
index c9386a365eea..acbde4ef2395 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -382,6 +382,7 @@ config VIRT_CPU_ACCOUNTING_GEN
bool "Full dynticks CPU time accounting"
depends on HAVE_CONTEXT_TRACKING
depends on HAVE_VIRT_CPU_ACCOUNTING_GEN
+ depends on GENERIC_CLOCKEVENTS
select VIRT_CPU_ACCOUNTING
select CONTEXT_TRACKING
help
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-06 19:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-04 20:01 [PATCH] time: Make VIRT_CPU_ACCOUNTING_GEN depend on GENERIC_CLOCKEVENTS Arnd Bergmann
2019-03-06 19:45 ` [tip:timers/urgent] " tip-bot for Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).