* [PATCH] mailbox: tegra-hsp: mark suspend function as __maybe_unused
@ 2019-03-04 20:26 Arnd Bergmann
2019-03-05 12:20 ` Thierry Reding
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2019-03-04 20:26 UTC (permalink / raw)
To: Jassi Brar, Thierry Reding, Jonathan Hunter
Cc: Arnd Bergmann, Bartosz Golaszewski, linux-kernel, linux-tegra
We get a warning about this being unused when CONFIG_PM is disabled:
drivers/mailbox/tegra-hsp.c:782:12: error: 'tegra_hsp_resume' defined but not used [-Werror=unused-function]
Fixes: 9a63f0f40599 ("mailbox: tegra-hsp: Add suspend/resume support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/mailbox/tegra-hsp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mailbox/tegra-hsp.c b/drivers/mailbox/tegra-hsp.c
index e443f6a2ec4b..11fc9fd6a94a 100644
--- a/drivers/mailbox/tegra-hsp.c
+++ b/drivers/mailbox/tegra-hsp.c
@@ -779,7 +779,7 @@ static int tegra_hsp_probe(struct platform_device *pdev)
return 0;
}
-static int tegra_hsp_resume(struct device *dev)
+static int __maybe_unused tegra_hsp_resume(struct device *dev)
{
struct tegra_hsp *hsp = dev_get_drvdata(dev);
unsigned int i;
--
2.20.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mailbox: tegra-hsp: mark suspend function as __maybe_unused
2019-03-04 20:26 [PATCH] mailbox: tegra-hsp: mark suspend function as __maybe_unused Arnd Bergmann
@ 2019-03-05 12:20 ` Thierry Reding
0 siblings, 0 replies; 2+ messages in thread
From: Thierry Reding @ 2019-03-05 12:20 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Jassi Brar, Jonathan Hunter, Bartosz Golaszewski, linux-kernel,
linux-tegra
[-- Attachment #1: Type: text/plain, Size: 523 bytes --]
On Mon, Mar 04, 2019 at 09:26:05PM +0100, Arnd Bergmann wrote:
> We get a warning about this being unused when CONFIG_PM is disabled:
>
> drivers/mailbox/tegra-hsp.c:782:12: error: 'tegra_hsp_resume' defined but not used [-Werror=unused-function]
>
> Fixes: 9a63f0f40599 ("mailbox: tegra-hsp: Add suspend/resume support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/mailbox/tegra-hsp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-05 12:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-04 20:26 [PATCH] mailbox: tegra-hsp: mark suspend function as __maybe_unused Arnd Bergmann
2019-03-05 12:20 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).