* [PATCH] writeback: fix inode cgroup switching comment
@ 2019-03-05 0:46 Greg Thelen
2019-03-05 15:42 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: Greg Thelen @ 2019-03-05 0:46 UTC (permalink / raw)
To: Andrew Morton, Tejun Heo
Cc: linux-mm, linux-fsdevel, linux-kernel, Greg Thelen
Commit 682aa8e1a6a1 ("writeback: implement unlocked_inode_to_wb
transaction and use it for stat updates") refers to
inode_switch_wb_work_fn() which never got merged. Switch the comments
to inode_switch_wbs_work_fn().
Fixes: 682aa8e1a6a1 ("writeback: implement unlocked_inode_to_wb transaction and use it for stat updates")
Signed-off-by: Greg Thelen <gthelen@google.com>
---
include/linux/backing-dev.h | 2 +-
include/linux/fs.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h
index c28a47cbe355..f9b029180241 100644
--- a/include/linux/backing-dev.h
+++ b/include/linux/backing-dev.h
@@ -365,7 +365,7 @@ unlocked_inode_to_wb_begin(struct inode *inode, struct wb_lock_cookie *cookie)
rcu_read_lock();
/*
- * Paired with store_release in inode_switch_wb_work_fn() and
+ * Paired with store_release in inode_switch_wbs_work_fn() and
* ensures that we see the new wb if we see cleared I_WB_SWITCH.
*/
cookie->locked = smp_load_acquire(&inode->i_state) & I_WB_SWITCH;
diff --git a/include/linux/fs.h b/include/linux/fs.h
index fd423fec8d83..08f26046233e 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -2091,7 +2091,7 @@ static inline void init_sync_kiocb(struct kiocb *kiocb, struct file *filp)
* I_WB_SWITCH Cgroup bdi_writeback switching in progress. Used to
* synchronize competing switching instances and to tell
* wb stat updates to grab the i_pages lock. See
- * inode_switch_wb_work_fn() for details.
+ * inode_switch_wbs_work_fn() for details.
*
* I_OVL_INUSE Used by overlayfs to get exclusive ownership on upper
* and work dirs among overlayfs mounts.
--
2.21.0.352.gf09ad66450-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] writeback: fix inode cgroup switching comment
2019-03-05 0:46 [PATCH] writeback: fix inode cgroup switching comment Greg Thelen
@ 2019-03-05 15:42 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2019-03-05 15:42 UTC (permalink / raw)
To: Greg Thelen; +Cc: Andrew Morton, linux-mm, linux-fsdevel, linux-kernel
On Mon, Mar 04, 2019 at 04:46:17PM -0800, Greg Thelen wrote:
> Commit 682aa8e1a6a1 ("writeback: implement unlocked_inode_to_wb
> transaction and use it for stat updates") refers to
> inode_switch_wb_work_fn() which never got merged. Switch the comments
> to inode_switch_wbs_work_fn().
>
> Fixes: 682aa8e1a6a1 ("writeback: implement unlocked_inode_to_wb transaction and use it for stat updates")
> Signed-off-by: Greg Thelen <gthelen@google.com>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-05 15:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-05 0:46 [PATCH] writeback: fix inode cgroup switching comment Greg Thelen
2019-03-05 15:42 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).