[PATCH] vxlan: do not need BH again in vxlan_cleanup()

[PATCH] vxlan: do not need BH again in vxlan_cleanup()

[Litao Jiao]

vxlan_cleanup() is a timer callback, it is already
and only running in BH context.

Signed-off-by: Litao Jiao <jiaolitao@raisecom.com>
---
 drivers/net/vxlan.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index 2aae11f..98dde11 100644
--- a/drivers/net/vxlan.c
+++ b/drivers/net/vxlan.c
@@ -2616,7 +2616,7 @@ static void vxlan_cleanup(struct timer_list *t)
 	for (h = 0; h < FDB_HASH_SIZE; ++h) {
 		struct hlist_node *p, *n;
 
-		spin_lock_bh(&vxlan->hash_lock);
+		spin_lock(&vxlan->hash_lock);
 		hlist_for_each_safe(p, n, &vxlan->fdb_head[h]) {
 			struct vxlan_fdb *f
 				= container_of(p, struct vxlan_fdb, hlist);
@@ -2638,7 +2638,7 @@ static void vxlan_cleanup(struct timer_list *t)
 			} else if (time_before(timeout, next_timer))
 				next_timer = timeout;
 		}
-		spin_unlock_bh(&vxlan->hash_lock);
+		spin_unlock(&vxlan->hash_lock);
 	}
 
 	mod_timer(&vxlan->age_timer, next_timer);
-- 
1.9.1

Re: [PATCH] vxlan: do not need BH again in vxlan_cleanup()

[David Miller]

From: Litao Jiao <jiaolitao@raisecom.com>
Date: Wed,  6 Mar 2019 12:01:48 +0800

> vxlan_cleanup() is a timer callback, it is already
> and only running in BH context.
> 
> Signed-off-by: Litao Jiao <jiaolitao@raisecom.com>

Agree with your analysis, applied, thanks.