From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Petr Mladek <pmladek@suse.com>
Cc: Calvin Owens <calvinowens@fb.com>,
John Ogness <john.ogness@linutronix.de>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH 3/4] printk: Add consoles to a virtual "console" bus
Date: Fri, 8 Mar 2019 17:34:11 +0100 [thread overview]
Message-ID: <20190308163411.GA12898@kroah.com> (raw)
In-Reply-To: <20190308155814.rzsjrzgwfcm4p5sk@pathway.suse.cz>
On Fri, Mar 08, 2019 at 04:58:14PM +0100, Petr Mladek wrote:
> On Fri 2019-03-08 03:56:19, John Ogness wrote:
> > On 2019-03-02, Calvin Owens <calvinowens@fb.com> wrote:
> > > This patch embeds a device struct in the console struct, and registers
> > > them on a "console" bus so we can expose attributes in sysfs.
> >
> > I expect that "class" would be more appropriate than "bus". These
> > devices really are grouped together based on their function and not the
> > medium by which they are accessed.
>
> Good point. "class" looks better to me as well.
>
> Greg, any opinion, where to put the entries for struct console ?
Hang them off of the device that the console belongs to?
Classes and busses are almost identical except:
- busses is the binding of a driver to a device (usb, pci, etc.)
- classes are usually userspace interactions to a device (input,
tty, etc.)
So this sounds like a class to me.
If you want me to review this, I'll be glad to so do once 5.1-rc1 is
out...
thanks,
greg k-h
next prev parent reply other threads:[~2019-03-08 17:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-02 0:48 [RFC][PATCH 0/4] Per-console loglevel support, console device bus Calvin Owens
2019-03-02 0:48 ` [PATCH 1/4] printk: Introduce per-console loglevel setting Calvin Owens
2019-03-08 3:10 ` Sergey Senozhatsky
2019-03-12 21:00 ` Calvin Owens
2019-03-08 15:09 ` Petr Mladek
2019-03-14 14:12 ` Tetsuo Handa
2019-03-20 15:37 ` Petr Mladek
2019-03-02 0:48 ` [PATCH 2/4] printk: Add ability to set loglevel via "console=" cmdline Calvin Owens
2019-03-08 15:44 ` Petr Mladek
2019-03-02 0:48 ` [PATCH 3/4] printk: Add consoles to a virtual "console" bus Calvin Owens
2019-03-08 2:56 ` John Ogness
2019-03-08 15:58 ` Petr Mladek
2019-03-08 16:34 ` Greg Kroah-Hartman [this message]
2019-03-12 20:44 ` Calvin Owens
2019-03-08 15:53 ` Petr Mladek
2019-03-12 20:52 ` Calvin Owens
2019-03-11 13:33 ` Petr Mladek
2019-03-12 21:52 ` Calvin Owens
2019-03-13 10:08 ` Petr Mladek
2019-03-02 0:48 ` [PATCH 4/4] printk: Add a device attribute for the per-console loglevel Calvin Owens
2019-03-04 8:06 ` Sergey Senozhatsky
2019-03-04 19:10 ` Calvin Owens
2019-03-08 3:11 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190308163411.GA12898@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=calvinowens@fb.com \
--cc=corbet@lwn.net \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).