From: Calvin Owens <calvinowens@fb.com>
To: Petr Mladek <pmladek@suse.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Corbet <corbet@lwn.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>
Subject: Re: [PATCH 3/4] printk: Add consoles to a virtual "console" bus
Date: Tue, 12 Mar 2019 20:52:57 +0000 [thread overview]
Message-ID: <20190312205254.GB5982@Haydn> (raw)
In-Reply-To: <20190308155352.g43mt44adau6cgh6@pathway.suse.cz>
On Friday 03/08 at 16:53 +0100, Petr Mladek wrote:
> On Fri 2019-03-01 16:48:19, Calvin Owens wrote:
> > This patch embeds a device struct in the console struct, and registers
> > them on a "console" bus so we can expose attributes in sysfs.
> >
> > Early console structures must still be static, since they're required
> > before we're able to allocate memory. The least ugly way I can come up
> > with to handle this is an "is_static" flag in the structure which makes
> > the gets and puts NOPs, and is checked in ->release() to catch mistakes.
>
> I wonder if it might get detected by is_kernel_inittext().
I don't think inittext() in particular would work, since these actually need
to exist forever if you pass "earlyprintk=[...],keep" so they aren't __init.
But I bet you're right that we could catch the static case without needing
the explicit flag, something like is_module_address() (but it would also need
to work for the built-in case). I'll see if I can get this to work.
Thanks,
Calvin
> Best Regards,
> Petr
next prev parent reply other threads:[~2019-03-12 20:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-02 0:48 [RFC][PATCH 0/4] Per-console loglevel support, console device bus Calvin Owens
2019-03-02 0:48 ` [PATCH 1/4] printk: Introduce per-console loglevel setting Calvin Owens
2019-03-08 3:10 ` Sergey Senozhatsky
2019-03-12 21:00 ` Calvin Owens
2019-03-08 15:09 ` Petr Mladek
2019-03-14 14:12 ` Tetsuo Handa
2019-03-20 15:37 ` Petr Mladek
2019-03-02 0:48 ` [PATCH 2/4] printk: Add ability to set loglevel via "console=" cmdline Calvin Owens
2019-03-08 15:44 ` Petr Mladek
2019-03-02 0:48 ` [PATCH 3/4] printk: Add consoles to a virtual "console" bus Calvin Owens
2019-03-08 2:56 ` John Ogness
2019-03-08 15:58 ` Petr Mladek
2019-03-08 16:34 ` Greg Kroah-Hartman
2019-03-12 20:44 ` Calvin Owens
2019-03-08 15:53 ` Petr Mladek
2019-03-12 20:52 ` Calvin Owens [this message]
2019-03-11 13:33 ` Petr Mladek
2019-03-12 21:52 ` Calvin Owens
2019-03-13 10:08 ` Petr Mladek
2019-03-02 0:48 ` [PATCH 4/4] printk: Add a device attribute for the per-console loglevel Calvin Owens
2019-03-04 8:06 ` Sergey Senozhatsky
2019-03-04 19:10 ` Calvin Owens
2019-03-08 3:11 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190312205254.GB5982@Haydn \
--to=calvinowens@fb.com \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).