* [PATCH v2] net: liquidio: fix a NULL pointer dereference
@ 2019-03-11 5:02 Kangjie Lu
2019-03-11 18:44 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Kangjie Lu @ 2019-03-11 5:02 UTC (permalink / raw)
To: kjlu
Cc: pakki001, Derek Chickles, Satanand Burla, Felix Manlunas,
David S. Miller, netdev, linux-kernel
In case octeon_alloc_soft_command fails, the fix reports the
error and returns to avoid NULL pointer dereference.
Signed-off-by: Kangjie Lu <kjlu@umn.edu>
---
drivers/net/ethernet/cavium/liquidio/lio_main.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/ethernet/cavium/liquidio/lio_main.c b/drivers/net/ethernet/cavium/liquidio/lio_main.c
index 9b7819fdc9de..fb6f813cff65 100644
--- a/drivers/net/ethernet/cavium/liquidio/lio_main.c
+++ b/drivers/net/ethernet/cavium/liquidio/lio_main.c
@@ -1192,6 +1192,11 @@ static void send_rx_ctrl_cmd(struct lio *lio, int start_stop)
sc = (struct octeon_soft_command *)
octeon_alloc_soft_command(oct, OCTNET_CMD_SIZE,
16, 0);
+ if (!sc) {
+ netif_info(lio, rx_err, lio->netdev,
+ "Failed to allocate octeon_soft_command\n");
+ return;
+ }
ncmd = (union octnet_cmd *)sc->virtdptr;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] net: liquidio: fix a NULL pointer dereference
2019-03-11 5:02 [PATCH v2] net: liquidio: fix a NULL pointer dereference Kangjie Lu
@ 2019-03-11 18:44 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-03-11 18:44 UTC (permalink / raw)
To: kjlu; +Cc: pakki001, dchickles, sburla, fmanlunas, netdev, linux-kernel
From: Kangjie Lu <kjlu@umn.edu>
Date: Mon, 11 Mar 2019 00:02:32 -0500
> In case octeon_alloc_soft_command fails, the fix reports the
> error and returns to avoid NULL pointer dereference.
>
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-11 18:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-11 5:02 [PATCH v2] net: liquidio: fix a NULL pointer dereference Kangjie Lu
2019-03-11 18:44 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).