From: Jiri Olsa <jolsa@redhat.com>
To: Song Liu <songliubraving@fb.com>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, ast@kernel.org,
daniel@iogearbox.net, kernel-team@fb.com, peterz@infradead.org,
acme@redhat.com, jolsa@kernel.org, namhyung@kernel.org
Subject: Re: [PATCH v7 perf,bpf 12/15] perf, bpf: enable annotation of bpf program
Date: Mon, 11 Mar 2019 18:56:41 +0100 [thread overview]
Message-ID: <20190311175641.GA19721@krava> (raw)
In-Reply-To: <20190307175810.249857-13-songliubraving@fb.com>
On Thu, Mar 07, 2019 at 09:58:07AM -0800, Song Liu wrote:
SNIP
> + if (linfo && btf) {
> + srcline = btf__name_by_offset(btf, linfo->line_off);
> + nr_skip++;
> + } else
> + srcline = NULL;
> +
> + fprintf(s, "\n");
> + prev_buf_size = buf_size;
> + fflush(s);
> +
> + if (!opts->hide_src_code && srcline) {
> + args->offset = -1;
> + args->line = strdup(srcline);
> + args->line_nr = 0;
> + args->ms.sym = sym;
> + dl = disasm_line__new(args);
> + if (dl) {
> + annotation_line__add(&dl->al,
> + ¬es->src->source);
> + }
> + }
I still miss answer for why is the line added twice for
!opts->hide_src_code && srcline ? code up and down
jirka
> +
> + args->offset = pc;
> + args->line = buf + prev_buf_size;
> + args->line_nr = 0;
> + args->ms.sym = sym;
> + dl = disasm_line__new(args);
> + if (dl)
> + annotation_line__add(&dl->al, ¬es->src->source);
> +
> + pc += count;
> + } while (count > 0 && pc < len);
SNIP
next prev parent reply other threads:[~2019-03-11 17:56 UTC|newest]
Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 17:57 [PATCH v7 perf,bpf 00/15] perf annotation of BPF programs Song Liu
2019-03-07 17:57 ` [PATCH v7 perf,bpf 01/15] perf, bpf: consider events with attr.bpf_event as side-band events Song Liu
2019-03-07 17:57 ` [PATCH v7 perf,bpf 02/15] bpf: libbpf: introduce bpf_program__get_prog_info_linear() Song Liu
2019-03-11 18:26 ` Arnaldo Carvalho de Melo
2019-03-11 20:45 ` Daniel Borkmann
2019-03-11 20:57 ` Arnaldo Carvalho de Melo
2019-03-12 11:20 ` Daniel Borkmann
2019-03-07 17:57 ` [PATCH v7 perf,bpf 03/15] bpf: bpftool: use bpf_program__get_prog_info_linear() in prog.c:do_dump() Song Liu
2019-03-07 17:57 ` [PATCH v7 perf,bpf 04/15] perf, bpf: synthesize bpf events with bpf_program__get_prog_info_linear() Song Liu
2019-03-07 17:58 ` [PATCH v7 perf,bpf 05/15] perf: change prototype of perf_event__synthesize_bpf_events() Song Liu
2019-03-07 17:58 ` [PATCH v7 perf,bpf 06/15] perf, bpf: save bpf_prog_info in a rbtree in perf_env Song Liu
2019-03-07 17:58 ` [PATCH v7 perf,bpf 07/15] perf, bpf: save bpf_prog_info information as headers to perf.data Song Liu
2019-03-11 17:56 ` Jiri Olsa
2019-03-11 18:05 ` Song Liu
2019-03-07 17:58 ` [PATCH v7 perf,bpf 08/15] perf, bpf: save btf in a rbtree in perf_env Song Liu
2019-03-07 17:58 ` [PATCH v7 perf,bpf 09/15] perf, bpf: save btf information as headers to perf.data Song Liu
2019-03-11 17:56 ` Jiri Olsa
2019-03-07 17:58 ` [PATCH v7 perf,bpf 10/15] perf-top: add option --no-bpf-event Song Liu
2019-03-07 17:58 ` [PATCH v7 perf,bpf 11/15] perf: add -lopcodes to feature-libbfd Song Liu
2019-03-07 23:26 ` Stanislav Fomichev
2019-03-07 23:47 ` Song Liu
2019-03-07 17:58 ` [PATCH v7 perf,bpf 12/15] perf, bpf: enable annotation of bpf program Song Liu
2019-03-11 17:56 ` Jiri Olsa [this message]
2019-03-11 18:04 ` Song Liu
2019-03-07 17:58 ` [PATCH v7 perf,bpf 13/15] perf, bpf: process PERF_BPF_EVENT_PROG_LOAD for annotation Song Liu
2019-03-07 17:58 ` [PATCH v7 perf,bpf 14/15] perf: introduce side band thread Song Liu
2019-03-11 17:57 ` Jiri Olsa
2019-03-07 17:58 ` [PATCH v7 perf,bpf 15/15] perf, bpf: save bpf_prog_info and btf of short living bpf programs Song Liu
2019-03-11 13:59 ` [PATCH v7 perf,bpf 00/15] perf annotation of BPF programs Jiri Olsa
2019-03-11 14:16 ` Song Liu
2019-03-12 5:30 [PATCH v9 " Song Liu
2019-03-12 5:30 ` [PATCH v9 perf,bpf 01/15] perf-record: replace option --bpf-event with --no-bpf-event Song Liu
2019-03-22 22:35 ` [tip:perf/urgent] perf record: Replace " tip-bot for Song Liu
2019-03-12 5:30 ` [PATCH v9 perf,bpf 02/15] bpf: libbpf: introduce bpf_program__get_prog_info_linear() Song Liu
2019-03-12 13:50 ` Arnaldo Carvalho de Melo
2019-03-22 22:36 ` [tip:perf/urgent] tools lib bpf: Introduce bpf_program__get_prog_info_linear() tip-bot for Song Liu
2019-03-12 5:30 ` [PATCH v9 perf,bpf 03/15] bpf: bpftool: use bpf_program__get_prog_info_linear() in prog.c:do_dump() Song Liu
2019-03-22 22:36 ` [tip:perf/urgent] " tip-bot for Song Liu
2019-03-12 5:30 ` [PATCH v9 perf,bpf 04/15] perf, bpf: synthesize bpf events with bpf_program__get_prog_info_linear() Song Liu
2019-03-13 21:00 ` Arnaldo Carvalho de Melo
2019-03-13 21:08 ` Arnaldo Carvalho de Melo
2019-03-14 5:08 ` Song Liu
2019-03-14 16:45 ` Song Liu
2019-03-14 18:30 ` Arnaldo Carvalho de Melo
2019-03-22 22:37 ` [tip:perf/urgent] perf bpf: Synthesize " tip-bot for Song Liu
2019-03-12 5:30 ` [PATCH v9 perf,bpf 05/15] perf: change prototype of perf_event__synthesize_bpf_events() Song Liu
2019-03-22 22:37 ` [tip:perf/urgent] perf bpf: Make synthesize_bpf_events() receive perf_session pointer instead of perf_tool tip-bot for Song Liu
2019-03-12 5:30 ` [PATCH v9 perf,bpf 06/15] perf, bpf: save bpf_prog_info in a rbtree in perf_env Song Liu
2019-03-12 13:10 ` Jiri Olsa
2019-03-12 14:34 ` Arnaldo Carvalho de Melo
2019-03-22 22:38 ` [tip:perf/urgent] perf bpf: Save " tip-bot for Song Liu
2019-03-12 5:30 ` [PATCH v9 perf,bpf 07/15] perf, bpf: save bpf_prog_info information as headers to perf.data Song Liu
2019-03-12 13:10 ` Jiri Olsa
2019-03-12 14:47 ` Arnaldo Carvalho de Melo
2019-03-13 19:05 ` Arnaldo Carvalho de Melo
2019-03-22 22:39 ` [tip:perf/urgent] perf bpf: Save " tip-bot for Song Liu
2019-03-12 5:30 ` [PATCH v9 perf,bpf 08/15] perf, bpf: save btf in a rbtree in perf_env Song Liu
2019-03-12 15:00 ` Arnaldo Carvalho de Melo
2019-03-22 22:39 ` [tip:perf/urgent] perf bpf: Save BTF " tip-bot for Song Liu
2019-03-12 5:30 ` [PATCH v9 perf,bpf 09/15] perf, bpf: save btf information as headers to perf.data Song Liu
2019-03-12 15:14 ` Arnaldo Carvalho de Melo
2019-03-12 15:16 ` Arnaldo Carvalho de Melo
2019-03-12 16:26 ` Song Liu
2019-03-12 17:05 ` Arnaldo Carvalho de Melo
2019-03-12 17:29 ` Song Liu
2019-03-15 19:06 ` Arnaldo Carvalho de Melo
2019-03-15 19:26 ` Arnaldo Carvalho de Melo
2019-03-15 19:31 ` Song Liu
2019-03-15 19:42 ` Arnaldo Carvalho de Melo
2019-03-22 22:40 ` [tip:perf/urgent] perf bpf: Save BTF " tip-bot for Song Liu
2019-03-12 5:30 ` [PATCH v9 perf,bpf 10/15] perf-top: add option --no-bpf-event Song Liu
2019-03-22 22:41 ` [tip:perf/urgent] perf top: Add " tip-bot for Song Liu
2019-03-12 5:30 ` [PATCH v9 perf,bpf 11/15] perf: add -lopcodes to feature-libbfd Song Liu
2019-03-22 22:41 ` [tip:perf/urgent] perf feature detection: Add " tip-bot for Song Liu
2019-03-12 5:30 ` [PATCH v9 perf,bpf 12/15] perf, bpf: enable annotation of bpf program Song Liu
2019-03-18 16:38 ` Arnaldo Carvalho de Melo
2019-03-18 16:43 ` Arnaldo Carvalho de Melo
2019-03-19 6:10 ` Song Liu
2019-03-19 13:37 ` Arnaldo Carvalho de Melo
2019-03-19 6:05 ` Song Liu
2019-03-19 13:37 ` Arnaldo Carvalho de Melo
2019-03-19 13:58 ` Arnaldo Carvalho de Melo
2019-03-19 14:14 ` Arnaldo Carvalho de Melo
2019-03-19 14:52 ` [WORKS!] " Arnaldo Carvalho de Melo
2019-03-19 16:51 ` Song Liu
2019-03-19 16:55 ` Arnaldo Carvalho de Melo
2019-03-19 17:07 ` Arnaldo Carvalho de Melo
2019-03-22 22:42 ` [tip:perf/urgent] perf symbols: Introduce DSO_BINARY_TYPE__BPF_PROG_INFO tip-bot for Song Liu
2019-03-22 22:43 ` [tip:perf/urgent] perf build: Check what binutils's 'disassembler()' signature to use tip-bot for Song Liu
2019-03-22 22:44 ` [tip:perf/urgent] perf annotate: Enable annotation of BPF programs tip-bot for Song Liu
2019-03-12 5:30 ` [PATCH v9 perf,bpf 13/15] perf, bpf: process PERF_BPF_EVENT_PROG_LOAD for annotation Song Liu
2019-03-22 22:43 ` [tip:perf/urgent] perf bpf: Process " tip-bot for Song Liu
2019-03-12 5:30 ` [PATCH v9 perf,bpf 14/15] perf: introduce side band thread Song Liu
2019-03-22 22:45 ` [tip:perf/urgent] perf evlist: Introduce " tip-bot for Song Liu
2019-03-12 5:30 ` [PATCH v9 perf,bpf 15/15] perf, bpf: save bpf_prog_info and btf of short living bpf programs Song Liu
2019-03-19 15:25 ` Arnaldo Carvalho de Melo
2019-03-22 22:45 ` [tip:perf/urgent] perf tools: Save bpf_prog_info and BTF of new BPF programs tip-bot for Song Liu
2019-03-12 13:12 ` [PATCH v9 perf,bpf 00/15] perf annotation of " Jiri Olsa
2019-03-21 9:10 ` Jiri Olsa
2019-03-21 14:12 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190311175641.GA19721@krava \
--to=jolsa@redhat.com \
--cc=acme@redhat.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jolsa@kernel.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).