From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Song Liu <songliubraving@fb.com>
Cc: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
bpf@vger.kernel.org, Networking <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Kernel Team <Kernel-team@fb.com>,
Peter Zijlstra <peterz@infradead.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
sdf@fomichev.me
Subject: Re: [PATCH v9 perf,bpf 09/15] perf, bpf: save btf information as headers to perf.data
Date: Fri, 15 Mar 2019 16:06:51 -0300 [thread overview]
Message-ID: <20190315190651.GA14938@kernel.org> (raw)
In-Reply-To: <97D0A2F1-1F82-4CF0-ACE3-A276784DF7EA@fb.com>
Em Tue, Mar 12, 2019 at 05:29:03PM +0000, Song Liu escreveu:
> > On Mar 12, 2019, at 10:05 AM, Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com> wrote:
> > Em Tue, Mar 12, 2019 at 04:26:17PM +0000, Song Liu escreveu:
> >>> On Mar 12, 2019, at 8:16 AM, Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com> wrote:
> >>> Em Tue, Mar 12, 2019 at 12:14:05PM -0300, Arnaldo Carvalho de Melo escreveu:
> >>>> Em Mon, Mar 11, 2019 at 10:30:45PM -0700, Song Liu escreveu:
> >>>>> +static void print_bpf_btf(struct feat_fd *ff, FILE *fp)
> >>>>> +{
> >>>>> + struct perf_env *env = &ff->ph->env;
> >>>>> + struct rb_root *root;
> >>>>> + struct rb_node *next;
> >>>>> +
> >>>>> + down_read(&env->bpf_progs.lock);
> >>>>> +
> >>>>> + root = &env->bpf_progs.btfs;
> >>>>> + next = rb_first(root);
> >>>>> +
> >>>>> + while (next) {
> >>>>> + struct btf_node *node;
> >>>>> +
> >>>>> + node = rb_entry(next, struct btf_node, rb_node);
> >>>>> + next = rb_next(&node->rb_node);
> >>>>> + fprintf(fp, "# btf info of id %u\n", node->id);
> >>>>
> >>>> So, I couldn't get this to work right now, and I have BPF programs that
> >>>> are loaded and that have BTF info:
> >>>>
> >>>> [root@quaco ~]# bpftool prog | tail -6
> >>>> 208: tracepoint name sys_enter tag 819967866022f1e1 gpl
> >>>> loaded_at 2019-03-12T11:16:55-0300 uid 0
> >>>> xlated 528B jited 381B memlock 4096B map_ids 107,106,105
> >>>> 209: tracepoint name sys_exit tag c1bd85c092d6e4aa gpl
> >>>> loaded_at 2019-03-12T11:16:55-0300 uid 0
> >>>> xlated 256B jited 191B memlock 4096B map_ids 107,106
> >>>> [root@quaco ~]#
> >>>>
> >>>>
> >>>> [root@quaco ~]# bpftool map | tail -6
> >>>> 105: perf_event_array name __augmented_sys flags 0x0
> >>>> key 4B value 4B max_entries 8 memlock 4096B
> >>>> 106: array name syscalls flags 0x0
> >>>> key 4B value 1B max_entries 512 memlock 8192B
> >>>> 107: hash name pids_filtered flags 0x0
> >>>> key 4B value 1B max_entries 64 memlock 8192B
> >>>> [root@quaco ~]#
> >>>>
> >>>> [root@quaco ~]# bpftool map dump id 107
> >>>> [{
> >>>> "key": 8104,
> >>>> "value": true
> >>>> },{
> >>>> "key": 18868,
> >>>> "value": true
> >>>> }
> >>>> ]
> >>>> [root@quaco ~]# ps ax|egrep 8104\|18868 | grep -v grep
> >>>> 8104 pts/8 S+ 0:07 trace -e recvmmsg
> >>>> 18868 ? Ssl 21:21 /usr/libexec/gnome-terminal-server
> >>>> [root@quaco ~]#
> >>>>
> >>>> So I was expecting to see those btf lines there :-\
> >>>>
> >>>> All the patches up to this point I have already merged and tested in my
> >>>> local branch.
> >>>>
> >>>> Will continue right after lunch to try to figure out why this BTF info
> >>>> isn't landing on this new header feature...
> >>>
> >>> I've pushed what I have to my git.kernel.org repo, branch
> >>> tmp.perf/bpf-annotate.
> >>>
> >>> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tmp.perf/bpf-annotate
> >>>
> >>> The HEAD is this cset.
> >
> >> I am not sure I fully understand the problem here.
> >
> > Trying to say it another way, when I start 'perf record', with the
> > patches in your series up to this one ('[PATCH v9 perf,bpf 09/15] perf,
> > bpf: save btf information as headers to perf.data'), and while there is
> > a BPF program running, that has BTF attached to it as can be seen by
> > using 'bpf map dump', 'perf report --header-only' isn't showing any line
> > with 'btf' on it.
> >
> > So, using -v I notice that it is failing to get enable attr.bpf_event
> > and attr.ksymbol, which makes me go get another coffee to check that the
> > kernel was built from my 5.1 tree that has those events and not 5.0 that
> > doesn't ;-\ Sorry for the noise, will get back here after I check all
> > this :-)
> >
> > But to recap, the BPF events I was getting were the synthesized ones...
>
> Yeah, to capture the short living BPF/BTF, we need patch 15/15 of the set.
So, I continue trying to test this with the patches applied up to the
patch in the subject of this message, i.e. up to:
09/15 perf, bpf: save btf information as headers to perf.data
While running on a kernel based on tip/perf/core, so it should have what
is needed:
[root@quaco ~]# egrep 't perf_event_(bpf|ksymbol)_output' /proc/kallsyms
ffffffff94211a40 t perf_event_bpf_output
ffffffff94216550 t perf_event_ksymbol_output
[root@quaco ~]#
But when I debug breakpointing perf_event__synthesize_one_bpf_prog(),
bpf_prog_info->btf_info is always zero, i.e. here:
/* check BTF func info support */
if (info->btf_id && info->nr_func_info && info->func_info_rec_size) {
/* btf func info number should be same as sub_prog_cnt */
if (sub_prog_cnt != info->nr_func_info) {
pr_debug("%s: mismatch in BPF sub program count and BTF function info count, aborting\n", __func__);
err = -1;
goto out;
}
if (btf__get_from_id(info->btf_id, &btf)) {
pr_debug("%s: failed to get BTF of id %u, aborting\n", __func__, info->btf_id);
err = -1;
btf = NULL;
goto out;
}
has_btf = true;
perf_env__fetch_btf(env, info->btf_id, btf);
}
So we never get into this if body and this do not call
perf__env_fetch_btf() and thus don't write BTF info to the perf.data
header.
And yes, there are BPF programs with BTF information associated:
[root@quaco perf]# bpftool map dump pids_filtered
[{
"key": 2592,
"value": true
},{
"key": 20511,
"value": true
}
]
[root@quaco perf]#
I.e. bpftool can find the BTF info and thus is able to show the
'pids_filtered' map keys and values pretty printed, not just as hex raw
data.
I'm trying to find out why 'bpftool map dump' finds the BTF info while
perf_event__synthesize_one_bpf_prog() doesn't.
- Arnaldo
next prev parent reply other threads:[~2019-03-15 19:07 UTC|newest]
Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 5:30 [PATCH v9 perf,bpf 00/15] perf annotation of BPF programs Song Liu
2019-03-12 5:30 ` [PATCH v9 perf,bpf 01/15] perf-record: replace option --bpf-event with --no-bpf-event Song Liu
2019-03-22 22:35 ` [tip:perf/urgent] perf record: Replace " tip-bot for Song Liu
2019-03-12 5:30 ` [PATCH v9 perf,bpf 02/15] bpf: libbpf: introduce bpf_program__get_prog_info_linear() Song Liu
2019-03-12 13:50 ` Arnaldo Carvalho de Melo
2019-03-22 22:36 ` [tip:perf/urgent] tools lib bpf: Introduce bpf_program__get_prog_info_linear() tip-bot for Song Liu
2019-03-12 5:30 ` [PATCH v9 perf,bpf 03/15] bpf: bpftool: use bpf_program__get_prog_info_linear() in prog.c:do_dump() Song Liu
2019-03-22 22:36 ` [tip:perf/urgent] " tip-bot for Song Liu
2019-03-12 5:30 ` [PATCH v9 perf,bpf 04/15] perf, bpf: synthesize bpf events with bpf_program__get_prog_info_linear() Song Liu
2019-03-13 21:00 ` Arnaldo Carvalho de Melo
2019-03-13 21:08 ` Arnaldo Carvalho de Melo
2019-03-14 5:08 ` Song Liu
2019-03-14 16:45 ` Song Liu
2019-03-14 18:30 ` Arnaldo Carvalho de Melo
2019-03-22 22:37 ` [tip:perf/urgent] perf bpf: Synthesize " tip-bot for Song Liu
2019-03-12 5:30 ` [PATCH v9 perf,bpf 05/15] perf: change prototype of perf_event__synthesize_bpf_events() Song Liu
2019-03-22 22:37 ` [tip:perf/urgent] perf bpf: Make synthesize_bpf_events() receive perf_session pointer instead of perf_tool tip-bot for Song Liu
2019-03-12 5:30 ` [PATCH v9 perf,bpf 06/15] perf, bpf: save bpf_prog_info in a rbtree in perf_env Song Liu
2019-03-12 13:10 ` Jiri Olsa
2019-03-12 14:34 ` Arnaldo Carvalho de Melo
2019-03-22 22:38 ` [tip:perf/urgent] perf bpf: Save " tip-bot for Song Liu
2019-03-12 5:30 ` [PATCH v9 perf,bpf 07/15] perf, bpf: save bpf_prog_info information as headers to perf.data Song Liu
2019-03-12 13:10 ` Jiri Olsa
2019-03-12 14:47 ` Arnaldo Carvalho de Melo
2019-03-13 19:05 ` Arnaldo Carvalho de Melo
2019-03-22 22:39 ` [tip:perf/urgent] perf bpf: Save " tip-bot for Song Liu
2019-03-12 5:30 ` [PATCH v9 perf,bpf 08/15] perf, bpf: save btf in a rbtree in perf_env Song Liu
2019-03-12 15:00 ` Arnaldo Carvalho de Melo
2019-03-22 22:39 ` [tip:perf/urgent] perf bpf: Save BTF " tip-bot for Song Liu
2019-03-12 5:30 ` [PATCH v9 perf,bpf 09/15] perf, bpf: save btf information as headers to perf.data Song Liu
2019-03-12 15:14 ` Arnaldo Carvalho de Melo
2019-03-12 15:16 ` Arnaldo Carvalho de Melo
2019-03-12 16:26 ` Song Liu
2019-03-12 17:05 ` Arnaldo Carvalho de Melo
2019-03-12 17:29 ` Song Liu
2019-03-15 19:06 ` Arnaldo Carvalho de Melo [this message]
2019-03-15 19:26 ` Arnaldo Carvalho de Melo
2019-03-15 19:31 ` Song Liu
2019-03-15 19:42 ` Arnaldo Carvalho de Melo
2019-03-22 22:40 ` [tip:perf/urgent] perf bpf: Save BTF " tip-bot for Song Liu
2019-03-12 5:30 ` [PATCH v9 perf,bpf 10/15] perf-top: add option --no-bpf-event Song Liu
2019-03-22 22:41 ` [tip:perf/urgent] perf top: Add " tip-bot for Song Liu
2019-03-12 5:30 ` [PATCH v9 perf,bpf 11/15] perf: add -lopcodes to feature-libbfd Song Liu
2019-03-22 22:41 ` [tip:perf/urgent] perf feature detection: Add " tip-bot for Song Liu
2019-03-12 5:30 ` [PATCH v9 perf,bpf 12/15] perf, bpf: enable annotation of bpf program Song Liu
2019-03-18 16:38 ` Arnaldo Carvalho de Melo
2019-03-18 16:43 ` Arnaldo Carvalho de Melo
2019-03-19 6:10 ` Song Liu
2019-03-19 13:37 ` Arnaldo Carvalho de Melo
2019-03-19 6:05 ` Song Liu
2019-03-19 13:37 ` Arnaldo Carvalho de Melo
2019-03-19 13:58 ` Arnaldo Carvalho de Melo
2019-03-19 14:14 ` Arnaldo Carvalho de Melo
2019-03-19 14:52 ` [WORKS!] " Arnaldo Carvalho de Melo
2019-03-19 16:51 ` Song Liu
2019-03-19 16:55 ` Arnaldo Carvalho de Melo
2019-03-19 17:07 ` Arnaldo Carvalho de Melo
2019-03-22 22:42 ` [tip:perf/urgent] perf symbols: Introduce DSO_BINARY_TYPE__BPF_PROG_INFO tip-bot for Song Liu
2019-03-22 22:43 ` [tip:perf/urgent] perf build: Check what binutils's 'disassembler()' signature to use tip-bot for Song Liu
2019-03-22 22:44 ` [tip:perf/urgent] perf annotate: Enable annotation of BPF programs tip-bot for Song Liu
2019-03-12 5:30 ` [PATCH v9 perf,bpf 13/15] perf, bpf: process PERF_BPF_EVENT_PROG_LOAD for annotation Song Liu
2019-03-22 22:43 ` [tip:perf/urgent] perf bpf: Process " tip-bot for Song Liu
2019-03-12 5:30 ` [PATCH v9 perf,bpf 14/15] perf: introduce side band thread Song Liu
2019-03-22 22:45 ` [tip:perf/urgent] perf evlist: Introduce " tip-bot for Song Liu
2019-03-12 5:30 ` [PATCH v9 perf,bpf 15/15] perf, bpf: save bpf_prog_info and btf of short living bpf programs Song Liu
2019-03-19 15:25 ` Arnaldo Carvalho de Melo
2019-03-22 22:45 ` [tip:perf/urgent] perf tools: Save bpf_prog_info and BTF of new BPF programs tip-bot for Song Liu
2019-03-12 13:12 ` [PATCH v9 perf,bpf 00/15] perf annotation of " Jiri Olsa
2019-03-21 9:10 ` Jiri Olsa
2019-03-21 14:12 ` Arnaldo Carvalho de Melo
-- strict thread matches above, loose matches on Subject: below --
2019-03-07 17:57 [PATCH v7 " Song Liu
2019-03-07 17:57 ` [PATCH v7 perf,bpf 01/15] perf, bpf: consider events with attr.bpf_event as side-band events Song Liu
2019-03-07 17:57 ` [PATCH v7 perf,bpf 02/15] bpf: libbpf: introduce bpf_program__get_prog_info_linear() Song Liu
2019-03-11 18:26 ` Arnaldo Carvalho de Melo
2019-03-11 20:45 ` Daniel Borkmann
2019-03-11 20:57 ` Arnaldo Carvalho de Melo
2019-03-12 11:20 ` Daniel Borkmann
2019-03-07 17:57 ` [PATCH v7 perf,bpf 03/15] bpf: bpftool: use bpf_program__get_prog_info_linear() in prog.c:do_dump() Song Liu
2019-03-07 17:57 ` [PATCH v7 perf,bpf 04/15] perf, bpf: synthesize bpf events with bpf_program__get_prog_info_linear() Song Liu
2019-03-07 17:58 ` [PATCH v7 perf,bpf 05/15] perf: change prototype of perf_event__synthesize_bpf_events() Song Liu
2019-03-07 17:58 ` [PATCH v7 perf,bpf 06/15] perf, bpf: save bpf_prog_info in a rbtree in perf_env Song Liu
2019-03-07 17:58 ` [PATCH v7 perf,bpf 07/15] perf, bpf: save bpf_prog_info information as headers to perf.data Song Liu
2019-03-11 17:56 ` Jiri Olsa
2019-03-11 18:05 ` Song Liu
2019-03-07 17:58 ` [PATCH v7 perf,bpf 08/15] perf, bpf: save btf in a rbtree in perf_env Song Liu
2019-03-07 17:58 ` [PATCH v7 perf,bpf 09/15] perf, bpf: save btf information as headers to perf.data Song Liu
2019-03-11 17:56 ` Jiri Olsa
2019-03-07 17:58 ` [PATCH v7 perf,bpf 10/15] perf-top: add option --no-bpf-event Song Liu
2019-03-07 17:58 ` [PATCH v7 perf,bpf 11/15] perf: add -lopcodes to feature-libbfd Song Liu
2019-03-07 23:26 ` Stanislav Fomichev
2019-03-07 23:47 ` Song Liu
2019-03-07 17:58 ` [PATCH v7 perf,bpf 12/15] perf, bpf: enable annotation of bpf program Song Liu
2019-03-11 17:56 ` Jiri Olsa
2019-03-11 18:04 ` Song Liu
2019-03-07 17:58 ` [PATCH v7 perf,bpf 13/15] perf, bpf: process PERF_BPF_EVENT_PROG_LOAD for annotation Song Liu
2019-03-07 17:58 ` [PATCH v7 perf,bpf 14/15] perf: introduce side band thread Song Liu
2019-03-11 17:57 ` Jiri Olsa
2019-03-07 17:58 ` [PATCH v7 perf,bpf 15/15] perf, bpf: save bpf_prog_info and btf of short living bpf programs Song Liu
2019-03-11 13:59 ` [PATCH v7 perf,bpf 00/15] perf annotation of BPF programs Jiri Olsa
2019-03-11 14:16 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190315190651.GA14938@kernel.org \
--to=arnaldo.melo@gmail.com \
--cc=Kernel-team@fb.com \
--cc=acme@redhat.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=sdf@fomichev.me \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).