From: Benson Leung <bleung@google.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
enric.balletbo@collabora.com, bleung@chromium.org
Subject: Re: [GIT PULL] chrome-platform updates for v5.1
Date: Tue, 12 Mar 2019 10:52:04 -0700 [thread overview]
Message-ID: <20190312175204.GA218101@google.com> (raw)
In-Reply-To: <CAHk-=wg50Hn+vBmTSLVc2dG0+3Sjn0ZeL22RH2YxgpgvKw5NpQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 7025 bytes --]
Hi Linus,
On Tue, Mar 12, 2019 at 09:56:18AM -0700, Linus Torvalds wrote:
> On Mon, Mar 11, 2019 at 9:39 PM Benson Leung <bleung@google.com> wrote:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git tags/tag-chrome-platform-for-v5.1
>
> No diffstat in the pull request? And the shortlog looks truncated too,
> with Nick Crews being reported as having four commits, but only two
> visible.
>
> (And yes, there are four commits in the pull itself).
>
> Finally, you say:
>
> > 2. Cleanup series between mfd and chrome/platform, moving
> > cros-ec attributes from mfd/cros_ec_dev to sub-drivers in platform/chrome.
>
> which I don't see at all in that pull. But that turns out to be
> because it already came through the mfd tree.
>
> Things look otherwise sane and I did the pull, but please fix your
> script and/or workflow. The "it already came through the mfd tree"
> issue is fine, but diffstat and truncated shortlog is bad.
>
Sorry about that. There was definitely a workflow issue this time around.
I'll nail down what happened. Here is the full pull-request sans-truncation
for posterity.
The following changes since commit 49a57857aeea06ca831043acbb0fa5e0f50602fd:
Linux 5.0-rc3 (2019-01-21 13:14:44 +1300)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git tags/tag-chrome-platform-for-v5.1
for you to fetch changes up to 2794449576a6024e203eca5cc2c1a3ae33102b8e:
platform/chrome: fix wilco-ec dependencies (2019-03-05 11:35:46 +0100)
----------------------------------------------------------------
chrome platform changes for v5.1
1. SPDX identifier cleanup for platform/chrome
2. Cleanup series between mfd and chrome/platform, moving
cros-ec attributes from mfd/cros_ec_dev to sub-drivers in platform/chrome.
3. Wilco EC driver
4. Maintainership change to new group repository.
----------------------------------------------------------------
Arnd Bergmann (1):
platform/chrome: fix wilco-ec dependencies
Enric Balletbo i Serra (20):
mfd / platform: cros_ec: Use devm_mfd_add_devices
mfd / platform: cros_ec: Move lightbar attributes to its own driver
mfd / platform: cros_ec: Move vbc attributes to its own driver
mfd / platform: cros_ec: Move debugfs attributes to its own driver
mfd / platform: cros_ec: Move device sysfs attributes to its own driver
mfd / platform: cros_ec_vbc: Instantiate only if the EC has a VBC NVRAM
platform/chrome: cros_ec_lightbar: Instantiate only if the EC has a lightbar
platform/chrome: cromeos_pstore: switch to SPDX identifier
platform/chrome: cros_ec_debugfs: switch to SPDX identifier
platform/chrome: cros_ec_lightbar: switch to SPDX identifier
platform/chrome: cros_ec_sysfs: switch to SPDX identifier
platform/chrome: cros_ec_vbc: switch to SPDX identifier
platform/chrome: cros_ec_i2c: switch to SPDX identifier
platform/chrome: cros_ec_lpc: switch to SPDX identifier
platform/chrome: cros_ec_proto: switch to SPDX identifier
platform/chrome: cros_ec_spi: switch to SPDX identifier
platform/chrome: cros_kbd_led_backlight: switch to SPDX identifier
platform/chrome: cros_ec_lightbar: remove pr_fmt() define
platform/chrome: cros_ec_sysfs: remove pr_fmt() define
MAINTAINERS: chrome-platform: change the git tree to a chrome-platform group git tree
Nick Crews (4):
platform/chrome: cros_ec: Remove cros_ec dependency in lpc_mec
platform/chrome: Add new driver for Wilco EC
platform/chrome: wilco_ec: Add support for raw commands in debugfs
platform/chrome: wilco_ec: Add RTC driver
Documentation/ABI/testing/debugfs-wilco-ec | 23 ++
Documentation/ABI/testing/sysfs-class-chromeos | 32 +++
.../sysfs-class-chromeos-driver-cros-ec-lightbar | 74 +++++++
.../sysfs-class-chromeos-driver-cros-ec-vbc | 6 +
MAINTAINERS | 2 +-
drivers/mfd/Kconfig | 1 -
drivers/mfd/cros_ec.c | 14 +-
drivers/mfd/cros_ec_dev.c | 89 +++-----
drivers/mfd/cros_ec_dev.h | 6 -
drivers/platform/chrome/Kconfig | 49 ++++-
drivers/platform/chrome/Makefile | 9 +-
drivers/platform/chrome/chromeos_pstore.c | 17 +-
drivers/platform/chrome/cros_ec_debugfs.c | 84 ++++----
drivers/platform/chrome/cros_ec_i2c.c | 32 +--
drivers/platform/chrome/cros_ec_lightbar.c | 150 +++++++------
drivers/platform/chrome/cros_ec_lpc.c | 38 ++--
drivers/platform/chrome/cros_ec_lpc_mec.c | 78 ++++---
drivers/platform/chrome/cros_ec_lpc_mec.h | 63 +++---
drivers/platform/chrome/cros_ec_lpc_reg.c | 73 ++-----
drivers/platform/chrome/cros_ec_lpc_reg.h | 20 +-
drivers/platform/chrome/cros_ec_proto.c | 19 +-
drivers/platform/chrome/cros_ec_spi.c | 31 +--
drivers/platform/chrome/cros_ec_sysfs.c | 62 ++++--
drivers/platform/chrome/cros_ec_vbc.c | 83 +++----
drivers/platform/chrome/cros_kbd_led_backlight.c | 19 +-
drivers/platform/chrome/wilco_ec/Kconfig | 20 ++
drivers/platform/chrome/wilco_ec/Makefile | 6 +
drivers/platform/chrome/wilco_ec/core.c | 136 ++++++++++++
drivers/platform/chrome/wilco_ec/debugfs.c | 238 +++++++++++++++++++++
drivers/platform/chrome/wilco_ec/mailbox.c | 237 ++++++++++++++++++++
drivers/rtc/Kconfig | 11 +
drivers/rtc/Makefile | 1 +
drivers/rtc/rtc-wilco-ec.c | 177 +++++++++++++++
include/linux/mfd/cros_ec.h | 21 --
include/linux/platform_data/wilco-ec.h | 144 +++++++++++++
35 files changed, 1542 insertions(+), 523 deletions(-)
create mode 100644 Documentation/ABI/testing/debugfs-wilco-ec
create mode 100644 Documentation/ABI/testing/sysfs-class-chromeos
create mode 100644 Documentation/ABI/testing/sysfs-class-chromeos-driver-cros-ec-lightbar
create mode 100644 Documentation/ABI/testing/sysfs-class-chromeos-driver-cros-ec-vbc
create mode 100644 drivers/platform/chrome/wilco_ec/Kconfig
create mode 100644 drivers/platform/chrome/wilco_ec/Makefile
create mode 100644 drivers/platform/chrome/wilco_ec/core.c
create mode 100644 drivers/platform/chrome/wilco_ec/debugfs.c
create mode 100644 drivers/platform/chrome/wilco_ec/mailbox.c
create mode 100644 drivers/rtc/rtc-wilco-ec.c
create mode 100644 include/linux/platform_data/wilco-ec.h
Benson
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-03-12 17:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 4:39 [GIT PULL] chrome-platform updates for v5.1 Benson Leung
2019-03-12 16:56 ` Linus Torvalds
2019-03-12 17:52 ` Benson Leung [this message]
2019-03-12 17:00 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190312175204.GA218101@google.com \
--to=bleung@google.com \
--cc=bleung@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).