From: Linus Torvalds <torvalds@linux-foundation.org>
To: Benson Leung <bleung@google.com>
Cc: Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
enric.balletbo@collabora.com, bleung@chromium.org
Subject: Re: [GIT PULL] chrome-platform updates for v5.1
Date: Tue, 12 Mar 2019 09:56:18 -0700 [thread overview]
Message-ID: <CAHk-=wg50Hn+vBmTSLVc2dG0+3Sjn0ZeL22RH2YxgpgvKw5NpQ@mail.gmail.com> (raw)
In-Reply-To: <20190312043908.GA261883@google.com>
On Mon, Mar 11, 2019 at 9:39 PM Benson Leung <bleung@google.com> wrote:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git tags/tag-chrome-platform-for-v5.1
No diffstat in the pull request? And the shortlog looks truncated too,
with Nick Crews being reported as having four commits, but only two
visible.
(And yes, there are four commits in the pull itself).
Finally, you say:
> 2. Cleanup series between mfd and chrome/platform, moving
> cros-ec attributes from mfd/cros_ec_dev to sub-drivers in platform/chrome.
which I don't see at all in that pull. But that turns out to be
because it already came through the mfd tree.
Things look otherwise sane and I did the pull, but please fix your
script and/or workflow. The "it already came through the mfd tree"
issue is fine, but diffstat and truncated shortlog is bad.
Linus
next prev parent reply other threads:[~2019-03-12 16:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 4:39 [GIT PULL] chrome-platform updates for v5.1 Benson Leung
2019-03-12 16:56 ` Linus Torvalds [this message]
2019-03-12 17:52 ` Benson Leung
2019-03-12 17:00 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wg50Hn+vBmTSLVc2dG0+3Sjn0ZeL22RH2YxgpgvKw5NpQ@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=bleung@chromium.org \
--cc=bleung@google.com \
--cc=enric.balletbo@collabora.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).