* [PATCH] media: seco-cec: fix building with RC_CORE=m
@ 2019-03-13 21:18 Arnd Bergmann
0 siblings, 0 replies; only message in thread
From: Arnd Bergmann @ 2019-03-13 21:18 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Arnd Bergmann, Hans Verkuil, Sakari Ailus, Laurent Pinchart,
Geert Uytterhoeven, linux-media, linux-kernel
I previously added an RC_CORE dependency here, but missed the corner
case of CONFIG_VIDEO_SECO_CEC=y with CONFIG_RC_CORE=m, which still
causes a link error:
drivers/media/platform/seco-cec/seco-cec.o: In function `secocec_probe':
seco-cec.c:(.text+0x1b8): undefined reference to `devm_rc_allocate_device'
seco-cec.c:(.text+0x2e8): undefined reference to `devm_rc_register_device'
drivers/media/platform/seco-cec/seco-cec.o: In function `secocec_irq_handler':
seco-cec.c:(.text+0xa2c): undefined reference to `rc_keydown'
Refine the dependency to disallow building the RC subdriver in this case.
This is the same logic we apply in other drivers like it.
Fixes: f27dd0ad6885 ("media: seco-cec: fix RC_CORE dependency")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/media/platform/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
index 4acbed189644..67e48ff10532 100644
--- a/drivers/media/platform/Kconfig
+++ b/drivers/media/platform/Kconfig
@@ -649,7 +649,7 @@ config VIDEO_SECO_CEC
config VIDEO_SECO_RC
bool "SECO Boards IR RC5 support"
depends on VIDEO_SECO_CEC
- depends on RC_CORE
+ depends on RC_CORE=y || RC_CORE = VIDEO_SECO_CEC
help
If you say yes here you will get support for the
SECO Boards Consumer-IR in seco-cec driver.
--
2.20.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-03-13 21:18 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-13 21:18 [PATCH] media: seco-cec: fix building with RC_CORE=m Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).