* [PATCH] rapidio: fix a NULL pointer derefenrece when create_workqueue fails
@ 2019-03-14 6:10 Kangjie Lu
2019-03-18 22:44 ` alex.bou9
2019-03-18 22:46 ` alex.bou9
0 siblings, 2 replies; 3+ messages in thread
From: Kangjie Lu @ 2019-03-14 6:10 UTC (permalink / raw)
To: kjlu; +Cc: pakki001, Matt Porter, Alexandre Bounine, linux-kernel
In case create_workqueue fails, the fix releases resources and
returns -ENOMEM to avoid NULL pointer dereference.
Signed-off-by: Kangjie Lu <kjlu@umn.edu>
---
drivers/rapidio/rio_cm.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/rapidio/rio_cm.c b/drivers/rapidio/rio_cm.c
index cf45829585cb..b29fc258eeba 100644
--- a/drivers/rapidio/rio_cm.c
+++ b/drivers/rapidio/rio_cm.c
@@ -2147,6 +2147,14 @@ static int riocm_add_mport(struct device *dev,
mutex_init(&cm->rx_lock);
riocm_rx_fill(cm, RIOCM_RX_RING_SIZE);
cm->rx_wq = create_workqueue(DRV_NAME "/rxq");
+ if (!cm->rx_wq) {
+ riocm_error("failed to allocate IBMBOX_%d on %s",
+ cmbox, mport->name);
+ rio_release_outb_mbox(mport, cmbox);
+ kfree(cm);
+ return -ENOMEM;
+ }
+
INIT_WORK(&cm->rx_work, rio_ibmsg_handler);
cm->tx_slot = 0;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] rapidio: fix a NULL pointer derefenrece when create_workqueue fails
2019-03-14 6:10 [PATCH] rapidio: fix a NULL pointer derefenrece when create_workqueue fails Kangjie Lu
@ 2019-03-18 22:44 ` alex.bou9
2019-03-18 22:46 ` alex.bou9
1 sibling, 0 replies; 3+ messages in thread
From: alex.bou9 @ 2019-03-18 22:44 UTC (permalink / raw)
To: 'Kangjie Lu'; +Cc: pakki001, 'Matt Porter', linux-kernel, akpm
Acked-by: Alexandre Bounine <alex.bou9@gmail.com>
-----Original Message-----
From: Kangjie Lu <kjlu@umn.edu>
Sent: Thursday, March 14, 2019 2:10 AM
To: kjlu@umn.edu
Cc: pakki001@umn.edu; Matt Porter <mporter@kernel.crashing.org>; Alexandre
Bounine <alex.bou9@gmail.com>; linux-kernel@vger.kernel.org
Subject: [PATCH] rapidio: fix a NULL pointer derefenrece when
create_workqueue fails
In case create_workqueue fails, the fix releases resources and
returns -ENOMEM to avoid NULL pointer dereference.
Signed-off-by: Kangjie Lu <kjlu@umn.edu>
---
drivers/rapidio/rio_cm.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/rapidio/rio_cm.c b/drivers/rapidio/rio_cm.c
index cf45829585cb..b29fc258eeba 100644
--- a/drivers/rapidio/rio_cm.c
+++ b/drivers/rapidio/rio_cm.c
@@ -2147,6 +2147,14 @@ static int riocm_add_mport(struct device *dev,
mutex_init(&cm->rx_lock);
riocm_rx_fill(cm, RIOCM_RX_RING_SIZE);
cm->rx_wq = create_workqueue(DRV_NAME "/rxq");
+ if (!cm->rx_wq) {
+ riocm_error("failed to allocate IBMBOX_%d on %s",
+ cmbox, mport->name);
+ rio_release_outb_mbox(mport, cmbox);
+ kfree(cm);
+ return -ENOMEM;
+ }
+
INIT_WORK(&cm->rx_work, rio_ibmsg_handler);
cm->tx_slot = 0;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] rapidio: fix a NULL pointer derefenrece when create_workqueue fails
2019-03-14 6:10 [PATCH] rapidio: fix a NULL pointer derefenrece when create_workqueue fails Kangjie Lu
2019-03-18 22:44 ` alex.bou9
@ 2019-03-18 22:46 ` alex.bou9
1 sibling, 0 replies; 3+ messages in thread
From: alex.bou9 @ 2019-03-18 22:46 UTC (permalink / raw)
To: 'Kangjie Lu'; +Cc: pakki001, 'Matt Porter', linux-kernel, akpm
Please correct spelling in the subject line: "dereference"
-----Original Message-----
From: Kangjie Lu <kjlu@umn.edu>
Sent: Thursday, March 14, 2019 2:10 AM
To: kjlu@umn.edu
Cc: pakki001@umn.edu; Matt Porter <mporter@kernel.crashing.org>; Alexandre
Bounine <alex.bou9@gmail.com>; linux-kernel@vger.kernel.org
Subject: [PATCH] rapidio: fix a NULL pointer derefenrece when
create_workqueue fails
In case create_workqueue fails, the fix releases resources and
returns -ENOMEM to avoid NULL pointer dereference.
Signed-off-by: Kangjie Lu <kjlu@umn.edu>
---
drivers/rapidio/rio_cm.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/rapidio/rio_cm.c b/drivers/rapidio/rio_cm.c
index cf45829585cb..b29fc258eeba 100644
--- a/drivers/rapidio/rio_cm.c
+++ b/drivers/rapidio/rio_cm.c
@@ -2147,6 +2147,14 @@ static int riocm_add_mport(struct device *dev,
mutex_init(&cm->rx_lock);
riocm_rx_fill(cm, RIOCM_RX_RING_SIZE);
cm->rx_wq = create_workqueue(DRV_NAME "/rxq");
+ if (!cm->rx_wq) {
+ riocm_error("failed to allocate IBMBOX_%d on %s",
+ cmbox, mport->name);
+ rio_release_outb_mbox(mport, cmbox);
+ kfree(cm);
+ return -ENOMEM;
+ }
+
INIT_WORK(&cm->rx_work, rio_ibmsg_handler);
cm->tx_slot = 0;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-18 22:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-14 6:10 [PATCH] rapidio: fix a NULL pointer derefenrece when create_workqueue fails Kangjie Lu
2019-03-18 22:44 ` alex.bou9
2019-03-18 22:46 ` alex.bou9
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).