* [PATCH] iio: pms7003: sleect IIO_TRIGGERED_BUFFER
@ 2019-03-14 9:00 Arnd Bergmann
2019-03-14 17:27 ` Tomasz Duszynski
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2019-03-14 9:00 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Arnd Bergmann, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Tomasz Duszynski, linux-iio,
linux-kernel
Without IIO_TRIGGERED_BUFFER, this driver fails to link:
drivers/iio/chemical/pms7003.o: In function `pms7003_probe':
pms7003.c:(.text+0x21c): undefined reference to `devm_iio_triggered_buffer_setup'
pms7003.c:(.text+0x21c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `devm_iio_triggered_buffer_setup'
Fixes: a1d642266c14 ("iio: chemical: add support for Plantower PMS7003 sensor")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/iio/chemical/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/chemical/Kconfig b/drivers/iio/chemical/Kconfig
index d5d146e9e372..6f253092a523 100644
--- a/drivers/iio/chemical/Kconfig
+++ b/drivers/iio/chemical/Kconfig
@@ -64,6 +64,7 @@ config IAQCORE
config PMS7003
tristate "Plantower PMS7003 particulate matter sensor"
depends on SERIAL_DEV_BUS
+ select IIO_TRIGGERED_BUFFER
help
Say Y here to build support for the Plantower PMS7003 particulate
matter sensor.
--
2.20.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: pms7003: sleect IIO_TRIGGERED_BUFFER
2019-03-14 9:00 [PATCH] iio: pms7003: sleect IIO_TRIGGERED_BUFFER Arnd Bergmann
@ 2019-03-14 17:27 ` Tomasz Duszynski
2019-03-16 16:35 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Tomasz Duszynski @ 2019-03-14 17:27 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Tomasz Duszynski, linux-iio,
linux-kernel
On Thu, Mar 14, 2019 at 10:00:52AM +0100, Arnd Bergmann wrote:
> Without IIO_TRIGGERED_BUFFER, this driver fails to link:
Good catch, thanks (btw, perhaps typo in subject can be fixed before
applying patch).
Acked-by: Tomasz Duszynski <tduszyns@gmail.com>
>
> drivers/iio/chemical/pms7003.o: In function `pms7003_probe':
> pms7003.c:(.text+0x21c): undefined reference to `devm_iio_triggered_buffer_setup'
> pms7003.c:(.text+0x21c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `devm_iio_triggered_buffer_setup'
>
> Fixes: a1d642266c14 ("iio: chemical: add support for Plantower PMS7003 sensor")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/iio/chemical/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/chemical/Kconfig b/drivers/iio/chemical/Kconfig
> index d5d146e9e372..6f253092a523 100644
> --- a/drivers/iio/chemical/Kconfig
> +++ b/drivers/iio/chemical/Kconfig
> @@ -64,6 +64,7 @@ config IAQCORE
> config PMS7003
> tristate "Plantower PMS7003 particulate matter sensor"
> depends on SERIAL_DEV_BUS
> + select IIO_TRIGGERED_BUFFER
> help
> Say Y here to build support for the Plantower PMS7003 particulate
> matter sensor.
> --
> 2.20.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: pms7003: sleect IIO_TRIGGERED_BUFFER
2019-03-14 17:27 ` Tomasz Duszynski
@ 2019-03-16 16:35 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2019-03-16 16:35 UTC (permalink / raw)
To: Tomasz Duszynski
Cc: Arnd Bergmann, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, linux-iio, linux-kernel
On Thu, 14 Mar 2019 18:27:35 +0100
Tomasz Duszynski <tduszyns@gmail.com> wrote:
> On Thu, Mar 14, 2019 at 10:00:52AM +0100, Arnd Bergmann wrote:
> > Without IIO_TRIGGERED_BUFFER, this driver fails to link:
>
> Good catch, thanks (btw, perhaps typo in subject can be fixed before
> applying patch).
>
> Acked-by: Tomasz Duszynski <tduszyns@gmail.com>
Applied to the fixes-togreg branch of iio.git with the typo
fixed.
Thanks!
Jonathan
>
> >
> > drivers/iio/chemical/pms7003.o: In function `pms7003_probe':
> > pms7003.c:(.text+0x21c): undefined reference to `devm_iio_triggered_buffer_setup'
> > pms7003.c:(.text+0x21c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `devm_iio_triggered_buffer_setup'
> >
> > Fixes: a1d642266c14 ("iio: chemical: add support for Plantower PMS7003 sensor")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> > drivers/iio/chemical/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/iio/chemical/Kconfig b/drivers/iio/chemical/Kconfig
> > index d5d146e9e372..6f253092a523 100644
> > --- a/drivers/iio/chemical/Kconfig
> > +++ b/drivers/iio/chemical/Kconfig
> > @@ -64,6 +64,7 @@ config IAQCORE
> > config PMS7003
> > tristate "Plantower PMS7003 particulate matter sensor"
> > depends on SERIAL_DEV_BUS
> > + select IIO_TRIGGERED_BUFFER
> > help
> > Say Y here to build support for the Plantower PMS7003 particulate
> > matter sensor.
> > --
> > 2.20.0
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-16 16:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-14 9:00 [PATCH] iio: pms7003: sleect IIO_TRIGGERED_BUFFER Arnd Bergmann
2019-03-14 17:27 ` Tomasz Duszynski
2019-03-16 16:35 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).