linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] iio: adc: fix indentation issue, remove extra tab
@ 2019-03-14 23:26 Colin King
  2019-03-15  9:25 ` Popa, Stefan Serban
  0 siblings, 1 reply; 4+ messages in thread
From: Colin King @ 2019-03-14 23:26 UTC (permalink / raw)
  To: Stefan Popa, Lars-Peter Clausen, Michael Hennerich,
	Jonathan Cameron, Hartmut Knaack, Peter Meerwald-Stadler,
	linux-iio
  Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

A return statement is indented one level too deeply; clean this
up by removing a tab.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/iio/adc/ad7124.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/adc/ad7124.c b/drivers/iio/adc/ad7124.c
index 7d5e5311d8de..659ef37d5fe8 100644
--- a/drivers/iio/adc/ad7124.c
+++ b/drivers/iio/adc/ad7124.c
@@ -411,7 +411,7 @@ static int ad7124_init_channel_vref(struct ad7124_state *st,
 			dev_err(&st->sd.spi->dev,
 				"Error, trying to use external voltage reference without a %s regulator.\n",
 				ad7124_ref_names[refsel]);
-				return PTR_ERR(st->vref[refsel]);
+			return PTR_ERR(st->vref[refsel]);
 		}
 		st->channel_config[channel_number].vref_mv =
 			regulator_get_voltage(st->vref[refsel]);
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] iio: adc: fix indentation issue, remove extra tab
  2019-03-14 23:26 [PATCH] iio: adc: fix indentation issue, remove extra tab Colin King
@ 2019-03-15  9:25 ` Popa, Stefan Serban
  2019-03-16 16:38   ` Jonathan Cameron
  0 siblings, 1 reply; 4+ messages in thread
From: Popa, Stefan Serban @ 2019-03-15  9:25 UTC (permalink / raw)
  To: colin.king, lars, pmeerw, Hennerich, Michael, jic23, linux-iio, knaack.h
  Cc: linux-kernel, kernel-janitors

On Jo, 2019-03-14 at 23:26 +0000, Colin King wrote:
> [External]
> 
> 
> From: Colin Ian King <colin.king@canonical.com>
> 
> A return statement is indented one level too deeply; clean this
> up by removing a tab.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Stefan Popa <stefan.popa@analog.com>

Thanks!

> ---
>  drivers/iio/adc/ad7124.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/ad7124.c b/drivers/iio/adc/ad7124.c
> index 7d5e5311d8de..659ef37d5fe8 100644
> --- a/drivers/iio/adc/ad7124.c
> +++ b/drivers/iio/adc/ad7124.c
> @@ -411,7 +411,7 @@ static int ad7124_init_channel_vref(struct
> ad7124_state *st,
>                         dev_err(&st->sd.spi->dev,
>                                 "Error, trying to use external voltage
> reference without a %s regulator.\n",
>                                 ad7124_ref_names[refsel]);
> -                               return PTR_ERR(st->vref[refsel]);
> +                       return PTR_ERR(st->vref[refsel]);
>                 }
>                 st->channel_config[channel_number].vref_mv =
>                         regulator_get_voltage(st->vref[refsel]);
> --
> 2.20.1
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] iio: adc: fix indentation issue, remove extra tab
  2019-03-15  9:25 ` Popa, Stefan Serban
@ 2019-03-16 16:38   ` Jonathan Cameron
  0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2019-03-16 16:38 UTC (permalink / raw)
  To: Popa, Stefan Serban
  Cc: colin.king, lars, pmeerw, Hennerich, Michael, linux-iio,
	knaack.h, linux-kernel, kernel-janitors

On Fri, 15 Mar 2019 09:25:38 +0000
"Popa, Stefan Serban" <StefanSerban.Popa@analog.com> wrote:

> On Jo, 2019-03-14 at 23:26 +0000, Colin King wrote:
> > [External]
> > 
> > 
> > From: Colin Ian King <colin.king@canonical.com>
> > 
> > A return statement is indented one level too deeply; clean this
> > up by removing a tab.
> > 
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>  
> Acked-by: Stefan Popa <stefan.popa@analog.com>
> 
Applied thanks.

Jonathan

> Thanks!
> 
> > ---
> >  drivers/iio/adc/ad7124.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/iio/adc/ad7124.c b/drivers/iio/adc/ad7124.c
> > index 7d5e5311d8de..659ef37d5fe8 100644
> > --- a/drivers/iio/adc/ad7124.c
> > +++ b/drivers/iio/adc/ad7124.c
> > @@ -411,7 +411,7 @@ static int ad7124_init_channel_vref(struct
> > ad7124_state *st,
> >                         dev_err(&st->sd.spi->dev,
> >                                 "Error, trying to use external voltage
> > reference without a %s regulator.\n",
> >                                 ad7124_ref_names[refsel]);
> > -                               return PTR_ERR(st->vref[refsel]);
> > +                       return PTR_ERR(st->vref[refsel]);
> >                 }
> >                 st->channel_config[channel_number].vref_mv =
> >                         regulator_get_voltage(st->vref[refsel]);
> > --
> > 2.20.1
> >  


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] iio: adc: fix indentation issue, remove extra tab
@ 2019-03-14 23:22 Colin King
  0 siblings, 0 replies; 4+ messages in thread
From: Colin King @ 2019-03-14 23:22 UTC (permalink / raw)
  To: Stefan Popa, Lars-Peter Clausen, Michael Hennerich,
	Jonathan Cameron, Hartmut Knaack, Peter Meerwald-Stadler,
	linux-iio
  Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

A return statement is indented one level too deeply; clean this
up by removing a tab.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/iio/adc/ad7124.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/adc/ad7124.c b/drivers/iio/adc/ad7124.c
index 7d5e5311d8de..659ef37d5fe8 100644
--- a/drivers/iio/adc/ad7124.c
+++ b/drivers/iio/adc/ad7124.c
@@ -411,7 +411,7 @@ static int ad7124_init_channel_vref(struct ad7124_state *st,
 			dev_err(&st->sd.spi->dev,
 				"Error, trying to use external voltage reference without a %s regulator.\n",
 				ad7124_ref_names[refsel]);
-				return PTR_ERR(st->vref[refsel]);
+			return PTR_ERR(st->vref[refsel]);
 		}
 		st->channel_config[channel_number].vref_mv =
 			regulator_get_voltage(st->vref[refsel]);
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-03-16 16:38 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-14 23:26 [PATCH] iio: adc: fix indentation issue, remove extra tab Colin King
2019-03-15  9:25 ` Popa, Stefan Serban
2019-03-16 16:38   ` Jonathan Cameron
  -- strict thread matches above, loose matches on Subject: below --
2019-03-14 23:22 Colin King

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).