linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] staging: erofs: Add whitespace after declaration
@ 2019-03-16 11:29 Bharath Vedartham
  2019-03-17 11:11 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Bharath Vedartham @ 2019-03-16 11:29 UTC (permalink / raw)
  To: gaoxiang25, yuchao0, gregkh; +Cc: linux-erofs, devel, linux-kernel

Fix the checkpatch.pl warning to add a whitespace after declaration
statements.

Signed-off-by: Bharath Vedartham <linux.bhar@gmail.com>
---
Changes since v2
	- Mutt was giving me a few problems. I apologise for the
	  previous poor patches.
---
 drivers/staging/erofs/inode.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/erofs/inode.c b/drivers/staging/erofs/inode.c
index 924b8df..9a36a1f 100644
--- a/drivers/staging/erofs/inode.c
+++ b/drivers/staging/erofs/inode.c
@@ -270,8 +270,8 @@ struct inode *erofs_iget(struct super_block *sb,
 	if (inode->i_state & I_NEW) {
 		int err;
 		struct erofs_vnode *vi = EROFS_V(inode);
-		vi->nid = nid;
 
+		vi->nid = nid;
 		err = fill_inode(inode, isdir);
 		if (likely(!err))
 			unlock_new_inode(inode);
@@ -305,4 +305,3 @@ const struct inode_operations erofs_fast_symlink_iops = {
 #endif
 	.get_acl = erofs_get_acl,
 };
-
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] staging: erofs: Add whitespace after declaration
  2019-03-16 11:29 [PATCH v2] staging: erofs: Add whitespace after declaration Bharath Vedartham
@ 2019-03-17 11:11 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2019-03-17 11:11 UTC (permalink / raw)
  To: Bharath Vedartham; +Cc: gaoxiang25, yuchao0, linux-erofs, devel, linux-kernel

On Sat, Mar 16, 2019 at 04:59:58PM +0530, Bharath Vedartham wrote:
> Fix the checkpatch.pl warning to add a whitespace after declaration
> statements.
> 
> Signed-off-by: Bharath Vedartham <linux.bhar@gmail.com>
> ---
> Changes since v2
> 	- Mutt was giving me a few problems. I apologise for the
> 	  previous poor patches.
> ---
>  drivers/staging/erofs/inode.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/erofs/inode.c b/drivers/staging/erofs/inode.c
> index 924b8df..9a36a1f 100644
> --- a/drivers/staging/erofs/inode.c
> +++ b/drivers/staging/erofs/inode.c
> @@ -270,8 +270,8 @@ struct inode *erofs_iget(struct super_block *sb,
>  	if (inode->i_state & I_NEW) {
>  		int err;
>  		struct erofs_vnode *vi = EROFS_V(inode);
> -		vi->nid = nid;
>  
> +		vi->nid = nid;
>  		err = fill_inode(inode, isdir);
>  		if (likely(!err))
>  			unlock_new_inode(inode);
> @@ -305,4 +305,3 @@ const struct inode_operations erofs_fast_symlink_iops = {
>  #endif
>  	.get_acl = erofs_get_acl,
>  };
> -

You also removed the last line of the file, which you did not mention :(


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-03-17 11:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-16 11:29 [PATCH v2] staging: erofs: Add whitespace after declaration Bharath Vedartham
2019-03-17 11:11 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).