* [PATCH 1/4] Add support for SUNIX Multi-I/O board
@ 2019-03-19 12:07 Morris Ku
2019-04-02 6:19 ` Lee Jones
0 siblings, 1 reply; 3+ messages in thread
From: Morris Ku @ 2019-03-19 12:07 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, morris_ku, Morris Ku
Add Kconfig and Makefile entry.
Signed-off-by: Morris Ku <saumah@gmail.com>
---
mfd/Kconfig | 5 +++++
mfd/Makefile | 2 ++
2 files changed, 7 insertions(+)
diff --git a/mfd/Kconfig b/mfd/Kconfig
index 76f9909c..efbb3ef1 100644
--- a/mfd/Kconfig
+++ b/mfd/Kconfig
@@ -1916,5 +1916,10 @@ config RAVE_SP_CORE
Select this to get support for the Supervisory Processor
device found on several devices in RAVE line of hardware.
+config SUNIX
+ tristate "SUNIX Multi-I/O Board Driver"
+ help
+ Support for SUNIX Multi-I/O controller.
+
endmenu
endif
diff --git a/mfd/Makefile b/mfd/Makefile
index 12980a4a..b70f44de 100644
--- a/mfd/Makefile
+++ b/mfd/Makefile
@@ -241,4 +241,6 @@ obj-$(CONFIG_MFD_MXS_LRADC) += mxs-lradc.o
obj-$(CONFIG_MFD_SC27XX_PMIC) += sprd-sc27xx-spi.o
obj-$(CONFIG_RAVE_SP_CORE) += rave-sp.o
obj-$(CONFIG_MFD_ROHM_BD718XX) += rohm-bd718x7.o
+obj-$(CONFIG_SUNIX) += sunix/
+
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/4] Add support for SUNIX Multi-I/O board
2019-03-19 12:07 [PATCH 1/4] Add support for SUNIX Multi-I/O board Morris Ku
@ 2019-04-02 6:19 ` Lee Jones
2019-04-05 8:46 ` Enrico Weigelt, metux IT consult
0 siblings, 1 reply; 3+ messages in thread
From: Lee Jones @ 2019-04-02 6:19 UTC (permalink / raw)
To: Morris Ku; +Cc: linux-kernel, morris_ku
On Tue, 19 Mar 2019, Morris Ku wrote:
> Add Kconfig and Makefile entry.
>
> Signed-off-by: Morris Ku <saumah@gmail.com>
> ---
> mfd/Kconfig | 5 +++++
> mfd/Makefile | 2 ++
> 2 files changed, 7 insertions(+)
Can you send this set again please. There are some basic issues with
it, which would make reviewing difficult.
Please use `git format-patch` and `git send-email` to create and
submit your patches. Use the following flags; --annotate, --compose
and --thread to ensure the patches are sent a) pinned to each other so
they do not become spread throughout people's inboxes and b) a cover
letter is provided which should contain a summary of what you are
trying to achieve.
The diff should be based from the root directory, not 'drivers', such
that the diff should read "drivers/mfd/*".
> diff --git a/mfd/Kconfig b/mfd/Kconfig
> index 76f9909c..efbb3ef1 100644
> --- a/mfd/Kconfig
> +++ b/mfd/Kconfig
> @@ -1916,5 +1916,10 @@ config RAVE_SP_CORE
> Select this to get support for the Supervisory Processor
> device found on several devices in RAVE line of hardware.
>
> +config SUNIX
> + tristate "SUNIX Multi-I/O Board Driver"
> + help
> + Support for SUNIX Multi-I/O controller.
> +
> endmenu
> endif
> diff --git a/mfd/Makefile b/mfd/Makefile
> index 12980a4a..b70f44de 100644
> --- a/mfd/Makefile
> +++ b/mfd/Makefile
> @@ -241,4 +241,6 @@ obj-$(CONFIG_MFD_MXS_LRADC) += mxs-lradc.o
> obj-$(CONFIG_MFD_SC27XX_PMIC) += sprd-sc27xx-spi.o
> obj-$(CONFIG_RAVE_SP_CORE) += rave-sp.o
> obj-$(CONFIG_MFD_ROHM_BD718XX) += rohm-bd718x7.o
> +obj-$(CONFIG_SUNIX) += sunix/
> +
>
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/4] Add support for SUNIX Multi-I/O board
2019-04-02 6:19 ` Lee Jones
@ 2019-04-05 8:46 ` Enrico Weigelt, metux IT consult
0 siblings, 0 replies; 3+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2019-04-05 8:46 UTC (permalink / raw)
To: Lee Jones, Morris Ku; +Cc: linux-kernel, morris_ku
[-- Attachment #1: Type: text/plain, Size: 693 bytes --]
On 02.04.19 08:19, Lee Jones wrote:
> Please use `git format-patch` and `git send-email` to create and
> submit your patches. Use the following flags; --annotate, --compose
> and --thread to ensure the patches are sent a) pinned to each other so
> they do not become spread throughout people's inboxes and b) a cover
> letter is provided which should contain a summary of what you are
> trying to achieve.
here's a little script which helps w/ that: it automatically picks
the corresponding maintainers/maillists, you can also pass the usual
git-send-email flags.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287
[-- Attachment #2: git-send-patch --]
[-- Type: text/plain, Size: 1634 bytes --]
#!/bin/bash
# SPDX-License-Identifier: GPL-2.0
[ -x "$GIT" ] || export GIT=git
[ -d "$KERNELSRC" ] || export KERNELSRC=.
LKML="linux-kernel@vger.kernel.org"
check_ksrc() {
if [ -d $KERNELSRC/arch ] && \
[ -d $KERNELSRC/block ] && \
[ -d $KERNELSRC/init ] && \
[ -d $KERNELSRC/kernel ] && \
[ -d $KERNELSRC/sound ] && \
[ -d $KERNELSRC/drivers ] && \
[ -d $KERNELSRC/net ] && \
[ -d $KERNELSRC/include ] && \
[ -f $KERNELSRC/COPYING ] && \
[ -f $KERNELSRC/MAINTAINERS ] && \
[ -f $KERNELSRC/CREDITS ] && \
[ -f $KERNELSRC/Kconfig ] && \
[ -f $KERNELSRC/Makefile ]; then
return 0
else
echo "$0: cant find the kernel source tree. please call me from the topdir" >&2
exit 1
fi
}
check_ksrc
get_files() {
$GIT diff --name-only "$REF"
}
get_maintainers() {
$KERNELSRC/scripts/get_maintainer.pl --m --l --remove-duplicates `get_files` |
grep -v "$LKML" | \
grep -E "(maintainer|reviewer|open list)" | \
grep -o '[[:alnum:]+\.\_\-]*@[[:alnum:]+\.\_\-]*'
}
construct_params() {
echo -n "--to=$LKML "
for a in $MAINTAINERS; do
echo -n "--cc=$a "
done
}
if [ ! "$1" ]; then
echo "$0: missing git revision to send out" >&2
echo "" >&2
echo "for example: 'HEAD^' for sending just the last patch" >&2
echo >&2
echo "$0 <git-ref> [<extra params for git-send-mail>]"
exit 1
fi
REF="$1"
shift
echo "scanning for maintainers ..." >&2
MAINTAINERS=`get_maintainers`
echo "sending mail ..." >&2
$GIT send-email `construct_params` "$REF" "$@"
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-05 8:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-19 12:07 [PATCH 1/4] Add support for SUNIX Multi-I/O board Morris Ku
2019-04-02 6:19 ` Lee Jones
2019-04-05 8:46 ` Enrico Weigelt, metux IT consult
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).