* [PATCH] hw-breakpoints: fix missing break for SH_BREAKPOINT_READ
@ 2019-03-19 14:27 Colin King
0 siblings, 0 replies; only message in thread
From: Colin King @ 2019-03-19 14:27 UTC (permalink / raw)
To: Yoshinori Sato, Rich Felker, Frederic Weisbecker, linux-sh
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The SH_BREAKPOINT_READ case is missing a break and
falling through to SH_BREAKPOINT_WRITE. Fix this.
Fixes: 09a072947791 ("sh: hw-breakpoints: Add preliminary support for SH-4A UBC.")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
arch/sh/kernel/hw_breakpoint.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/sh/kernel/hw_breakpoint.c b/arch/sh/kernel/hw_breakpoint.c
index bc96b16288c1..af6a65ac04cf 100644
--- a/arch/sh/kernel/hw_breakpoint.c
+++ b/arch/sh/kernel/hw_breakpoint.c
@@ -157,6 +157,7 @@ int arch_bp_generic_fields(int sh_len, int sh_type,
switch (sh_type) {
case SH_BREAKPOINT_READ:
*gen_type = HW_BREAKPOINT_R;
+ break;
case SH_BREAKPOINT_WRITE:
*gen_type = HW_BREAKPOINT_W;
break;
--
2.20.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-03-19 14:28 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-19 14:27 [PATCH] hw-breakpoints: fix missing break for SH_BREAKPOINT_READ Colin King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).