linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] rtl8723ae: Make rtl8723e_dm_refresh_rate_adaptive_mask static
@ 2019-03-19 15:19 Yue Haibing
  2019-03-20  2:32 ` Pkshih
  2019-04-13 11:18 ` [PATCH] rtlwifi: " Kalle Valo
  0 siblings, 2 replies; 3+ messages in thread
From: Yue Haibing @ 2019-03-19 15:19 UTC (permalink / raw)
  To: davem, pkshih, kvalo; +Cc: linux-kernel, netdev, linux-wireless, YueHaibing

From: YueHaibing <yuehaibing@huawei.com>

Fix sparse warning:

drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.c:666:6:
 warning: symbol 'rtl8723e_dm_refresh_rate_adaptive_mask' was not declared. Should it be static?

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.c
index 514891e..d8260c7 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.c
@@ -663,7 +663,7 @@ void rtl8723e_dm_init_rate_adaptive_mask(struct ieee80211_hw *hw)
 
 }
 
-void rtl8723e_dm_refresh_rate_adaptive_mask(struct ieee80211_hw *hw)
+static void rtl8723e_dm_refresh_rate_adaptive_mask(struct ieee80211_hw *hw)
 {
 	struct rtl_priv *rtlpriv = rtl_priv(hw);
 	struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] rtl8723ae: Make rtl8723e_dm_refresh_rate_adaptive_mask static
  2019-03-19 15:19 [PATCH] rtl8723ae: Make rtl8723e_dm_refresh_rate_adaptive_mask static Yue Haibing
@ 2019-03-20  2:32 ` Pkshih
  2019-04-13 11:18 ` [PATCH] rtlwifi: " Kalle Valo
  1 sibling, 0 replies; 3+ messages in thread
From: Pkshih @ 2019-03-20  2:32 UTC (permalink / raw)
  To: yuehaibing, davem, kvalo; +Cc: linux-wireless, linux-kernel, netdev

On Tue, 2019-03-19 at 23:19 +0800, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
> 
> Fix sparse warning:
> 
> drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.c:666:6:
>  warning: symbol 'rtl8723e_dm_refresh_rate_adaptive_mask' was not declared.
> Should it be static?
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Acked-by: Ping-Ke Shih <pkshih@realtek.com>

The mail subject should be 'rtlwifi: rtl8723ae: ....'.


> ---
>  drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.c
> b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.c
> index 514891e..d8260c7 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.c
> @@ -663,7 +663,7 @@ void rtl8723e_dm_init_rate_adaptive_mask(struct
> ieee80211_hw *hw)
>  
>  }
>  
> -void rtl8723e_dm_refresh_rate_adaptive_mask(struct ieee80211_hw *hw)
> +static void rtl8723e_dm_refresh_rate_adaptive_mask(struct ieee80211_hw *hw)
>  {
>  	struct rtl_priv *rtlpriv = rtl_priv(hw);
>  	struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));





^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] rtlwifi: rtl8723ae: Make rtl8723e_dm_refresh_rate_adaptive_mask static
  2019-03-19 15:19 [PATCH] rtl8723ae: Make rtl8723e_dm_refresh_rate_adaptive_mask static Yue Haibing
  2019-03-20  2:32 ` Pkshih
@ 2019-04-13 11:18 ` Kalle Valo
  1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2019-04-13 11:18 UTC (permalink / raw)
  To: Yue Haibing
  Cc: davem, pkshih, linux-kernel, netdev, linux-wireless, YueHaibing

Yue Haibing <yuehaibing@huawei.com> wrote:

> From: YueHaibing <yuehaibing@huawei.com>
> 
> Fix sparse warning:
> 
> drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.c:666:6:
>  warning: symbol 'rtl8723e_dm_refresh_rate_adaptive_mask' was not declared. Should it be static?
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>

Patch applied to wireless-drivers-next.git, thanks.

bdfc4027de15 rtlwifi: rtl8723ae: Make rtl8723e_dm_refresh_rate_adaptive_mask static

-- 
https://patchwork.kernel.org/patch/10859777/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-04-13 11:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-19 15:19 [PATCH] rtl8723ae: Make rtl8723e_dm_refresh_rate_adaptive_mask static Yue Haibing
2019-03-20  2:32 ` Pkshih
2019-04-13 11:18 ` [PATCH] rtlwifi: " Kalle Valo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).