* [PATCH -next] rtc: opal: Make opal_tpo_alarm_irq_enable static
@ 2019-03-19 15:25 Yue Haibing
2019-03-24 13:36 ` Alexandre Belloni
0 siblings, 1 reply; 2+ messages in thread
From: Yue Haibing @ 2019-03-19 15:25 UTC (permalink / raw)
To: benh, paulus, mpe, a.zummo, alexandre.belloni
Cc: linux-kernel, linux-rtc, linuxppc-dev, YueHaibing
From: YueHaibing <yuehaibing@huawei.com>
Fix sparse warning:
drivers/rtc/rtc-opal.c:227:5:
warning: symbol 'opal_tpo_alarm_irq_enable' was not declared. Should it be static?
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/rtc/rtc-opal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-opal.c b/drivers/rtc/rtc-opal.c
index 60f2250..3dd9d26 100644
--- a/drivers/rtc/rtc-opal.c
+++ b/drivers/rtc/rtc-opal.c
@@ -224,7 +224,7 @@ static int opal_set_tpo_time(struct device *dev, struct rtc_wkalrm *alarm)
return rc;
}
-int opal_tpo_alarm_irq_enable(struct device *dev, unsigned int enabled)
+static int opal_tpo_alarm_irq_enable(struct device *dev, unsigned int enabled)
{
struct rtc_wkalrm alarm = { .enabled = 0 };
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] rtc: opal: Make opal_tpo_alarm_irq_enable static
2019-03-19 15:25 [PATCH -next] rtc: opal: Make opal_tpo_alarm_irq_enable static Yue Haibing
@ 2019-03-24 13:36 ` Alexandre Belloni
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2019-03-24 13:36 UTC (permalink / raw)
To: Yue Haibing
Cc: benh, paulus, mpe, a.zummo, linux-kernel, linux-rtc, linuxppc-dev
On 19/03/2019 23:25:31+0800, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> drivers/rtc/rtc-opal.c:227:5:
> warning: symbol 'opal_tpo_alarm_irq_enable' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/rtc/rtc-opal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-24 13:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-19 15:25 [PATCH -next] rtc: opal: Make opal_tpo_alarm_irq_enable static Yue Haibing
2019-03-24 13:36 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).