From: Mike Rapoport <rppt@linux.ibm.com>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.com>, Christoph Hellwig <hch@lst.de>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>
Subject: Re: [PATCH] sh: mm: make use of new memblocks_present() helper
Date: Tue, 19 Mar 2019 22:39:12 +0200 [thread overview]
Message-ID: <20190319203912.GA17966@rapoport-lnx> (raw)
In-Reply-To: <20190319180930.8231-1-logang@deltatee.com>
On Tue, Mar 19, 2019 at 12:09:30PM -0600, Logan Gunthorpe wrote:
> Cleanup the open coded for_each_memblock() loop that is equivalent
> to the new memblocks_present() helper.
>
> Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
> Cc: Rich Felker <dalias@libc.org>
Reviewed-by: Mike Rapoport <rppt@linux.ibm.com>
> ---
> arch/sh/mm/init.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> This is just a resend
>
> diff --git a/arch/sh/mm/init.c b/arch/sh/mm/init.c
> index a8e5c0e00fca..dc0ff41d602d 100644
> --- a/arch/sh/mm/init.c
> +++ b/arch/sh/mm/init.c
> @@ -234,12 +234,7 @@ static void __init do_init_bootmem(void)
>
> plat_mem_setup();
>
> - for_each_memblock(memory, reg) {
> - int nid = memblock_get_region_node(reg);
> -
> - memory_present(nid, memblock_region_memory_base_pfn(reg),
> - memblock_region_memory_end_pfn(reg));
> - }
> + memblocks_present();
> sparse_init();
> }
>
> --
> 2.19.0
>
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2019-03-19 20:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 18:09 [PATCH] sh: mm: make use of new memblocks_present() helper Logan Gunthorpe
2019-03-19 20:39 ` Mike Rapoport [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-01-15 17:37 Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190319203912.GA17966@rapoport-lnx \
--to=rppt@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=dalias@libc.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=mhocko@suse.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).