linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] net: bridge: use eth_broadcast_addr() to assign broadcast address
@ 2019-03-20  2:06 Mao Wenan
  2019-03-20 18:05 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Mao Wenan @ 2019-03-20  2:06 UTC (permalink / raw)
  To: davem, bridge, netdev, linux-kernel, kernel-janitors, nikolay, roopa

This patch is to use eth_broadcast_addr() to assign broadcast address
insetad of memset().

Signed-off-by: Mao Wenan <maowenan@huawei.com>
---
 net/bridge/br_multicast.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
index a0e369179f6d..b257342c0860 100644
--- a/net/bridge/br_multicast.c
+++ b/net/bridge/br_multicast.c
@@ -517,7 +517,7 @@ struct net_bridge_port_group *br_multicast_new_port_group(
 	if (src)
 		memcpy(p->eth_addr, src, ETH_ALEN);
 	else
-		memset(p->eth_addr, 0xff, ETH_ALEN);
+		eth_broadcast_addr(p->eth_addr);
 
 	return p;
 }
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next] net: bridge: use eth_broadcast_addr() to assign broadcast address
  2019-03-20  2:06 [PATCH net-next] net: bridge: use eth_broadcast_addr() to assign broadcast address Mao Wenan
@ 2019-03-20 18:05 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-03-20 18:05 UTC (permalink / raw)
  To: maowenan; +Cc: bridge, netdev, linux-kernel, kernel-janitors, nikolay, roopa

From: Mao Wenan <maowenan@huawei.com>
Date: Wed, 20 Mar 2019 10:06:57 +0800

> This patch is to use eth_broadcast_addr() to assign broadcast address
> insetad of memset().
> 
> Signed-off-by: Mao Wenan <maowenan@huawei.com>

Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-03-20 18:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-20  2:06 [PATCH net-next] net: bridge: use eth_broadcast_addr() to assign broadcast address Mao Wenan
2019-03-20 18:05 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).