* [PATCH -next] ntb: intel: Make intel_ntb3_peer_db_addr static
@ 2019-03-20 14:08 Yue Haibing
2019-03-20 15:17 ` Jon Mason
2019-03-20 15:20 ` Jiang, Dave
0 siblings, 2 replies; 3+ messages in thread
From: Yue Haibing @ 2019-03-20 14:08 UTC (permalink / raw)
To: dave.jiang, jdmason, allenbh; +Cc: linux-kernel, linux-ntb, YueHaibing
From: YueHaibing <yuehaibing@huawei.com>
Fix sparse warning:
drivers/ntb/hw/intel/ntb_hw_gen3.c:535:5: warning:
symbol 'intel_ntb3_peer_db_addr' was not declared. Should it be static?
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/ntb/hw/intel/ntb_hw_gen3.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/ntb/hw/intel/ntb_hw_gen3.c b/drivers/ntb/hw/intel/ntb_hw_gen3.c
index f475b56..c339716 100644
--- a/drivers/ntb/hw/intel/ntb_hw_gen3.c
+++ b/drivers/ntb/hw/intel/ntb_hw_gen3.c
@@ -532,9 +532,9 @@ static int intel_ntb3_mw_set_trans(struct ntb_dev *ntb, int pidx, int idx,
return 0;
}
-int intel_ntb3_peer_db_addr(struct ntb_dev *ntb, phys_addr_t *db_addr,
- resource_size_t *db_size,
- u64 *db_data, int db_bit)
+static int intel_ntb3_peer_db_addr(struct ntb_dev *ntb, phys_addr_t *db_addr,
+ resource_size_t *db_size,
+ u64 *db_data, int db_bit)
{
phys_addr_t db_addr_base;
struct intel_ntb_dev *ndev = ntb_ndev(ntb);
--
2.7.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] ntb: intel: Make intel_ntb3_peer_db_addr static
2019-03-20 14:08 [PATCH -next] ntb: intel: Make intel_ntb3_peer_db_addr static Yue Haibing
@ 2019-03-20 15:17 ` Jon Mason
2019-03-20 15:20 ` Jiang, Dave
1 sibling, 0 replies; 3+ messages in thread
From: Jon Mason @ 2019-03-20 15:17 UTC (permalink / raw)
To: Yue Haibing; +Cc: dave.jiang, allenbh, linux-kernel, linux-ntb
On Wed, Mar 20, 2019 at 10:08:12PM +0800, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> drivers/ntb/hw/intel/ntb_hw_gen3.c:535:5: warning:
> symbol 'intel_ntb3_peer_db_addr' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Looks good to me. Added to the ntb branch,
Thanks,
Jon
> ---
> drivers/ntb/hw/intel/ntb_hw_gen3.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/ntb/hw/intel/ntb_hw_gen3.c b/drivers/ntb/hw/intel/ntb_hw_gen3.c
> index f475b56..c339716 100644
> --- a/drivers/ntb/hw/intel/ntb_hw_gen3.c
> +++ b/drivers/ntb/hw/intel/ntb_hw_gen3.c
> @@ -532,9 +532,9 @@ static int intel_ntb3_mw_set_trans(struct ntb_dev *ntb, int pidx, int idx,
> return 0;
> }
>
> -int intel_ntb3_peer_db_addr(struct ntb_dev *ntb, phys_addr_t *db_addr,
> - resource_size_t *db_size,
> - u64 *db_data, int db_bit)
> +static int intel_ntb3_peer_db_addr(struct ntb_dev *ntb, phys_addr_t *db_addr,
> + resource_size_t *db_size,
> + u64 *db_data, int db_bit)
> {
> phys_addr_t db_addr_base;
> struct intel_ntb_dev *ndev = ntb_ndev(ntb);
> --
> 2.7.0
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH -next] ntb: intel: Make intel_ntb3_peer_db_addr static
2019-03-20 14:08 [PATCH -next] ntb: intel: Make intel_ntb3_peer_db_addr static Yue Haibing
2019-03-20 15:17 ` Jon Mason
@ 2019-03-20 15:20 ` Jiang, Dave
1 sibling, 0 replies; 3+ messages in thread
From: Jiang, Dave @ 2019-03-20 15:20 UTC (permalink / raw)
To: Yue Haibing, jdmason, allenbh; +Cc: linux-kernel, linux-ntb
> -----Original Message-----
> From: Yue Haibing [mailto:yuehaibing@huawei.com]
> Sent: Wednesday, March 20, 2019 7:08 AM
> To: Jiang, Dave <dave.jiang@intel.com>; jdmason@kudzu.us;
> allenbh@gmail.com
> Cc: linux-kernel@vger.kernel.org; linux-ntb@googlegroups.com; YueHaibing
> <yuehaibing@huawei.com>
> Subject: [PATCH -next] ntb: intel: Make intel_ntb3_peer_db_addr static
>
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> drivers/ntb/hw/intel/ntb_hw_gen3.c:535:5: warning:
> symbol 'intel_ntb3_peer_db_addr' was not declared. Should it be static?
For now yes. Thanks!
Acked-by: Dave Jiang <dave.jiang@intel.com>
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/ntb/hw/intel/ntb_hw_gen3.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/ntb/hw/intel/ntb_hw_gen3.c
> b/drivers/ntb/hw/intel/ntb_hw_gen3.c
> index f475b56..c339716 100644
> --- a/drivers/ntb/hw/intel/ntb_hw_gen3.c
> +++ b/drivers/ntb/hw/intel/ntb_hw_gen3.c
> @@ -532,9 +532,9 @@ static int intel_ntb3_mw_set_trans(struct ntb_dev
> *ntb, int pidx, int idx,
> return 0;
> }
>
> -int intel_ntb3_peer_db_addr(struct ntb_dev *ntb, phys_addr_t *db_addr,
> - resource_size_t *db_size,
> - u64 *db_data, int db_bit)
> +static int intel_ntb3_peer_db_addr(struct ntb_dev *ntb, phys_addr_t
> *db_addr,
> + resource_size_t *db_size,
> + u64 *db_data, int db_bit)
> {
> phys_addr_t db_addr_base;
> struct intel_ntb_dev *ndev = ntb_ndev(ntb);
> --
> 2.7.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-20 15:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-20 14:08 [PATCH -next] ntb: intel: Make intel_ntb3_peer_db_addr static Yue Haibing
2019-03-20 15:17 ` Jon Mason
2019-03-20 15:20 ` Jiang, Dave
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).