From: Robert Richter <rrichter@marvell.com>
To: Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "Borislav Petkov" <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
Jean Delvare <jdelvare@suse.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Marcin Benka <mbenka@marvell.com>,
"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>
Subject: Re: [PATCH] efi: Unify dmi setup code over architectures arm/arm64, io64 and x86
Date: Wed, 20 Mar 2019 14:48:34 +0000 [thread overview]
Message-ID: <20190320144828.a7iui7v5cwt45myr@rric.localdomain> (raw)
In-Reply-To: <20190320131607.vgst3r7ynha55ikw@rric.localdomain>
On 20.03.19 13:16:13, Robert Richter wrote:
> diff --git a/drivers/firmware/efi/arm-runtime.c b/drivers/firmware/efi/arm-runtime.c
> index 4a0dfe4ab829..c250b767030e 100644
> --- a/drivers/firmware/efi/arm-runtime.c
> +++ b/drivers/firmware/efi/arm-runtime.c
> @@ -162,14 +162,10 @@ void efi_virtmap_unload(void)
> static int __init arm_dmi_init(void)
> {
> /*
> - * On arm64/ARM, DMI depends on UEFI, and dmi_scan_machine() needs to
> + * On arm64/ARM, DMI depends on UEFI, and dmi_setup() needs to
> * be called early because dmi_id_init(), which is an arch_initcall
> * itself, depends on dmi_scan_machine() having been called already.
> */
> - dmi_scan_machine();
> - dmi_memdev_walk();
> - if (dmi_available)
> - dmi_set_dump_stack_arch_desc();
This went wrong in the last stage of a comment rework. A dmi_setup()
should be here. Will resubmit. Sorry.
-Robert
> return 0;
> }
next prev parent reply other threads:[~2019-03-20 14:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 13:05 [PATCH] efi/arm: Show SMBIOS bank/device location in cper and ghes error logs Robert Richter
2019-03-20 13:16 ` [PATCH] efi: Unify dmi setup code over architectures arm/arm64, io64 and x86 Robert Richter
2019-03-20 14:48 ` Robert Richter [this message]
2019-03-20 15:22 ` [PATCH v2] " Robert Richter
2019-03-20 22:02 ` Ard Biesheuvel
2019-03-21 9:39 ` Robert Richter
2019-03-21 9:51 ` Ard Biesheuvel
2019-03-21 10:08 ` Robert Richter
2019-03-21 10:09 ` Ard Biesheuvel
2019-03-21 10:11 ` Jean Delvare
2019-03-21 10:14 ` Ard Biesheuvel
2019-03-27 18:53 ` Ard Biesheuvel
2019-03-28 7:55 ` Robert Richter
2019-03-28 7:57 ` Ard Biesheuvel
2019-03-28 7:42 ` Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190320144828.a7iui7v5cwt45myr@rric.localdomain \
--to=rrichter@marvell.com \
--cc=ard.biesheuvel@linaro.org \
--cc=bp@alien8.de \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=jdelvare@suse.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbenka@marvell.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).