From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Robert Richter <rrichter@marvell.com>
Cc: Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
Jean Delvare <jdelvare@suse.com>,
Marcin Benka <mbenka@marvell.com>,
"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>
Subject: Re: [PATCH v2] efi: Unify dmi setup code over architectures arm/arm64, io64 and x86
Date: Thu, 21 Mar 2019 11:09:38 +0100 [thread overview]
Message-ID: <CAKv+Gu9WwgYiiGp4sZOndD8znPxtg5g-qrSAvx9=zHm5x5ikSw@mail.gmail.com> (raw)
In-Reply-To: <20190321100819.ok3uuojjvegjjlpg@rric.localdomain>
On Thu, 21 Mar 2019 at 11:08, Robert Richter <rrichter@marvell.com> wrote:
>
> On 21.03.19 10:51:34, Ard Biesheuvel wrote:
> > On Thu, 21 Mar 2019 at 10:39, Robert Richter <rrichter@marvell.com> wrote:
> > >
> > > On 20.03.19 23:02:09, Ard Biesheuvel wrote:
> > > > On Wed, 20 Mar 2019 at 16:23, Robert Richter <rrichter@marvell.com> wrote:
> > > > >
> > > > > On 20.03.19 14:16:07, Robert Richter wrote:
> > > > > > On 20.03.19 13:05:37, Robert Richter wrote:
> > > > > > > @@ -167,6 +167,7 @@ static int __init arm_dmi_init(void)
> > > > > > > * itself, depends on dmi_scan_machine() having been called already.
> > > > > > > */
> > > > > > > dmi_scan_machine();
> > > > > > > + dmi_memdev_walk();
> > > > > > > if (dmi_available)
> > > > > > > dmi_set_dump_stack_arch_desc();
> > > > > > > return 0;
> > > > > >
> > > > > > After
> > > > > >
> > > > > > [PATCH] efi/arm: Show SMBIOS bank/device location in cper and
> > > > > > ghes error logs
> > > > > >
> > > > > > wents in for arm/arm64, we can unify the code. See patch below.
> > > > >
> > > > > V2 with the fix in arm_dmi_init() below.
> > > > >
> > > > > -Robert
> > > > >
> > > > >
> > > > > -- >8 --
> > > > > From: Robert Richter <rrichter@marvell.com>
> > > > > Subject: [PATCH v2] efi: Unify dmi setup code over architectures arm/arm64,
> > > > > io64 and x86
> > > > >
> > > > > All architectures (arm/arm64, io64 and x86) do the same here, so unify
> > > > > the code.
> > > > >
> > > > > Note: We do not need to call dump_stack_set_arch_desc() in case of
> > > > > !dmi_available. Both strings, dmi_ids_string and dump_stack_arch_
> > > > > desc_str are initialized zero and thus nothing would change.
> > > > >
> > > >
> > > > I don't understand the last sentence - we do not need to call
> > > > dump_stack_set_arch_desc() when !dmi_available, but we do so anyway,
> > > > right? Doesn't that wipe the arch description we set based on the DT
> > > > machine name?
> > >
> > > No, in dmi_setup() we exit early when !dmi_available. So for arm/arm64
> > > nothing changed. But for x86 and ia64 we no longer call dump_stack_
> > > set_arch_desc() in this case. This is ok since both strings,
> > > dmi_ids_string and dump_stack_arch_desc_str, are initialized zero and
> > > copying one to the other does not change anything.
> > >
> >
> > Ah, of course. Apologies for not reading more carefully.
> >
> > I'll take this patch via the EFI tree.
> >
> > It seems to me though that the previous patch makes the memdev_walk()
> > call unconditional for ARM, and this change subsequently makes it
> > dependent on dmi_available. Should we fix that?
>
> The first patch has the check in memdev_walk(). So that is looking
> good. The check is then moved to dmi_setup() in the 2nd patch.
>
OK, that works for me.
> Thanks for handling this.
>
Thanks for the contribution.
next prev parent reply other threads:[~2019-03-21 10:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 13:05 [PATCH] efi/arm: Show SMBIOS bank/device location in cper and ghes error logs Robert Richter
2019-03-20 13:16 ` [PATCH] efi: Unify dmi setup code over architectures arm/arm64, io64 and x86 Robert Richter
2019-03-20 14:48 ` Robert Richter
2019-03-20 15:22 ` [PATCH v2] " Robert Richter
2019-03-20 22:02 ` Ard Biesheuvel
2019-03-21 9:39 ` Robert Richter
2019-03-21 9:51 ` Ard Biesheuvel
2019-03-21 10:08 ` Robert Richter
2019-03-21 10:09 ` Ard Biesheuvel [this message]
2019-03-21 10:11 ` Jean Delvare
2019-03-21 10:14 ` Ard Biesheuvel
2019-03-27 18:53 ` Ard Biesheuvel
2019-03-28 7:55 ` Robert Richter
2019-03-28 7:57 ` Ard Biesheuvel
2019-03-28 7:42 ` Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu9WwgYiiGp4sZOndD8znPxtg5g-qrSAvx9=zHm5x5ikSw@mail.gmail.com' \
--to=ard.biesheuvel@linaro.org \
--cc=bp@alien8.de \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=jdelvare@suse.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbenka@marvell.com \
--cc=mingo@redhat.com \
--cc=rrichter@marvell.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).