* [PATCH v3] staging: rtlwifi: Fix potential NULL pointer dereference of kzalloc
@ 2019-03-20 15:42 Aditya Pakki
2019-03-20 19:21 ` Mukesh Ojha
0 siblings, 1 reply; 2+ messages in thread
From: Aditya Pakki @ 2019-03-20 15:42 UTC (permalink / raw)
To: pakki001; +Cc: kjlu, Greg Kroah-Hartman, Nathan Chancellor, devel, linux-kernel
phydm.internal is allocated using kzalloc which is used multiple
times without a check for NULL pointer. This patch avoids such a
scenario by returning 0, consistent with the failure case.
Signed-off-by: Aditya Pakki <pakki001@umn.edu>
---
v2: Move the signed off line above
v1: Patch collision with different things, fix as per Greg
---
drivers/staging/rtlwifi/phydm/rtl_phydm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/rtlwifi/phydm/rtl_phydm.c b/drivers/staging/rtlwifi/phydm/rtl_phydm.c
index 9930ed954abb..4cc77b2016e1 100644
--- a/drivers/staging/rtlwifi/phydm/rtl_phydm.c
+++ b/drivers/staging/rtlwifi/phydm/rtl_phydm.c
@@ -180,6 +180,8 @@ static int rtl_phydm_init_priv(struct rtl_priv *rtlpriv,
rtlpriv->phydm.internal =
kzalloc(sizeof(struct phy_dm_struct), GFP_KERNEL);
+ if (!rtlpriv->phydm.internal)
+ return 0;
_rtl_phydm_init_com_info(rtlpriv, ic, params);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3] staging: rtlwifi: Fix potential NULL pointer dereference of kzalloc
2019-03-20 15:42 [PATCH v3] staging: rtlwifi: Fix potential NULL pointer dereference of kzalloc Aditya Pakki
@ 2019-03-20 19:21 ` Mukesh Ojha
0 siblings, 0 replies; 2+ messages in thread
From: Mukesh Ojha @ 2019-03-20 19:21 UTC (permalink / raw)
To: Aditya Pakki
Cc: kjlu, Greg Kroah-Hartman, Nathan Chancellor, devel, linux-kernel
On 3/20/2019 9:12 PM, Aditya Pakki wrote:
> phydm.internal is allocated using kzalloc which is used multiple
> times without a check for NULL pointer. This patch avoids such a
> scenario by returning 0, consistent with the failure case.
>
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>
>
> ---
> v2: Move the signed off line above
> v1: Patch collision with different things, fix as per Greg
> ---
> drivers/staging/rtlwifi/phydm/rtl_phydm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/rtlwifi/phydm/rtl_phydm.c b/drivers/staging/rtlwifi/phydm/rtl_phydm.c
> index 9930ed954abb..4cc77b2016e1 100644
> --- a/drivers/staging/rtlwifi/phydm/rtl_phydm.c
> +++ b/drivers/staging/rtlwifi/phydm/rtl_phydm.c
> @@ -180,6 +180,8 @@ static int rtl_phydm_init_priv(struct rtl_priv *rtlpriv,
>
> rtlpriv->phydm.internal =
> kzalloc(sizeof(struct phy_dm_struct), GFP_KERNEL);
> + if (!rtlpriv->phydm.internal)
> + return 0;
>
> _rtl_phydm_init_com_info(rtlpriv, ic, params);
>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Thanks,
Mukesh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-20 19:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-20 15:42 [PATCH v3] staging: rtlwifi: Fix potential NULL pointer dereference of kzalloc Aditya Pakki
2019-03-20 19:21 ` Mukesh Ojha
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).