From: Matthias Kaehlcke <mka@chromium.org>
To: Douglas Anderson <dianders@chromium.org>
Cc: Heiko Stuebner <heiko@sntech.de>,
ryandcase@chromium.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] ARM: dts: rockchip: Fix gpu opp node names for rk3288
Date: Thu, 21 Mar 2019 14:08:13 -0700 [thread overview]
Message-ID: <20190321210813.GR112750@google.com> (raw)
In-Reply-To: <20190320201402.114309-2-dianders@chromium.org>
On Wed, Mar 20, 2019 at 01:14:00PM -0700, Douglas Anderson wrote:
> The device tree compiler yells like this:
> Warning (unit_address_vs_reg):
> /gpu-opp-table/opp@100000000:
> node has a unit name, but no reg property
>
> Let's match the cpu opp node names and use a dash.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> arch/arm/boot/dts/rk3288.dtsi | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> index e9f454248398..79cd3c53e737 100644
> --- a/arch/arm/boot/dts/rk3288.dtsi
> +++ b/arch/arm/boot/dts/rk3288.dtsi
> @@ -1282,27 +1282,27 @@
> gpu_opp_table: gpu-opp-table {
> compatible = "operating-points-v2";
>
> - opp@100000000 {
> + opp-100000000 {
> opp-hz = /bits/ 64 <100000000>;
> opp-microvolt = <950000>;
> };
> - opp@200000000 {
> + opp-200000000 {
> opp-hz = /bits/ 64 <200000000>;
> opp-microvolt = <950000>;
> };
> - opp@300000000 {
> + opp-300000000 {
> opp-hz = /bits/ 64 <300000000>;
> opp-microvolt = <1000000>;
> };
> - opp@400000000 {
> + opp-400000000 {
> opp-hz = /bits/ 64 <400000000>;
> opp-microvolt = <1100000>;
> };
> - opp@500000000 {
> + opp-500000000 {
> opp-hz = /bits/ 64 <500000000>;
> opp-microvolt = <1200000>;
> };
> - opp@600000000 {
> + opp-600000000 {
> opp-hz = /bits/ 64 <600000000>;
> opp-microvolt = <1250000>;
> };
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
next prev parent reply other threads:[~2019-03-21 21:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 20:13 [PATCH 1/4] ARM: dts: rockchip: Fix gic/efuse sort ordering for rk3288 Douglas Anderson
2019-03-20 20:14 ` [PATCH 2/4] ARM: dts: rockchip: Fix gpu opp node names " Douglas Anderson
2019-03-21 21:08 ` Matthias Kaehlcke [this message]
2019-03-20 20:14 ` [PATCH 3/4] ARM: dts: rockchip: Remove #address/#size-cells from rk3288 mipi_dsi Douglas Anderson
2019-03-21 21:12 ` Matthias Kaehlcke
2019-03-20 20:14 ` [PATCH 4/4] ARM: dts: rockchip: Remove #address/#size-cells from rk3288-veyron gpio-keys Douglas Anderson
2019-03-21 21:14 ` Matthias Kaehlcke
2019-03-21 21:06 ` [PATCH 1/4] ARM: dts: rockchip: Fix gic/efuse sort ordering for rk3288 Matthias Kaehlcke
2019-03-25 12:35 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190321210813.GR112750@google.com \
--to=mka@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=ryandcase@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).