From: Matthias Kaehlcke <mka@chromium.org>
To: Douglas Anderson <dianders@chromium.org>
Cc: Heiko Stuebner <heiko@sntech.de>,
ryandcase@chromium.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/4] ARM: dts: rockchip: Remove #address/#size-cells from rk3288-veyron gpio-keys
Date: Thu, 21 Mar 2019 14:14:26 -0700 [thread overview]
Message-ID: <20190321211426.GT112750@google.com> (raw)
In-Reply-To: <20190320201402.114309-4-dianders@chromium.org>
On Wed, Mar 20, 2019 at 01:14:02PM -0700, Douglas Anderson wrote:
> They are pointless. As dtc points out:
> Warning (avoid_unnecessary_addr_size):
> /gpio-keys:
> unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
>
> Let's remove them.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> arch/arm/boot/dts/rk3288-veyron.dtsi | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/rk3288-veyron.dtsi b/arch/arm/boot/dts/rk3288-veyron.dtsi
> index 0bc2409f6903..192dbc089ade 100644
> --- a/arch/arm/boot/dts/rk3288-veyron.dtsi
> +++ b/arch/arm/boot/dts/rk3288-veyron.dtsi
> @@ -25,8 +25,6 @@
>
> gpio_keys: gpio-keys {
> compatible = "gpio-keys";
> - #address-cells = <1>;
> - #size-cells = <0>;
>
> pinctrl-names = "default";
> pinctrl-0 = <&pwr_key_l>;
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
next prev parent reply other threads:[~2019-03-21 21:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 20:13 [PATCH 1/4] ARM: dts: rockchip: Fix gic/efuse sort ordering for rk3288 Douglas Anderson
2019-03-20 20:14 ` [PATCH 2/4] ARM: dts: rockchip: Fix gpu opp node names " Douglas Anderson
2019-03-21 21:08 ` Matthias Kaehlcke
2019-03-20 20:14 ` [PATCH 3/4] ARM: dts: rockchip: Remove #address/#size-cells from rk3288 mipi_dsi Douglas Anderson
2019-03-21 21:12 ` Matthias Kaehlcke
2019-03-20 20:14 ` [PATCH 4/4] ARM: dts: rockchip: Remove #address/#size-cells from rk3288-veyron gpio-keys Douglas Anderson
2019-03-21 21:14 ` Matthias Kaehlcke [this message]
2019-03-21 21:06 ` [PATCH 1/4] ARM: dts: rockchip: Fix gic/efuse sort ordering for rk3288 Matthias Kaehlcke
2019-03-25 12:35 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190321211426.GT112750@google.com \
--to=mka@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=ryandcase@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).