* [PATCH v2] tracing: initialize variable in create_dyn_event()
@ 2019-03-22 6:58 frowand.list
2019-03-22 19:20 ` Steven Rostedt
0 siblings, 1 reply; 3+ messages in thread
From: frowand.list @ 2019-03-22 6:58 UTC (permalink / raw)
To: Steven Rostedt
Cc: linux-kernel, Masami Hiramatsu, Ingo Molnar, Tom Zanussi, Ravi Bangoria
From: Frank Rowand <frank.rowand@sony.com>
Fix compile warning in create_dyn_event(): 'ret' may be used uninitialized
in this function [-Wuninitialized].
Fixes: 5448d44c3855 ("tracing: Add unified dynamic event framework")
Signed-off-by: Frank Rowand <frank.rowand@sony.com>
---
changes since v1:
- initialize to -ENODEV instead of 0, as suggested by Steve
kernel/trace/trace_dynevent.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/trace_dynevent.c b/kernel/trace/trace_dynevent.c
index dd1f43588d70..fa100ed3b4de 100644
--- a/kernel/trace/trace_dynevent.c
+++ b/kernel/trace/trace_dynevent.c
@@ -74,7 +74,7 @@ int dyn_event_release(int argc, char **argv, struct dyn_event_operations *type)
static int create_dyn_event(int argc, char **argv)
{
struct dyn_event_operations *ops;
- int ret;
+ int ret = -ENODEV;
if (argv[0][0] == '-' || argv[0][0] == '!')
return dyn_event_release(argc, argv, NULL);
--
Frank Rowand <frank.rowand@sony.com>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] tracing: initialize variable in create_dyn_event()
2019-03-22 6:58 [PATCH v2] tracing: initialize variable in create_dyn_event() frowand.list
@ 2019-03-22 19:20 ` Steven Rostedt
2019-03-23 10:30 ` Masami Hiramatsu
0 siblings, 1 reply; 3+ messages in thread
From: Steven Rostedt @ 2019-03-22 19:20 UTC (permalink / raw)
To: frowand.list
Cc: linux-kernel, Masami Hiramatsu, Ingo Molnar, Tom Zanussi, Ravi Bangoria
On Thu, 21 Mar 2019 23:58:20 -0700
frowand.list@gmail.com wrote:
> From: Frank Rowand <frank.rowand@sony.com>
>
> Fix compile warning in create_dyn_event(): 'ret' may be used uninitialized
> in this function [-Wuninitialized].
>
> Fixes: 5448d44c3855 ("tracing: Add unified dynamic event framework")
>
> Signed-off-by: Frank Rowand <frank.rowand@sony.com>
Applied. Thanks Frank!
-- Steve
> ---
>
> changes since v1:
> - initialize to -ENODEV instead of 0, as suggested by Steve
>
> kernel/trace/trace_dynevent.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/trace/trace_dynevent.c b/kernel/trace/trace_dynevent.c
> index dd1f43588d70..fa100ed3b4de 100644
> --- a/kernel/trace/trace_dynevent.c
> +++ b/kernel/trace/trace_dynevent.c
> @@ -74,7 +74,7 @@ int dyn_event_release(int argc, char **argv, struct dyn_event_operations *type)
> static int create_dyn_event(int argc, char **argv)
> {
> struct dyn_event_operations *ops;
> - int ret;
> + int ret = -ENODEV;
>
> if (argv[0][0] == '-' || argv[0][0] == '!')
> return dyn_event_release(argc, argv, NULL);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] tracing: initialize variable in create_dyn_event()
2019-03-22 19:20 ` Steven Rostedt
@ 2019-03-23 10:30 ` Masami Hiramatsu
0 siblings, 0 replies; 3+ messages in thread
From: Masami Hiramatsu @ 2019-03-23 10:30 UTC (permalink / raw)
To: Steven Rostedt
Cc: frowand.list, linux-kernel, Masami Hiramatsu, Ingo Molnar,
Tom Zanussi, Ravi Bangoria
On Fri, 22 Mar 2019 15:20:00 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Thu, 21 Mar 2019 23:58:20 -0700
> frowand.list@gmail.com wrote:
>
> > From: Frank Rowand <frank.rowand@sony.com>
> >
> > Fix compile warning in create_dyn_event(): 'ret' may be used uninitialized
> > in this function [-Wuninitialized].
> >
> > Fixes: 5448d44c3855 ("tracing: Add unified dynamic event framework")
> >
> > Signed-off-by: Frank Rowand <frank.rowand@sony.com>
>
> Applied. Thanks Frank!
Thank you Frank and Steve,
feel free to add my ack.
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Thanks!
>
> -- Steve
>
> > ---
> >
> > changes since v1:
> > - initialize to -ENODEV instead of 0, as suggested by Steve
> >
> > kernel/trace/trace_dynevent.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/trace/trace_dynevent.c b/kernel/trace/trace_dynevent.c
> > index dd1f43588d70..fa100ed3b4de 100644
> > --- a/kernel/trace/trace_dynevent.c
> > +++ b/kernel/trace/trace_dynevent.c
> > @@ -74,7 +74,7 @@ int dyn_event_release(int argc, char **argv, struct dyn_event_operations *type)
> > static int create_dyn_event(int argc, char **argv)
> > {
> > struct dyn_event_operations *ops;
> > - int ret;
> > + int ret = -ENODEV;
> >
> > if (argv[0][0] == '-' || argv[0][0] == '!')
> > return dyn_event_release(argc, argv, NULL);
>
--
Masami Hiramatsu <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-23 10:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-22 6:58 [PATCH v2] tracing: initialize variable in create_dyn_event() frowand.list
2019-03-22 19:20 ` Steven Rostedt
2019-03-23 10:30 ` Masami Hiramatsu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).