* [PATCH -next] rcu/tree: Make rcu_check_gp_start_stall static
@ 2019-03-22 14:26 Yue Haibing
2019-03-22 16:20 ` Paul E. McKenney
0 siblings, 1 reply; 2+ messages in thread
From: Yue Haibing @ 2019-03-22 14:26 UTC (permalink / raw)
To: paulmck, josh, rostedt, mathieu.desnoyers, jiangshanlai, joel
Cc: linux-kernel, YueHaibing
From: YueHaibing <yuehaibing@huawei.com>
Fix sparse warning:
kernel/rcu/tree.c:2643:1: warning:
symbol 'rcu_check_gp_start_stall' was not declared. Should it be static?
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
kernel/rcu/tree.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index acd6ccf..ed3ef40 100644
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@@ -2639,7 +2639,7 @@ EXPORT_SYMBOL_GPL(rcu_force_quiescent_state);
* This function checks for grace-period requests that fail to motivate
* RCU to come out of its idle mode.
*/
-void
+static void
rcu_check_gp_start_stall(struct rcu_node *rnp, struct rcu_data *rdp,
const unsigned long gpssdelay)
{
--
2.7.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] rcu/tree: Make rcu_check_gp_start_stall static
2019-03-22 14:26 [PATCH -next] rcu/tree: Make rcu_check_gp_start_stall static Yue Haibing
@ 2019-03-22 16:20 ` Paul E. McKenney
0 siblings, 0 replies; 2+ messages in thread
From: Paul E. McKenney @ 2019-03-22 16:20 UTC (permalink / raw)
To: Yue Haibing
Cc: josh, rostedt, mathieu.desnoyers, jiangshanlai, joel, linux-kernel
On Fri, Mar 22, 2019 at 10:26:59PM +0800, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> kernel/rcu/tree.c:2643:1: warning:
> symbol 'rcu_check_gp_start_stall' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Good eyes!
But someone beat you to this. Please see branch "dev" of -rcu:
git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git
Thanx, Paul
> ---
> kernel/rcu/tree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> index acd6ccf..ed3ef40 100644
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -2639,7 +2639,7 @@ EXPORT_SYMBOL_GPL(rcu_force_quiescent_state);
> * This function checks for grace-period requests that fail to motivate
> * RCU to come out of its idle mode.
> */
> -void
> +static void
> rcu_check_gp_start_stall(struct rcu_node *rnp, struct rcu_data *rdp,
> const unsigned long gpssdelay)
> {
> --
> 2.7.0
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-22 16:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-22 14:26 [PATCH -next] rcu/tree: Make rcu_check_gp_start_stall static Yue Haibing
2019-03-22 16:20 ` Paul E. McKenney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).