From: Bjorn Helgaas <helgaas@kernel.org>
To: Jonathan Chocron <jonnyc@amazon.com>
Cc: linux-pci@vger.kernel.org, lorenzo.pieralisi@arm.com,
linux-kernel@vger.kernel.org, vaerov@amazon.com,
dwmw@amazon.co.uk, benh@kernel.crashing.org, alisaidi@amazon.com,
zeev@amazon.com, ronenk@amazon.com, barakw@amazon.com,
Talel Shenhar <talel@amazon.com>
Subject: Re: [PATCH] PCI: al: add pcie-al.c
Date: Mon, 25 Mar 2019 12:36:47 -0500 [thread overview]
Message-ID: <20190325173646.GR251185@google.com> (raw)
In-Reply-To: <f2c79fae-d35c-a17f-8b5c-d2404ff067a0@amazon.com>
On Mon, Mar 25, 2019 at 05:56:35PM +0200, Jonathan Chocron wrote:
> On 3/25/19 14:58, Bjorn Helgaas wrote:
> > I think you're actually looking for a AMZN0001 device, not a PNP0C02
> > device. Your firmware might have a PNP0C02 _HID and AMZN0001 _CID, but
> > that's not relevant here since you're only filtering by AMZN0001.
> >
> Actually, the _HID is AMZN0001 and the _CID is PNP0C02, so that's why
> I used PNP0C02 (to state that it is of this "type"). Please let me know if
> you still think it should be changed, so I'll integrate it into v2.
I do still think it should be changed, because there's nothing in the
code that refers to PNP0C02. That _CID could be absent or could
contain any other ID and it wouldn't make any difference to the
driver. But if there's no device with _HID or _CID of AMZN0001, the
driver will fail.
Bjorn
next prev parent reply other threads:[~2019-03-25 17:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 11:07 [PATCH] PCI: al: add pcie-al.c jonnyc
2019-03-25 12:58 ` Bjorn Helgaas
2019-03-25 15:56 ` Jonathan Chocron
2019-03-25 17:36 ` Bjorn Helgaas [this message]
2019-03-26 10:00 ` [PATCH v2] PCI: al: Add Amazon Annapurna Labs PCIe host controller driver Jonathan Chocron
2019-03-26 12:17 ` Lorenzo Pieralisi
2019-03-26 13:24 ` David Woodhouse
2019-03-26 15:58 ` Lorenzo Pieralisi
2019-03-27 9:52 ` David Woodhouse
2019-03-27 11:20 ` Lorenzo Pieralisi
2019-03-27 11:40 ` David Woodhouse
2019-03-27 9:43 ` David Woodhouse
2019-03-27 11:39 ` Lorenzo Pieralisi
2019-03-27 12:01 ` David Woodhouse
2019-03-26 12:55 ` Bjorn Helgaas
2019-03-28 10:55 ` Jonathan Chocron
2019-03-28 11:57 ` [PATCH v3] " Jonathan Chocron
2019-04-08 22:57 ` Benjamin Herrenschmidt
2019-04-16 13:13 ` David Woodhouse
2019-04-16 14:01 ` Lorenzo Pieralisi
2019-04-25 14:08 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190325173646.GR251185@google.com \
--to=helgaas@kernel.org \
--cc=alisaidi@amazon.com \
--cc=barakw@amazon.com \
--cc=benh@kernel.crashing.org \
--cc=dwmw@amazon.co.uk \
--cc=jonnyc@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=ronenk@amazon.com \
--cc=talel@amazon.com \
--cc=vaerov@amazon.com \
--cc=zeev@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).