From: David Woodhouse <dwmw2@infradead.org>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Jonathan Chocron <jonnyc@amazon.com>,
linux-pci@vger.kernel.org, bhelgaas@google.com,
linux-kernel@vger.kernel.org, vaerov@amazon.com,
benh@kernel.crashing.org, alisaidi@amazon.com, zeev@amazon.com,
ronenk@amazon.com, barakw@amazon.com,
Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
Zhou Wang <wangzhou1@hisilicon.com>
Subject: Re: [PATCH v2] PCI: al: Add Amazon Annapurna Labs PCIe host controller driver
Date: Wed, 27 Mar 2019 09:52:15 +0000 [thread overview]
Message-ID: <d02a76ff37dc2db153c7b9c4d00a0399f9ac1b47.camel@infradead.org> (raw)
In-Reply-To: <20190326155837.GA8820@e107981-ln.cambridge.arm.com>
[-- Attachment #1: Type: text/plain, Size: 1244 bytes --]
On Tue, 2019-03-26 at 15:58 +0000, Lorenzo Pieralisi wrote:
> > We did that internally. You really don't want me telling engineers to
> > post to the list *first* without running things by me to get the basics
> > right. Not to start with, at least.
>
> Hi David,
>
> I am obviously in favour of internal review and I do not question it was
> carried out internally, I just kindly ask developers to drop review tags
> given internally when going to public mailing lists - I understand it is
> churn for you but I prefer them to be given explicitly.
Sure, I've provided mine in public now.
I will attempt to remember your preference, although I'm not sure I
think it's necessary.
What's the failure mode we're protecting against here? That my
engineers are lying and have *faked* my reviewed-by tag?
Don't you think I'd *eat* them if I ever found that happening?
What's next? That you only accept such tags in signed email, so that
the dishonest engineer in question can't *fake* an email from me to the
list? They know I'm afflicted by Exchange so they can always send that
fake message with a message-id matching another message they know is
already in my inbox, so Exchange will helpfully discard theirs. :)
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5174 bytes --]
next prev parent reply other threads:[~2019-03-27 9:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 11:07 [PATCH] PCI: al: add pcie-al.c jonnyc
2019-03-25 12:58 ` Bjorn Helgaas
2019-03-25 15:56 ` Jonathan Chocron
2019-03-25 17:36 ` Bjorn Helgaas
2019-03-26 10:00 ` [PATCH v2] PCI: al: Add Amazon Annapurna Labs PCIe host controller driver Jonathan Chocron
2019-03-26 12:17 ` Lorenzo Pieralisi
2019-03-26 13:24 ` David Woodhouse
2019-03-26 15:58 ` Lorenzo Pieralisi
2019-03-27 9:52 ` David Woodhouse [this message]
2019-03-27 11:20 ` Lorenzo Pieralisi
2019-03-27 11:40 ` David Woodhouse
2019-03-27 9:43 ` David Woodhouse
2019-03-27 11:39 ` Lorenzo Pieralisi
2019-03-27 12:01 ` David Woodhouse
2019-03-26 12:55 ` Bjorn Helgaas
2019-03-28 10:55 ` Jonathan Chocron
2019-03-28 11:57 ` [PATCH v3] " Jonathan Chocron
2019-04-08 22:57 ` Benjamin Herrenschmidt
2019-04-16 13:13 ` David Woodhouse
2019-04-16 14:01 ` Lorenzo Pieralisi
2019-04-25 14:08 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d02a76ff37dc2db153c7b9c4d00a0399f9ac1b47.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=alisaidi@amazon.com \
--cc=barakw@amazon.com \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jonnyc@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=ronenk@amazon.com \
--cc=vaerov@amazon.com \
--cc=wangzhou1@hisilicon.com \
--cc=zeev@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).