From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Subject: Re: [REGRESSION] failed to boot: commit 1aec4211204d parport: daisy: use new parport device model
Date: Tue, 26 Mar 2019 04:25:46 +0900 [thread overview]
Message-ID: <20190325192546.GA14506@kroah.com> (raw)
In-Reply-To: <CAHk-=wiyLkyu3b6CLkeBBCq+584Bi_ukaGbVsnMtczJQUWJDVA@mail.gmail.com>
On Mon, Mar 25, 2019 at 11:04:49AM -0700, Linus Torvalds wrote:
> On Mon, Mar 25, 2019 at 8:36 AM Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > I bisected it down to this commit:
> >
> > aec4211204d ("parport: daisy: use new parport device model")
>
> I was confused, because no such commit exists.
>
> But it turns out you have the right commit ID in your subject line,
> and you just dropped the initial '1' .
>
> Anyway, that commit does look odd - why is the daisy_drv_init() done
> by parport_bus_init() rather than just as a regular module init? And
> as a result, now when daisy_drv_init() blocks, that blocks
> parport_bus_init(). I dunno. It seems to not really have a good reason
> for it.
>
> I think it should just be reverted unless Sudip can come up with a
> trivial fix. Greg?
I recommend just reverting it for now. The parport is "odd" in how it
has had to be converted over time to the driver model, which is why I
thought this patch was ok. Looks like it wasn't, sorry.
greg k-h
next prev parent reply other threads:[~2019-03-25 20:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 15:36 [REGRESSION] failed to boot: commit 1aec4211204d parport: daisy: use new parport device model Steven Rostedt
2019-03-25 18:04 ` Linus Torvalds
2019-03-25 19:25 ` Greg Kroah-Hartman [this message]
2019-03-25 20:29 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190325192546.GA14506@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).