From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>,
Michal Kubecek <mkubecek@suse.cz>
Subject: Re: [REGRESSION] failed to boot: commit 1aec4211204d parport: daisy: use new parport device model
Date: Mon, 25 Mar 2019 20:29:07 +0000 [thread overview]
Message-ID: <CADVatmNo8QyQbd4yxCucV0QkGiVbeVmjH=quAX9MH++53md6fA@mail.gmail.com> (raw)
In-Reply-To: <20190325192546.GA14506@kroah.com>
Hi Greg, Linus,
On Mon, Mar 25, 2019 at 8:12 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Mon, Mar 25, 2019 at 11:04:49AM -0700, Linus Torvalds wrote:
> > On Mon, Mar 25, 2019 at 8:36 AM Steven Rostedt <rostedt@goodmis.org> wrote:
> > >
> > > I bisected it down to this commit:
> > >
> > > aec4211204d ("parport: daisy: use new parport device model")
> >
> > I was confused, because no such commit exists.
> >
> > But it turns out you have the right commit ID in your subject line,
> > and you just dropped the initial '1' .
> >
> > Anyway, that commit does look odd - why is the daisy_drv_init() done
> > by parport_bus_init() rather than just as a regular module init? And
> > as a result, now when daisy_drv_init() blocks, that blocks
> > parport_bus_init(). I dunno. It seems to not really have a good reason
> > for it.
> >
> > I think it should just be reverted unless Sudip can come up with a
> > trivial fix. Greg?
>
> I recommend just reverting it for now. The parport is "odd" in how it
> has had to be converted over time to the driver model, which is why I
> thought this patch was ok. Looks like it wasn't, sorry.
It was reported by Michal from Suse and has now been fixed and he has
tested and confirmed it is working.
It is only happening on those systems/distro who has an alias set for
"parport_lowlevel".
Will send out the patch shortly.
--
Regards
Sudip
prev parent reply other threads:[~2019-03-25 20:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 15:36 [REGRESSION] failed to boot: commit 1aec4211204d parport: daisy: use new parport device model Steven Rostedt
2019-03-25 18:04 ` Linus Torvalds
2019-03-25 19:25 ` Greg Kroah-Hartman
2019-03-25 20:29 ` Sudip Mukherjee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADVatmNo8QyQbd4yxCucV0QkGiVbeVmjH=quAX9MH++53md6fA@mail.gmail.com' \
--to=sudipm.mukherjee@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).