* [PATCH] tty: serial_core: Spelling correction
@ 2019-03-22 3:01 Hariprasad Kelam
2019-03-22 3:28 ` Gustavo A. R. Silva
2019-03-27 15:13 ` Greg KH
0 siblings, 2 replies; 7+ messages in thread
From: Hariprasad Kelam @ 2019-03-22 3:01 UTC (permalink / raw)
To: gregkh, jslaby, linux-serial, linux-kernel
fix spelling mistake "overriden" -> "overridden"
This fix resolves warning reported by checkpatch tool
Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
---
drivers/tty/serial/serial_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
index 351843f..69f4871 100644
--- a/drivers/tty/serial/serial_core.c
+++ b/drivers/tty/serial/serial_core.c
@@ -1514,7 +1514,7 @@ static void uart_set_termios(struct tty_struct *tty,
}
uart_change_speed(tty, state, old_termios);
- /* reload cflag from termios; port driver may have overriden flags */
+ /* reload cflag from termios; port driver may have overridden flags */
cflag = tty->termios.c_cflag;
/* Handle transition to B0 status */
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] tty: serial_core: Spelling correction
2019-03-22 3:01 [PATCH] tty: serial_core: Spelling correction Hariprasad Kelam
@ 2019-03-22 3:28 ` Gustavo A. R. Silva
2019-03-27 15:13 ` Greg KH
1 sibling, 0 replies; 7+ messages in thread
From: Gustavo A. R. Silva @ 2019-03-22 3:28 UTC (permalink / raw)
To: Hariprasad Kelam, gregkh, jslaby, linux-serial, linux-kernel
On 3/21/19 10:01 PM, Hariprasad Kelam wrote:
> fix spelling mistake "overriden" -> "overridden"
> This fix resolves warning reported by checkpatch tool
>
Whenever you receive feedback on a patch, you need to version
the patches that you re-send. Also, you should mention what has
changed, so people know what to review.
I encourage you take a look at this:
https://kernelnewbies.org/Outreachyfirstpatch
Thanks
--
Gustavo
"If you receive feedback on a patch, and were asked to update the patch,
you need to version the patches that you re-send. A new version number
lets reviewers know you made changes to the patch, and they should review
it again."
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
> ---
> drivers/tty/serial/serial_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
> index 351843f..69f4871 100644
> --- a/drivers/tty/serial/serial_core.c
> +++ b/drivers/tty/serial/serial_core.c
> @@ -1514,7 +1514,7 @@ static void uart_set_termios(struct tty_struct *tty,
> }
>
> uart_change_speed(tty, state, old_termios);
> - /* reload cflag from termios; port driver may have overriden flags */
> + /* reload cflag from termios; port driver may have overridden flags */
> cflag = tty->termios.c_cflag;
>
> /* Handle transition to B0 status */
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] tty: serial_core: Spelling correction
2019-03-22 3:01 [PATCH] tty: serial_core: Spelling correction Hariprasad Kelam
2019-03-22 3:28 ` Gustavo A. R. Silva
@ 2019-03-27 15:13 ` Greg KH
1 sibling, 0 replies; 7+ messages in thread
From: Greg KH @ 2019-03-27 15:13 UTC (permalink / raw)
To: Hariprasad Kelam; +Cc: jslaby, linux-serial, linux-kernel
On Fri, Mar 22, 2019 at 08:31:59AM +0530, Hariprasad Kelam wrote:
> fix spelling mistake "overriden" -> "overridden"
> This fix resolves warning reported by checkpatch tool
>
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
> ---
> drivers/tty/serial/serial_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
You sent 3 patches with the same subject, and so I have no idea which
one is the "latest" one.
Please fix up and resend with the proper version information as the
documentation asks you to.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] tty: serial_core: Spelling correction
2019-03-22 0:38 Hariprasad Kelam
@ 2019-03-22 0:56 ` Gustavo A. R. Silva
0 siblings, 0 replies; 7+ messages in thread
From: Gustavo A. R. Silva @ 2019-03-22 0:56 UTC (permalink / raw)
To: Hariprasad Kelam, gregkh, jslaby, linux-serial, linux-kernel
On 3/21/19 7:38 PM, Hariprasad Kelam wrote:
> fix warning reported by checkpatch tool
>
It is much better if you explicitly mention what exactly you are fixing,
e.g. fix spelling mistake "overriden" -> "overridden"
It makes it easier for people to review your changes and give you
feedback.
Cultivate this practice and people will appreciate it. :)
Thanks
--
Gustavo
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
> ---
> drivers/tty/serial/serial_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
> index 351843f..69f4871 100644
> --- a/drivers/tty/serial/serial_core.c
> +++ b/drivers/tty/serial/serial_core.c
> @@ -1514,7 +1514,7 @@ static void uart_set_termios(struct tty_struct *tty,
> }
>
> uart_change_speed(tty, state, old_termios);
> - /* reload cflag from termios; port driver may have overriden flags */
> + /* reload cflag from termios; port driver may have overridden flags */
> cflag = tty->termios.c_cflag;
>
> /* Handle transition to B0 status */
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] tty: serial_core: Spelling correction
@ 2019-03-22 0:38 Hariprasad Kelam
2019-03-22 0:56 ` Gustavo A. R. Silva
0 siblings, 1 reply; 7+ messages in thread
From: Hariprasad Kelam @ 2019-03-22 0:38 UTC (permalink / raw)
To: gregkh, jslaby, linux-serial, linux-kernel
fix warning reported by checkpatch tool
Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
---
drivers/tty/serial/serial_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
index 351843f..69f4871 100644
--- a/drivers/tty/serial/serial_core.c
+++ b/drivers/tty/serial/serial_core.c
@@ -1514,7 +1514,7 @@ static void uart_set_termios(struct tty_struct *tty,
}
uart_change_speed(tty, state, old_termios);
- /* reload cflag from termios; port driver may have overriden flags */
+ /* reload cflag from termios; port driver may have overridden flags */
cflag = tty->termios.c_cflag;
/* Handle transition to B0 status */
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] tty: serial_core: Spelling correction
2019-03-21 3:59 hariprasadk
@ 2019-03-21 5:20 ` Jiri Slaby
0 siblings, 0 replies; 7+ messages in thread
From: Jiri Slaby @ 2019-03-21 5:20 UTC (permalink / raw)
To: hariprasadk, gregkh, linux-kernel, linux-serial
On 21. 03. 19, 4:59, hariprasadk wrote:
> fix warning reported by checkpatch tool
>
> Signed-off-by: hariprasadk <hari1219@gmail.com>
Please use your real name as per
Documentation/process/submitting-patches.rst.
> ---
> drivers/tty/serial/serial_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
> index 351843f..69f4871 100644
> --- a/drivers/tty/serial/serial_core.c
> +++ b/drivers/tty/serial/serial_core.c
> @@ -1514,7 +1514,7 @@ static void uart_set_termios(struct tty_struct *tty,
> }
>
> uart_change_speed(tty, state, old_termios);
> - /* reload cflag from termios; port driver may have overriden flags */
> + /* reload cflag from termios; port driver may have overridden flags */
> cflag = tty->termios.c_cflag;
>
> /* Handle transition to B0 status */
>
Otherwose looks good to me.
thanks,
--
js
suse labs
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] tty: serial_core: Spelling correction
@ 2019-03-21 3:59 hariprasadk
2019-03-21 5:20 ` Jiri Slaby
0 siblings, 1 reply; 7+ messages in thread
From: hariprasadk @ 2019-03-21 3:59 UTC (permalink / raw)
To: gregkh, jslaby, linux-serial, linux-kernel
fix warning reported by checkpatch tool
Signed-off-by: hariprasadk <hari1219@gmail.com>
---
drivers/tty/serial/serial_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
index 351843f..69f4871 100644
--- a/drivers/tty/serial/serial_core.c
+++ b/drivers/tty/serial/serial_core.c
@@ -1514,7 +1514,7 @@ static void uart_set_termios(struct tty_struct *tty,
}
uart_change_speed(tty, state, old_termios);
- /* reload cflag from termios; port driver may have overriden flags */
+ /* reload cflag from termios; port driver may have overridden flags */
cflag = tty->termios.c_cflag;
/* Handle transition to B0 status */
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-03-27 18:27 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-22 3:01 [PATCH] tty: serial_core: Spelling correction Hariprasad Kelam
2019-03-22 3:28 ` Gustavo A. R. Silva
2019-03-27 15:13 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2019-03-22 0:38 Hariprasad Kelam
2019-03-22 0:56 ` Gustavo A. R. Silva
2019-03-21 3:59 hariprasadk
2019-03-21 5:20 ` Jiri Slaby
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).