* [PATCH v2 0/2] Add EDMA0/EDMA1 nodes on i.MX8QXP
@ 2019-03-27 19:03 Daniel Baluta
2019-03-27 19:03 ` [PATCH v2 1/2] bindings: fsl-edma: Document fsl,imx8qxp-edma compatbile string Daniel Baluta
2019-03-27 19:03 ` [PATCH v2 2/2] arm64: dts: imx8qxp: Add EDMA0/EDMA1 nodes Daniel Baluta
0 siblings, 2 replies; 6+ messages in thread
From: Daniel Baluta @ 2019-03-27 19:03 UTC (permalink / raw)
To: shawnguo
Cc: robh+dt, mark.rutland, s.hauer, kernel, festevam, dl-linux-imx,
Aisheng Dong, Peng Fan, Anson Huang, devicetree,
linux-arm-kernel, S.j. Wang, linux-kernel, Daniel Baluta
First patch documents the fsl,imx8qxp-edma string while the second
adds the two EDMA nodes used by Audio peripherals on i.MX8QXP
Changes since v1:
* use "fsl,imx8qxp-edma" compatbile instead of "fsl,imx8qm-edma"
because this patch adds support for imx8QXP. eDMA driver is similar
for 8QM/8QXP but it doesn't have yet support added for these boards
so just the compatible string closer to the actual hardware.
Daniel Baluta (2):
bindings: fsl-edma: Document fsl,imx8qxp-edma compatbile string
arm64: dts: imx8qxp: Add EDMA0/EDMA1 nodes
.../devicetree/bindings/dma/fsl-edma.txt | 1 +
arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 72 +++++++++++++++++++
2 files changed, 73 insertions(+)
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 1/2] bindings: fsl-edma: Document fsl,imx8qxp-edma compatbile string
2019-03-27 19:03 [PATCH v2 0/2] Add EDMA0/EDMA1 nodes on i.MX8QXP Daniel Baluta
@ 2019-03-27 19:03 ` Daniel Baluta
2019-03-27 19:03 ` [PATCH v2 2/2] arm64: dts: imx8qxp: Add EDMA0/EDMA1 nodes Daniel Baluta
1 sibling, 0 replies; 6+ messages in thread
From: Daniel Baluta @ 2019-03-27 19:03 UTC (permalink / raw)
To: shawnguo
Cc: robh+dt, mark.rutland, s.hauer, kernel, festevam, dl-linux-imx,
Aisheng Dong, Peng Fan, Anson Huang, devicetree,
linux-arm-kernel, S.j. Wang, linux-kernel, Daniel Baluta
Add imx8qxp edma support.
Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
---
Documentation/devicetree/bindings/dma/fsl-edma.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/dma/fsl-edma.txt b/Documentation/devicetree/bindings/dma/fsl-edma.txt
index 97e213e07660..3fab727746dc 100644
--- a/Documentation/devicetree/bindings/dma/fsl-edma.txt
+++ b/Documentation/devicetree/bindings/dma/fsl-edma.txt
@@ -9,6 +9,7 @@ group, DMAMUX0 or DMAMUX1, but not both.
Required properties:
- compatible :
- "fsl,vf610-edma" for eDMA used similar to that on Vybrid vf610 SoC
+ - "fsl,imx8qxp-edma" for eDMA used similar to that on i.MX8X SoC
- reg : Specifies base physical address(s) and size of the eDMA registers.
The 1st region is eDMA control register's address and size.
The 2nd and the 3rd regions are programmable channel multiplexing
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 2/2] arm64: dts: imx8qxp: Add EDMA0/EDMA1 nodes
2019-03-27 19:03 [PATCH v2 0/2] Add EDMA0/EDMA1 nodes on i.MX8QXP Daniel Baluta
2019-03-27 19:03 ` [PATCH v2 1/2] bindings: fsl-edma: Document fsl,imx8qxp-edma compatbile string Daniel Baluta
@ 2019-03-27 19:03 ` Daniel Baluta
2019-03-28 2:31 ` Aisheng Dong
1 sibling, 1 reply; 6+ messages in thread
From: Daniel Baluta @ 2019-03-27 19:03 UTC (permalink / raw)
To: shawnguo
Cc: robh+dt, mark.rutland, s.hauer, kernel, festevam, dl-linux-imx,
Aisheng Dong, Peng Fan, Anson Huang, devicetree,
linux-arm-kernel, S.j. Wang, linux-kernel, Daniel Baluta,
Teo Hall
i.MX8QXP contains a total of 4 EDMA controllers of which
two are primarily for audio components and the other two
are for non-audio periperhals.
This patch adds the EDMA0/EDMA1 nodes used by audio peripherals.
EDMA0 contains channels for:
* ASRC0
* ESAI0
* SPDIF0
* SAI0, SAI1, SAI2, SAI3
EDMA1 contains channels for:
* ASRC1
* SAI4, SAI5
See chapter Audio DMA Memory Maps (2.2.3) from i.MX8QXP RM [1]
This patch is based on the dtsi file initially submitted by
Teo Hall in i.MX NXP internal tree.
[1] https://www.nxp.com/docs/en/reference-manual/IMX8DQXPRM.pdf
Cc: Teo Hall <teo.hall@nxp.com>
Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
---
arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 72 ++++++++++++++++++++++
1 file changed, 72 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
index 0cb939861a60..84c7c3eca1a1 100644
--- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
@@ -182,6 +182,78 @@
#clock-cells = <1>;
};
+ edma0: dma-controller@591f0000 {
+ compatible = "fsl,imx8qxp-edma";
+ reg = <0x59200000 0x10000>, /* asrc0 pair A input req */
+ <0x59210000 0x10000>, /* asrc0 pair B input req */
+ <0x59220000 0x10000>, /* asrc0 pair C input req */
+ <0x59230000 0x10000>, /* asrc0 pair A output req */
+ <0x59240000 0x10000>, /* asrc0 pair B output req */
+ <0x59250000 0x10000>, /* asrc0 pair C output req */
+ <0x59260000 0x10000>, /* esai0 rx */
+ <0x59270000 0x10000>, /* esai0 tx */
+ <0x59280000 0x10000>, /* spdif0 rx */
+ <0x59290000 0x10000>, /* spdif0 tx */
+ <0x592c0000 0x10000>, /* sai0 rx */
+ <0x592d0000 0x10000>, /* sai0 tx */
+ <0x592e0000 0x10000>, /* sai1 rx */
+ <0x592f0000 0x10000>, /* sai1 tx */
+ #dma-cells = <3>;
+ shared-interrupt;
+ dma-channels = <14>;
+ interrupts = <GIC_SPI 374 IRQ_TYPE_LEVEL_HIGH>, /* asrc 0 */
+ <GIC_SPI 375 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 376 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 377 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 378 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 379 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 410 IRQ_TYPE_LEVEL_HIGH>, /* esai0 */
+ <GIC_SPI 410 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 457 IRQ_TYPE_LEVEL_HIGH>, /* spdif0 */
+ <GIC_SPI 459 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 315 IRQ_TYPE_LEVEL_HIGH>, /* sai0 */
+ <GIC_SPI 315 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 317 IRQ_TYPE_LEVEL_HIGH>, /* sai1 */
+ <GIC_SPI 317 IRQ_TYPE_LEVEL_HIGH>,
+ interrupt-names = "edma0-chan0-rx", "edma0-chan1-rx", /* asrc0 */
+ "edma0-chan2-rx", "edma0-chan3-tx",
+ "edma0-chan4-tx", "edma0-chan5-tx",
+ "edma0-chan6-rx", "edma0-chan7-tx", /* esai0 */
+ "edma0-chan8-rx", "edma0-chan9-tx", /* spdif0 */
+ "edma0-chan12-rx", "edma0-chan13-tx", /* sai0 */
+ "edma0-chan14-rx", "edma0-chan15-tx", /* sai1 */
+ };
+
+ edma1: dma-controller@599F0000 {
+ compatible = "fsl,imx8qxp-edma";
+ reg = <0x0 0x59A00000 0x0 0x10000>, /* asrc1 */
+ <0x0 0x59A10000 0x0 0x10000>,
+ <0x0 0x59A20000 0x0 0x10000>,
+ <0x0 0x59A30000 0x0 0x10000>,
+ <0x0 0x59A40000 0x0 0x10000>,
+ <0x0 0x59A50000 0x0 0x10000>,
+ <0x0 0x59A80000 0x0 0x10000>, /* sai4 rx */
+ <0x0 0x59A90000 0x0 0x10000>, /* sai4 tx */
+ <0x0 0x59AA0000 0x0 0x10000>; /* sai5 tx */
+ #dma-cells = <3>;
+ shared-interrupt;
+ dma-channels = <9>;
+ interrupts = <GIC_SPI 382 IRQ_TYPE_LEVEL_HIGH>, /* asrc 1 */
+ <GIC_SPI 383 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 384 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 385 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 386 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 387 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 330 IRQ_TYPE_LEVEL_HIGH>, /* sai4 */
+ <GIC_SPI 330 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 332 IRQ_TYPE_LEVEL_HIGH>; /* sai5 */
+ interrupt-names = "edma1-chan0-rx", "edma1-chan1-rx", /* asrc1 */
+ "edma1-chan2-rx", "edma1-chan3-tx",
+ "edma1-chan4-tx", "edma1-chan5-tx",
+ "edma1-chan8-rx", "edma1-chan9-tx", /* sai4 */
+ "edma1-chan10-tx"; /* sai5 */
+ };
+
adma_lpuart0: serial@5a060000 {
compatible = "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";
reg = <0x5a060000 0x1000>;
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH v2 2/2] arm64: dts: imx8qxp: Add EDMA0/EDMA1 nodes
2019-03-27 19:03 ` [PATCH v2 2/2] arm64: dts: imx8qxp: Add EDMA0/EDMA1 nodes Daniel Baluta
@ 2019-03-28 2:31 ` Aisheng Dong
2019-03-28 8:53 ` Daniel Baluta
0 siblings, 1 reply; 6+ messages in thread
From: Aisheng Dong @ 2019-03-28 2:31 UTC (permalink / raw)
To: Daniel Baluta, shawnguo
Cc: robh+dt, mark.rutland, s.hauer, kernel, festevam, dl-linux-imx,
Peng Fan, Anson Huang, devicetree, linux-arm-kernel, S.j. Wang,
linux-kernel, Teo Hall
> From: Daniel Baluta
> Sent: Thursday, March 28, 2019 3:03 AM
>
> i.MX8QXP contains a total of 4 EDMA controllers of which two are primarily
> for audio components and the other two are for non-audio periperhals.
>
> This patch adds the EDMA0/EDMA1 nodes used by audio peripherals.
>
> EDMA0 contains channels for:
> * ASRC0
> * ESAI0
> * SPDIF0
> * SAI0, SAI1, SAI2, SAI3
>
> EDMA1 contains channels for:
> * ASRC1
> * SAI4, SAI5
>
> See chapter Audio DMA Memory Maps (2.2.3) from i.MX8QXP RM [1]
>
> This patch is based on the dtsi file initially submitted by Teo Hall in i.MX NXP
> internal tree.
>
> [1] https://www.nxp.com/docs/en/reference-manual/IMX8DQXPRM.pdf
>
> Cc: Teo Hall <teo.hall@nxp.com>
> Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 72
> ++++++++++++++++++++++
> 1 file changed, 72 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> index 0cb939861a60..84c7c3eca1a1 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> @@ -182,6 +182,78 @@
> #clock-cells = <1>;
> };
>
> + edma0: dma-controller@591f0000 {
> + compatible = "fsl,imx8qxp-edma";
> + reg = <0x59200000 0x10000>, /* asrc0 pair A input req */
> + <0x59210000 0x10000>, /* asrc0 pair B input req */
> + <0x59220000 0x10000>, /* asrc0 pair C input req */
> + <0x59230000 0x10000>, /* asrc0 pair A output req */
> + <0x59240000 0x10000>, /* asrc0 pair B output req */
> + <0x59250000 0x10000>, /* asrc0 pair C output req */
> + <0x59260000 0x10000>, /* esai0 rx */
> + <0x59270000 0x10000>, /* esai0 tx */
> + <0x59280000 0x10000>, /* spdif0 rx */
> + <0x59290000 0x10000>, /* spdif0 tx */
> + <0x592c0000 0x10000>, /* sai0 rx */
> + <0x592d0000 0x10000>, /* sai0 tx */
> + <0x592e0000 0x10000>, /* sai1 rx */
> + <0x592f0000 0x10000>, /* sai1 tx */
> + #dma-cells = <3>;
In binding doc, it's 2.
- #dma-cells : Must be <2>.
The 1st cell specifies the DMAMUX(0 for DMAMUX0 and 1 for DMAMUX1).
Specific request source can only be multiplexed by specific channels
group called DMAMUX.
The 2nd cell specifies the request source(slot) ID.
Need update binding doc?
> + shared-interrupt;
Undocumented property?
Checkpatch did not complain?
Regards
Dong Aisheng
> + dma-channels = <14>;
> + interrupts = <GIC_SPI 374 IRQ_TYPE_LEVEL_HIGH>, /* asrc 0
> */
> + <GIC_SPI 375 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 376 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 377 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 378 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 379 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 410 IRQ_TYPE_LEVEL_HIGH>, /* esai0 */
> + <GIC_SPI 410 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 457 IRQ_TYPE_LEVEL_HIGH>, /* spdif0 */
> + <GIC_SPI 459 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 315 IRQ_TYPE_LEVEL_HIGH>, /* sai0 */
> + <GIC_SPI 315 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 317 IRQ_TYPE_LEVEL_HIGH>, /* sai1 */
> + <GIC_SPI 317 IRQ_TYPE_LEVEL_HIGH>,
> + interrupt-names = "edma0-chan0-rx", "edma0-chan1-rx", /*
> asrc0 */
> + "edma0-chan2-rx", "edma0-chan3-tx",
> + "edma0-chan4-tx", "edma0-chan5-tx",
> + "edma0-chan6-rx", "edma0-chan7-tx", /* esai0 */
> + "edma0-chan8-rx", "edma0-chan9-tx", /* spdif0 */
> + "edma0-chan12-rx", "edma0-chan13-tx", /* sai0 */
> + "edma0-chan14-rx", "edma0-chan15-tx", /* sai1 */
> + };
> +
> + edma1: dma-controller@599F0000 {
> + compatible = "fsl,imx8qxp-edma";
> + reg = <0x0 0x59A00000 0x0 0x10000>, /* asrc1 */
> + <0x0 0x59A10000 0x0 0x10000>,
> + <0x0 0x59A20000 0x0 0x10000>,
> + <0x0 0x59A30000 0x0 0x10000>,
> + <0x0 0x59A40000 0x0 0x10000>,
> + <0x0 0x59A50000 0x0 0x10000>,
> + <0x0 0x59A80000 0x0 0x10000>, /* sai4 rx */
> + <0x0 0x59A90000 0x0 0x10000>, /* sai4 tx */
> + <0x0 0x59AA0000 0x0 0x10000>; /* sai5 tx */
> + #dma-cells = <3>;
> + shared-interrupt;
> + dma-channels = <9>;
> + interrupts = <GIC_SPI 382 IRQ_TYPE_LEVEL_HIGH>, /* asrc 1 */
> + <GIC_SPI 383 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 384 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 385 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 386 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 387 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 330 IRQ_TYPE_LEVEL_HIGH>, /* sai4 */
> + <GIC_SPI 330 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 332 IRQ_TYPE_LEVEL_HIGH>; /* sai5 */
> + interrupt-names = "edma1-chan0-rx", "edma1-chan1-rx", /*
> asrc1 */
> + "edma1-chan2-rx", "edma1-chan3-tx",
> + "edma1-chan4-tx", "edma1-chan5-tx",
> + "edma1-chan8-rx", "edma1-chan9-tx", /* sai4 */
> + "edma1-chan10-tx"; /* sai5 */
> + };
> +
> adma_lpuart0: serial@5a060000 {
> compatible = "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";
> reg = <0x5a060000 0x1000>;
> --
> 2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/2] arm64: dts: imx8qxp: Add EDMA0/EDMA1 nodes
2019-03-28 2:31 ` Aisheng Dong
@ 2019-03-28 8:53 ` Daniel Baluta
2019-03-28 9:25 ` Aisheng Dong
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Baluta @ 2019-03-28 8:53 UTC (permalink / raw)
To: Aisheng Dong
Cc: Daniel Baluta, shawnguo, robh+dt, mark.rutland, s.hauer, kernel,
festevam, dl-linux-imx, Peng Fan, Anson Huang, devicetree,
linux-arm-kernel, S.j. Wang, linux-kernel, Teo Hall, yibin.gong
On Thu, Mar 28, 2019 at 4:32 AM Aisheng Dong <aisheng.dong@nxp.com> wrote:
>
> > From: Daniel Baluta
> > Sent: Thursday, March 28, 2019 3:03 AM
> >
> > i.MX8QXP contains a total of 4 EDMA controllers of which two are primarily
> > for audio components and the other two are for non-audio periperhals.
> >
> > This patch adds the EDMA0/EDMA1 nodes used by audio peripherals.
> >
> > EDMA0 contains channels for:
> > * ASRC0
> > * ESAI0
> > * SPDIF0
> > * SAI0, SAI1, SAI2, SAI3
> >
> > EDMA1 contains channels for:
> > * ASRC1
> > * SAI4, SAI5
> >
> > See chapter Audio DMA Memory Maps (2.2.3) from i.MX8QXP RM [1]
> >
> > This patch is based on the dtsi file initially submitted by Teo Hall in i.MX NXP
> > internal tree.
> >
> > [1] https://www.nxp.com/docs/en/reference-manual/IMX8DQXPRM.pdf
> >
> > Cc: Teo Hall <teo.hall@nxp.com>
> > Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
> > ---
> > arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 72
> > ++++++++++++++++++++++
> > 1 file changed, 72 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > index 0cb939861a60..84c7c3eca1a1 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > @@ -182,6 +182,78 @@
> > #clock-cells = <1>;
> > };
> >
> > + edma0: dma-controller@591f0000 {
> > + compatible = "fsl,imx8qxp-edma";
> > + reg = <0x59200000 0x10000>, /* asrc0 pair A input req */
> > + <0x59210000 0x10000>, /* asrc0 pair B input req */
> > + <0x59220000 0x10000>, /* asrc0 pair C input req */
> > + <0x59230000 0x10000>, /* asrc0 pair A output req */
> > + <0x59240000 0x10000>, /* asrc0 pair B output req */
> > + <0x59250000 0x10000>, /* asrc0 pair C output req */
> > + <0x59260000 0x10000>, /* esai0 rx */
> > + <0x59270000 0x10000>, /* esai0 tx */
> > + <0x59280000 0x10000>, /* spdif0 rx */
> > + <0x59290000 0x10000>, /* spdif0 tx */
> > + <0x592c0000 0x10000>, /* sai0 rx */
> > + <0x592d0000 0x10000>, /* sai0 tx */
> > + <0x592e0000 0x10000>, /* sai1 rx */
> > + <0x592f0000 0x10000>, /* sai1 tx */
> > + #dma-cells = <3>;
>
> In binding doc, it's 2.
> - #dma-cells : Must be <2>.
> The 1st cell specifies the DMAMUX(0 for DMAMUX0 and 1 for DMAMUX1).
> Specific request source can only be multiplexed by specific channels
> group called DMAMUX.
> The 2nd cell specifies the request source(slot) ID.
>
> Need update binding doc?
>
> > + shared-interrupt;
>
> Undocumented property?
>
> Checkpatch did not complain?
Thanks Aisheng for this comment. I think we might need to delay a little bit
this patch because (as pointed by Yibin) on i.MX8 QXP/QM we use
fsl-edma-v3 which *is not* yet upstream.
So, lets get back to adding the nodes after Yibin sends edma-v3 patches.
thanks,
Daniel.
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH v2 2/2] arm64: dts: imx8qxp: Add EDMA0/EDMA1 nodes
2019-03-28 8:53 ` Daniel Baluta
@ 2019-03-28 9:25 ` Aisheng Dong
0 siblings, 0 replies; 6+ messages in thread
From: Aisheng Dong @ 2019-03-28 9:25 UTC (permalink / raw)
To: Daniel Baluta
Cc: Daniel Baluta, shawnguo, robh+dt, mark.rutland, s.hauer, kernel,
festevam, dl-linux-imx, Peng Fan, Anson Huang, devicetree,
linux-arm-kernel, S.j. Wang, linux-kernel, Teo Hall, Robin Gong
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > > b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > > index 0cb939861a60..84c7c3eca1a1 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > > @@ -182,6 +182,78 @@
> > > #clock-cells = <1>;
> > > };
> > >
> > > + edma0: dma-controller@591f0000 {
> > > + compatible = "fsl,imx8qxp-edma";
> > > + reg = <0x59200000 0x10000>, /* asrc0 pair A
> input req */
> > > + <0x59210000 0x10000>, /* asrc0 pair B
> input req */
> > > + <0x59220000 0x10000>, /* asrc0 pair C
> input req */
> > > + <0x59230000 0x10000>, /* asrc0 pair A
> output req */
> > > + <0x59240000 0x10000>, /* asrc0 pair B
> output req */
> > > + <0x59250000 0x10000>, /* asrc0 pair C
> output req */
> > > + <0x59260000 0x10000>, /* esai0 rx */
> > > + <0x59270000 0x10000>, /* esai0 tx */
> > > + <0x59280000 0x10000>, /* spdif0 rx */
> > > + <0x59290000 0x10000>, /* spdif0 tx */
> > > + <0x592c0000 0x10000>, /* sai0 rx */
> > > + <0x592d0000 0x10000>, /* sai0 tx */
> > > + <0x592e0000 0x10000>, /* sai1 rx */
> > > + <0x592f0000 0x10000>, /* sai1 tx */
> > > + #dma-cells = <3>;
> >
> > In binding doc, it's 2.
> > - #dma-cells : Must be <2>.
> > The 1st cell specifies the DMAMUX(0 for DMAMUX0 and 1 for
> DMAMUX1).
> > Specific request source can only be multiplexed by specific
> channels
> > group called DMAMUX.
> > The 2nd cell specifies the request source(slot) ID.
> >
> > Need update binding doc?
> >
> > > + shared-interrupt;
> >
> > Undocumented property?
> >
> > Checkpatch did not complain?
>
> Thanks Aisheng for this comment. I think we might need to delay a little bit
> this patch because (as pointed by Yibin) on i.MX8 QXP/QM we use
> fsl-edma-v3 which *is not* yet upstream.
>
> So, lets get back to adding the nodes after Yibin sends edma-v3 patches.
>
Yes, Yibin could check the comments when resending with edma driver support.
Regards
Dong Aisheng
> thanks,
> Daniel.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-03-28 9:25 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-27 19:03 [PATCH v2 0/2] Add EDMA0/EDMA1 nodes on i.MX8QXP Daniel Baluta
2019-03-27 19:03 ` [PATCH v2 1/2] bindings: fsl-edma: Document fsl,imx8qxp-edma compatbile string Daniel Baluta
2019-03-27 19:03 ` [PATCH v2 2/2] arm64: dts: imx8qxp: Add EDMA0/EDMA1 nodes Daniel Baluta
2019-03-28 2:31 ` Aisheng Dong
2019-03-28 8:53 ` Daniel Baluta
2019-03-28 9:25 ` Aisheng Dong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).