From: Steven Rostedt <rostedt@goodmis.org>
To: "Dmitry V. Levin" <ldv@altlinux.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Oleg Nesterov <oleg@redhat.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, LKML <linux-kernel@vger.kernel.org>,
Dominik Brodowski <linux@dominikbrodowski.net>,
Andy Lutomirski <luto@kernel.org>,
Kees Cook <keescook@chromium.org>,
"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [PATCH v2] x86/syscalls: Mark expected switch fall-throughs
Date: Wed, 27 Mar 2019 19:15:04 -0400 [thread overview]
Message-ID: <20190327191504.673d1a6a@gandalf.local.home> (raw)
In-Reply-To: <20190327231215.GA815@altlinux.org>
On Thu, 28 Mar 2019 02:12:15 +0300
"Dmitry V. Levin" <ldv@altlinux.org> wrote:
> > Seriously. If we keep it can we at least remove all the unused arguments
> > which we have on both functions to simplify the whole mess?
>
> In case of syscall_set_arguments() I think we can safely remove
> "i" and "n" arguments assuming i == 0 and n == 6.
>
> All I can say about syscall_get_arguments() is that
> - all current users invoke it with i == 0,
> - all current users that invoke it with n != 6 are in kernel/trace/trace_syscalls.c
> so it may actually be invoked with n < 6.
Yes, that's what my old (and current) patches address. I removed the
i,n parameters and make it 0,6 hardcoded in the routines.
Patches will be out soon.
-- Steve
prev parent reply other threads:[~2019-03-27 23:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 19:27 [PATCH v2] x86/syscalls: Mark expected switch fall-throughs Gustavo A. R. Silva
2019-03-23 16:14 ` Thomas Gleixner
2019-03-26 15:12 ` Oleg Nesterov
2019-03-26 16:09 ` Thomas Gleixner
2019-03-26 16:16 ` Steven Rostedt
2019-03-26 16:17 ` Thomas Gleixner
2019-03-27 1:26 ` Dmitry V. Levin
2019-03-27 14:29 ` Thomas Gleixner
2019-03-27 22:20 ` Dmitry V. Levin
2019-03-27 22:52 ` Thomas Gleixner
2019-03-27 23:03 ` Steven Rostedt
2019-03-27 23:12 ` Dmitry V. Levin
2019-03-27 23:15 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190327191504.673d1a6a@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=bp@alien8.de \
--cc=ebiederm@xmission.com \
--cc=gustavo@embeddedor.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=ldv@altlinux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).