linux-next: Fixes tag needs some work in the tty.current tree

linux-next: Fixes tag needs some work in the tty.current tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 421 bytes --]

Hi all,

In commit

  69646d7a3689 ("tty/serial: atmel: RS485 HD w/DMA: enable RX after TX is stopped")

Fixes tag

  Fixes: b389f173aaa1 ("tty/serial: atmel: RS485 half duplex w/DMA: enable

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags across more than 1 line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the tty.current tree

[Greg KH]

On Thu, Mar 28, 2019 at 07:27:34AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   69646d7a3689 ("tty/serial: atmel: RS485 HD w/DMA: enable RX after TX is stopped")
> 
> Fixes tag
> 
>   Fixes: b389f173aaa1 ("tty/serial: atmel: RS485 half duplex w/DMA: enable
> 
> has these problem(s):
> 
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
> 
> Please do not split Fixes tags across more than 1 line.

Is there a script somewhere that I can use to run on my tree before I
push it out, much like I do now for the signed-off-by checks?

thanks,

greg k-h

Re: linux-next: Fixes tag needs some work in the tty.current tree

[Stephen Rothwell]

[-- Attachment #1.1: Type: text/plain, Size: 283 bytes --]

Hi Greg,

On Fri, 29 Mar 2019 20:47:18 +0100 Greg KH <greg@kroah.com> wrote:
>
> Is there a script somewhere that I can use to run on my tree before I
> push it out, much like I do now for the signed-off-by checks?

Attached is what I use ...
-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: check_fixes --]
[-- Type: application/x-shellscript, Size: 4342 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the tty.current tree

[Greg KH]

On Sat, Mar 30, 2019 at 04:25:29PM +1100, Stephen Rothwell wrote:
> Hi Greg,
> 
> On Fri, 29 Mar 2019 20:47:18 +0100 Greg KH <greg@kroah.com> wrote:
> >
> > Is there a script somewhere that I can use to run on my tree before I
> > push it out, much like I do now for the signed-off-by checks?
> 
> Attached is what I use ...

Nice, thanks!

Perhaps this should be added to checkpatch someday :)

greg k-h