From: Petr Mladek <pmladek@suse.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, rafael@kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-acpi@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 5/5] lib/vsprintf: Add %pfw conversion specifier for printing fwnode names
Date: Thu, 28 Mar 2019 15:35:39 +0100 [thread overview]
Message-ID: <20190328143539.nty4xzwnml47vcj2@pathway.suse.cz> (raw)
In-Reply-To: <20190327141047.bhndwqde7vjz6bad@paasikivi.fi.intel.com>
On Wed 2019-03-27 16:10:48, Sakari Ailus wrote:
> Hi Petr,
>
> On Tue, Mar 26, 2019 at 04:13:07PM +0100, Petr Mladek wrote:
> > On Fri 2019-03-22 17:29:30, Sakari Ailus wrote:
> > > Add support for %pfw conversion specifier (with "f" and "P" modifiers) to
> > > support printing full path of the node, including its name ("f") and only
> > > the node's name ("P") in the printk family of functions. The two flags
> > > have equivalent functionality to existing %pOF with the same two modifiers
> > > ("f" and "P") on OF based systems. The ability to do the same on ACPI
> > > based systems is added by this patch.
> > >
> > > On ACPI based systems the resulting strings look like
> > >
> > > \_SB.PCI0.CIO2.port@1.endpoint@0
> > >
> > > where the nodes are separated by a dot (".") and the first three are
> > > ACPI device nodes and the latter two ACPI data nodes.
> > >
> > > Depends-on: ("vsprintf: Remove support for %pF and %pf in favour of %pS and %ps")
> >
> > Reusing obsolete modifiers is dangerous from many reasons:
> >
> > + people might miss the change of the meaning
> > + backporting mistakes
> > + 3rd party modules
> >
> > It might be acceptable if the long term gain is bigger
> > than a short time difficulties. But it would be better
> > to it a safe way when possible.
> >
> > Fortunately, we could keep the backward compatibility
> > for "%pf" and handle only "%pfw*" with the fwnode api.
>
> The v2 of this patch produces a warning (using WARN_ONCE()) for "%pf" not
> immediately followed by "w". "%pfw" was not a valid conversion specifier
> before this set, so we're actually not re-using the exactly same conversion
> specifiers.
I see. I would keep the two patchsets separate. I mean that this
patchset should expect that the original handling of %pf is still
there.
The way how to remove or obsolete "%pf" should be handled in
the patchset removing all %pf users or it can be done
in a completely separate patch.
The conflict can get handled when merging the two patchsets.
Best Regards,
Petr
prev parent reply other threads:[~2019-03-28 14:35 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 15:29 [PATCH 0/5] Device property improvements, add %pfw format specifier Sakari Ailus
2019-03-22 15:29 ` [PATCH 1/5] device property: Add functions for accessing node's parents Sakari Ailus
2019-03-22 15:29 ` [PATCH 2/5] device property: Add fwnode_get_name for returning the name of a node Sakari Ailus
2019-03-24 17:21 ` Randy Dunlap
2019-03-24 18:19 ` Sakari Ailus
2019-03-22 15:29 ` [PATCH 3/5] device property: Add a function to obtain a node's prefix Sakari Ailus
2019-03-22 15:29 ` [PATCH 4/5] lib/vsprintf: Make use of fwnode API to obtain node names and separators Sakari Ailus
2019-03-27 12:53 ` Petr Mladek
2019-03-27 13:49 ` Sakari Ailus
2019-03-22 15:29 ` [PATCH 5/5] lib/vsprintf: Add %pfw conversion specifier for printing fwnode names Sakari Ailus
2019-03-22 17:21 ` Andy Shevchenko
2019-03-24 18:17 ` Sakari Ailus
2019-03-26 13:13 ` Andy Shevchenko
2019-03-26 13:39 ` Sakari Ailus
2019-03-26 13:55 ` Andy Shevchenko
2019-03-26 14:09 ` Sakari Ailus
2019-03-26 15:21 ` Petr Mladek
2019-03-26 14:06 ` Heikki Krogerus
2019-03-26 14:12 ` Sakari Ailus
2019-03-26 14:30 ` Andy Shevchenko
2019-03-26 15:50 ` Petr Mladek
2019-03-26 14:30 ` Heikki Krogerus
2019-03-26 15:13 ` Petr Mladek
2019-03-27 14:10 ` Sakari Ailus
2019-03-28 14:35 ` Petr Mladek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190328143539.nty4xzwnml47vcj2@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).