From: David Miller <davem@davemloft.net>
To: lifonghsu@synology.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: net: fix routing encapsulated packets when binding a socket to a tunnel interface
Date: Fri, 29 Mar 2019 10:40:26 -0700 (PDT) [thread overview]
Message-ID: <20190329.104026.2135814725468775566.davem@davemloft.net> (raw)
In-Reply-To: <6143cbeaab4f37bc2314caa3690063d4@synology.com>
From: lifonghsu <lifonghsu@synology.com>
Date: Thu, 28 Mar 2019 16:30:37 +0800
> Indeed, skb_iif is used as receive site indication to present "device
> the packet arrived on".
> This commit keeps the previous arrived device (similar to the concept
> of "device the packet arrived on") in skb_iif field to prevent kernel
> from referring sk_bound_dev_if again. Otherwise, we might need to add
> a new field to sk_buff structure for our purpose.
Therefore, you are deciding to arbitrarily repurpose an RX side piece
of state for TX purposes.
Do not do this.
It confuses anyone trying to understand how skb_iif works.
You must use something with a different name, and clear semantics, to
achieve this goal.
For example, you could use an anonymous union:
union {
int skb_iif;
bool bound_dev_already_applied;
};
You never actually _USE_ the value of skb_iif, it is just merely a
boolean indicating whether sk_bound_dev_if was applied already.
next prev parent reply other threads:[~2019-03-29 17:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 6:29 net: fix routing encapsulated packets when binding a socket to a tunnel interface lifonghsu
2019-03-25 23:16 ` David Miller
2019-03-27 20:44 ` David Miller
2019-03-28 8:30 ` lifonghsu
2019-03-29 17:40 ` David Miller [this message]
2019-04-01 3:00 ` lifonghsu
2019-04-01 6:01 ` David Miller
2019-04-01 9:52 ` lifonghsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190329.104026.2135814725468775566.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=lifonghsu@synology.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).