From: lifonghsu <lifonghsu@synology.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: net: fix routing encapsulated packets when binding a socket to a tunnel interface
Date: Mon, 01 Apr 2019 11:00:22 +0800 [thread overview]
Message-ID: <e87a85a8c91d96951c4fa923d1563dcd@synology.com> (raw)
In-Reply-To: <20190329.104026.2135814725468775566.davem@davemloft.net>
David Miller 於 2019-03-30 01:40 寫到:
> From: lifonghsu <lifonghsu@synology.com>
> Date: Thu, 28 Mar 2019 16:30:37 +0800
>
>> Indeed, skb_iif is used as receive site indication to present "device
>> the packet arrived on".
>> This commit keeps the previous arrived device (similar to the concept
>> of "device the packet arrived on") in skb_iif field to prevent kernel
>> from referring sk_bound_dev_if again. Otherwise, we might need to add
>> a new field to sk_buff structure for our purpose.
>
> Therefore, you are deciding to arbitrarily repurpose an RX side piece
> of state for TX purposes.
>
> Do not do this.
>
> It confuses anyone trying to understand how skb_iif works.
>
> You must use something with a different name, and clear semantics, to
> achieve this goal.
>
> For example, you could use an anonymous union:
>
> union {
> int skb_iif;
> bool bound_dev_already_applied;
> };
>
> You never actually _USE_ the value of skb_iif, it is just merely a
> boolean indicating whether sk_bound_dev_if was applied already.
Since we are not sure whether there is any code referring to the value
of
skb_iff in transmit site or not, it is risky to set an invalid interface
index to skb_iif in an anonymous union.
What if we add a bit (e.g., __u8 bound_dev_already_applied:1;) to
sk_buff?
next prev parent reply other threads:[~2019-04-01 3:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 6:29 net: fix routing encapsulated packets when binding a socket to a tunnel interface lifonghsu
2019-03-25 23:16 ` David Miller
2019-03-27 20:44 ` David Miller
2019-03-28 8:30 ` lifonghsu
2019-03-29 17:40 ` David Miller
2019-04-01 3:00 ` lifonghsu [this message]
2019-04-01 6:01 ` David Miller
2019-04-01 9:52 ` lifonghsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e87a85a8c91d96951c4fa923d1563dcd@synology.com \
--to=lifonghsu@synology.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).