From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Petr Mladek <pmladek@suse.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v2 1/6] device property: Add functions for accessing node's parents
Date: Fri, 29 Mar 2019 16:46:47 +0200 [thread overview]
Message-ID: <20190329144647.uogfwc7wswgbcykj@kekkonen.localdomain> (raw)
In-Reply-To: <20190329141549.GZ9224@smile.fi.intel.com>
Hi Andy,
On Fri, Mar 29, 2019 at 04:15:49PM +0200, Andy Shevchenko wrote:
> On Fri, Mar 29, 2019 at 03:15:07PM +0200, Sakari Ailus wrote:
> > On Thu, Mar 28, 2019 at 03:52:35PM +0100, Rafael J. Wysocki wrote:
> > > On Thu, Mar 28, 2019 at 12:13 PM Sakari Ailus
> > > <sakari.ailus@linux.intel.com> wrote:
> > > > On Thu, Mar 28, 2019 at 10:38:01AM +0100, Rafael J. Wysocki wrote:
> > > > > On Wed, Mar 27, 2019 at 3:20 PM Sakari Ailus
> > > > > <sakari.ailus@linux.intel.com> wrote:
> > > > > > On Wed, Mar 27, 2019 at 01:26:25PM +0100, Petr Mladek wrote:
> > > > > > > On Tue 2019-03-26 14:41:01, Sakari Ailus wrote:
>
> > Another option would be changing where the counting starts --- the first
> > parent. I.e.
>
> Looks better to me, though can you put comment how parents are being counted?
To the code? The kerneldoc comment contains one, and the code below is
pretty simple.
>
> > fwnode = fwnode_get_parent(fwnode);
> >
> > for (count = 0; fwnode; count++)
> > fwnode = fwnode_get_next_parent(fwnode);
> >
> > return count;
>
--
Sakari Ailus
sakari.ailus@linux.intel.com
next prev parent reply other threads:[~2019-03-29 14:47 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 12:41 [PATCH v2 0/6] Device property improvements, add %pfw format specifier Sakari Ailus
2019-03-26 12:41 ` [PATCH v2 1/6] device property: Add functions for accessing node's parents Sakari Ailus
2019-03-27 12:26 ` Petr Mladek
2019-03-27 14:20 ` Sakari Ailus
2019-03-28 9:38 ` Rafael J. Wysocki
2019-03-28 11:13 ` Sakari Ailus
2019-03-28 14:52 ` Rafael J. Wysocki
2019-03-29 13:15 ` Sakari Ailus
2019-03-29 14:15 ` Andy Shevchenko
2019-03-29 14:46 ` Sakari Ailus [this message]
2019-03-29 23:00 ` Rafael J. Wysocki
2019-03-28 14:10 ` Petr Mladek
2019-03-29 13:04 ` Sakari Ailus
2019-03-29 14:14 ` Andy Shevchenko
2019-03-29 15:31 ` Sakari Ailus
2019-03-26 12:41 ` [PATCH v2 2/6] device property: Add fwnode_get_name for returning the name of a node Sakari Ailus
2019-03-28 9:45 ` Rafael J. Wysocki
2019-03-28 11:31 ` Sakari Ailus
2019-03-31 6:42 ` Rob Herring
2019-03-26 12:41 ` [PATCH v2 3/6] device property: Add a function to obtain a node's prefix Sakari Ailus
2019-03-26 13:16 ` Andy Shevchenko
2019-03-26 13:32 ` Sakari Ailus
2019-03-27 12:36 ` Petr Mladek
2019-03-28 11:43 ` Sakari Ailus
2019-03-31 6:42 ` Rob Herring
2019-03-26 12:41 ` [PATCH v2 4/6] lib/vsprintf: Remove support for %pF and %pf in favour of %pS and %ps Sakari Ailus
2019-03-26 12:41 ` [PATCH v2 5/6] lib/vsprintf: Make use of fwnode API to obtain node names and separators Sakari Ailus
2019-03-26 12:41 ` [PATCH v2 6/6] lib/vsprintf: Add %pfw conversion specifier for printing fwnode names Sakari Ailus
2019-03-26 13:11 ` Rasmus Villemoes
2019-03-26 13:24 ` Andy Shevchenko
2019-03-26 13:31 ` Sakari Ailus
2019-03-28 14:29 ` Petr Mladek
2019-03-29 13:10 ` Sakari Ailus
2019-03-26 20:18 ` Joe Perches
[not found] ` <20190328114845.giusyarjibvg5ru7@kekkonen.localdomain>
2019-03-28 11:51 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190329144647.uogfwc7wswgbcykj@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).