[PATCH] regulator: vctrl: Remove unneeded continue statement

[PATCH] regulator: vctrl: Remove unneeded continue statement

[Axel Lin]

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/regulator/vctrl-regulator.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/regulator/vctrl-regulator.c b/drivers/regulator/vctrl-regulator.c
index 78de002037c7..259864520a06 100644
--- a/drivers/regulator/vctrl-regulator.c
+++ b/drivers/regulator/vctrl-regulator.c
@@ -334,10 +334,8 @@ static int vctrl_init_vtable(struct platform_device *pdev)
 		ctrl_uV = regulator_list_voltage(ctrl_reg, i);
 
 		if (ctrl_uV < vrange_ctrl->min_uV ||
-		    ctrl_uV > vrange_ctrl->max_uV) {
+		    ctrl_uV > vrange_ctrl->max_uV)
 			rdesc->n_voltages--;
-			continue;
-		}
 	}
 
 	if (rdesc->n_voltages == 0) {
-- 
2.17.1

Re: [PATCH] regulator: vctrl: Remove unneeded continue statement

[Mukesh Ojha]

On 3/29/2019 7:16 AM, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>


Yeah indeed! but where is commit text atleast a one-liner.

Otherwise looks good to me.
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>

Cheers,
-Mukesh


> ---
>   drivers/regulator/vctrl-regulator.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/regulator/vctrl-regulator.c b/drivers/regulator/vctrl-regulator.c
> index 78de002037c7..259864520a06 100644
> --- a/drivers/regulator/vctrl-regulator.c
> +++ b/drivers/regulator/vctrl-regulator.c
> @@ -334,10 +334,8 @@ static int vctrl_init_vtable(struct platform_device *pdev)
>   		ctrl_uV = regulator_list_voltage(ctrl_reg, i);
>   
>   		if (ctrl_uV < vrange_ctrl->min_uV ||
> -		    ctrl_uV > vrange_ctrl->max_uV) {
> +		    ctrl_uV > vrange_ctrl->max_uV)
>   			rdesc->n_voltages--;
> -			continue;
> -		}
>   	}
>   
>   	if (rdesc->n_voltages == 0) {

Re: [PATCH] regulator: vctrl: Remove unneeded continue statement

[Matthias Kaehlcke]

Hi Axel,

On Fri, Mar 29, 2019 at 09:46:31AM +0800, Axel Lin wrote:

As Mukesh already mentioned, there should be a short description.

> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
>  drivers/regulator/vctrl-regulator.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/regulator/vctrl-regulator.c b/drivers/regulator/vctrl-regulator.c
> index 78de002037c7..259864520a06 100644
> --- a/drivers/regulator/vctrl-regulator.c
> +++ b/drivers/regulator/vctrl-regulator.c
> @@ -334,10 +334,8 @@ static int vctrl_init_vtable(struct platform_device *pdev)
>  		ctrl_uV = regulator_list_voltage(ctrl_reg, i);
>  
>  		if (ctrl_uV < vrange_ctrl->min_uV ||
> -		    ctrl_uV > vrange_ctrl->max_uV) {
> +		    ctrl_uV > vrange_ctrl->max_uV)
>  			rdesc->n_voltages--;
> -			continue;
> -		}

indeed, the 'continue' is pointless here. I guess at some stage of
development something else was done in the loop and this is a
leftover.

Reviewed-by: Matthias Kaehlcke <mka@chromium.org>