From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: Jonathan Corbet <corbet@lwn.net>
Cc: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
linux-doc@vger.kernel.org, "Vinod Koul" <vkoul@kernel.org>,
"Sanyog Kale" <sanyog.r.kale@intel.com>,
"Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Documentation: soundwire: Ensure that code is inside the code blocks
Date: Tue, 2 Apr 2019 00:52:11 +0200 [thread overview]
Message-ID: <20190401225211.GE2095@latitude> (raw)
In-Reply-To: <20190401154003.7eddc9e9@lwn.net>
[-- Attachment #1: Type: text/plain, Size: 926 bytes --]
On Mon, Apr 01, 2019 at 03:40:03PM -0600, Jonathan Corbet wrote:
> On Mon, 1 Apr 2019 00:34:22 +0200
> Jonathan Neuschäfer <j.neuschaefer@gmx.net> wrote:
>
> > The way the document is written now, Sphinx renders empty code blocks
> > followed by the lines that should be inside them.
> >
> > Unindent the code-block directives to fix this.
> >
> > Fixes: 502c00d9c315 ("Documentation: soundwire: fix stream.rst markup warnings")
> > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
>
> That definitely makes things better. Applied, thanks.
>
> I'm going to take out the Fixes tag, though, since the named commit did
> not, in fact, introduce that problem.
Ah, true, the wrong indentation didn't come from that commit.
> It's also good to copy authors of patches named in Fixes tags so they
> can defend themselves :)
Good idea, I'll try to remember that.
Jonathan Neuschäfer
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-04-01 22:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-31 22:34 [PATCH] Documentation: soundwire: Ensure that code is inside the code blocks Jonathan Neuschäfer
2019-04-01 21:40 ` Jonathan Corbet
2019-04-01 22:52 ` Jonathan Neuschäfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190401225211.GE2095@latitude \
--to=j.neuschaefer@gmx.net \
--cc=alsa-devel@alsa-project.org \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).