linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mfd: axp20x: Allow the AXP223 to be probed by i2c
@ 2019-03-18 12:55 Maxime Ripard
  2019-03-22  8:53 ` Chen-Yu Tsai
  2019-04-02  7:01 ` Lee Jones
  0 siblings, 2 replies; 3+ messages in thread
From: Maxime Ripard @ 2019-03-18 12:55 UTC (permalink / raw)
  To: Lee Jones; +Cc: Chen-Yu Tsai, Maxime Ripard, linux-arm-kernel, linux-kernel

The AXP223 can be used both using the RSB proprietary bus, or a more
traditional I2C bus. The RSB is a faster bus and provides more features
(like some integrity checks on the messages), so it's usually preferrable
to use it, but since it's proprietary, when we want to use the PMIC in a
multi-master setup, the i2c might make sense as well.

Let's add that possibility.

Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
---
 drivers/mfd/axp20x-i2c.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/mfd/axp20x-i2c.c b/drivers/mfd/axp20x-i2c.c
index a7b7c5423ea5..c2e8a0dee7f8 100644
--- a/drivers/mfd/axp20x-i2c.c
+++ b/drivers/mfd/axp20x-i2c.c
@@ -65,6 +65,7 @@ static const struct of_device_id axp20x_i2c_of_match[] = {
 	{ .compatible = "x-powers,axp202", .data = (void *)AXP202_ID },
 	{ .compatible = "x-powers,axp209", .data = (void *)AXP209_ID },
 	{ .compatible = "x-powers,axp221", .data = (void *)AXP221_ID },
+	{ .compatible = "x-powers,axp223", .data = (void *)AXP223_ID },
 	{ .compatible = "x-powers,axp806", .data = (void *)AXP806_ID },
 	{ },
 };
@@ -75,6 +76,7 @@ static const struct i2c_device_id axp20x_i2c_id[] = {
 	{ "axp202", 0 },
 	{ "axp209", 0 },
 	{ "axp221", 0 },
+	{ "axp223", 0 },
 	{ "axp806", 0 },
 	{ },
 };
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] mfd: axp20x: Allow the AXP223 to be probed by i2c
  2019-03-18 12:55 [PATCH] mfd: axp20x: Allow the AXP223 to be probed by i2c Maxime Ripard
@ 2019-03-22  8:53 ` Chen-Yu Tsai
  2019-04-02  7:01 ` Lee Jones
  1 sibling, 0 replies; 3+ messages in thread
From: Chen-Yu Tsai @ 2019-03-22  8:53 UTC (permalink / raw)
  To: Maxime Ripard; +Cc: Lee Jones, linux-arm-kernel, linux-kernel

On Mon, Mar 18, 2019 at 8:55 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> The AXP223 can be used both using the RSB proprietary bus, or a more
> traditional I2C bus. The RSB is a faster bus and provides more features
> (like some integrity checks on the messages), so it's usually preferrable
> to use it, but since it's proprietary, when we want to use the PMIC in a
> multi-master setup, the i2c might make sense as well.
>
> Let's add that possibility.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>

Acked-by: Chen-Yu Tsai <wens@csie.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mfd: axp20x: Allow the AXP223 to be probed by i2c
  2019-03-18 12:55 [PATCH] mfd: axp20x: Allow the AXP223 to be probed by i2c Maxime Ripard
  2019-03-22  8:53 ` Chen-Yu Tsai
@ 2019-04-02  7:01 ` Lee Jones
  1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2019-04-02  7:01 UTC (permalink / raw)
  To: Maxime Ripard; +Cc: Chen-Yu Tsai, linux-arm-kernel, linux-kernel

On Mon, 18 Mar 2019, Maxime Ripard wrote:

> The AXP223 can be used both using the RSB proprietary bus, or a more
> traditional I2C bus. The RSB is a faster bus and provides more features
> (like some integrity checks on the messages), so it's usually preferrable
> to use it, but since it's proprietary, when we want to use the PMIC in a
> multi-master setup, the i2c might make sense as well.
> 
> Let's add that possibility.
> 
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
> ---
>  drivers/mfd/axp20x-i2c.c | 2 ++
>  1 file changed, 2 insertions(+)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-04-02  7:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-18 12:55 [PATCH] mfd: axp20x: Allow the AXP223 to be probed by i2c Maxime Ripard
2019-03-22  8:53 ` Chen-Yu Tsai
2019-04-02  7:01 ` Lee Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).